[10] RFR: 8167409: Invalid value passed to critical JNI function

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[10] RFR: 8167409: Invalid value passed to critical JNI function

Jamsheed C m
Hi,

request for review,

jbs: https://bugs.openjdk.java.net/browse/JDK-8167409

webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.00/

(contributed by Ioannis Tsakpinis)

desc: the tmp  reg used to break the shuffling cycle (handled in
ComputeMoveOrder)

is set to 64 bit.

Best regards,

Jamsheed


Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8167409: Invalid value passed to critical JNI function

dean.long
Hi Jamsheed.  Do you have a test for this?

dl


On 10/30/17 9:45 AM, jamsheed wrote:

> Hi,
>
> request for review,
>
> jbs: https://bugs.openjdk.java.net/browse/JDK-8167409
>
> webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.00/
>
> (contributed by Ioannis Tsakpinis)
>
> desc: the tmp  reg used to break the shuffling cycle (handled in
> ComputeMoveOrder)
>
> is set to 64 bit.
>
> Best regards,
>
> Jamsheed
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8167409: Invalid value passed to critical JNI function

Jamsheed C m
In reply to this post by Jamsheed C m
Hi Dean,

i have added a test case now,

revised webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.01/

Best regards,

Jamsheed


On Monday 30 October 2017 10:15 PM, jamsheed wrote:

> Hi,
>
> request for review,
>
> jbs: https://bugs.openjdk.java.net/browse/JDK-8167409
>
> webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.00/
>
> (contributed by Ioannis Tsakpinis)
>
> desc: the tmp  reg used to break the shuffling cycle (handled in
> ComputeMoveOrder)
>
> is set to 64 bit.
>
> Best regards,
>
> Jamsheed
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8167409: Invalid value passed to critical JNI function

dean.long
Looks good.

dl


On 11/3/17 8:08 AM, jamsheed wrote:

> Hi Dean,
>
> i have added a test case now,
>
> revised webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.01/
>
> Best regards,
>
> Jamsheed
>
>
> On Monday 30 October 2017 10:15 PM, jamsheed wrote:
>> Hi,
>>
>> request for review,
>>
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8167409
>>
>> webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.00/
>>
>> (contributed by Ioannis Tsakpinis)
>>
>> desc: the tmp  reg used to break the shuffling cycle (handled in
>> ComputeMoveOrder)
>>
>> is set to 64 bit.
>>
>> Best regards,
>>
>> Jamsheed
>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8167409: Invalid value passed to critical JNI function

Jamsheed C m
Thank you, Dean

Best regards,

Jamsheed


On Saturday 04 November 2017 12:52 AM, [hidden email] wrote:

> Looks good.
>
> dl
>
>
> On 11/3/17 8:08 AM, jamsheed wrote:
>> Hi Dean,
>>
>> i have added a test case now,
>>
>> revised webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.01/
>>
>> Best regards,
>>
>> Jamsheed
>>
>>
>> On Monday 30 October 2017 10:15 PM, jamsheed wrote:
>>> Hi,
>>>
>>> request for review,
>>>
>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8167409
>>>
>>> webrev: http://cr.openjdk.java.net/~jcm/8167409/webrev.00/
>>>
>>> (contributed by Ioannis Tsakpinis)
>>>
>>> desc: the tmp  reg used to break the shuffling cycle (handled in
>>> ComputeMoveOrder)
>>>
>>> is set to 64 bit.
>>>
>>> Best regards,
>>>
>>> Jamsheed
>>>
>>>
>>
>