[10] RFR 8175251: Failed to load RSA private key from pkcs12

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[10] RFR 8175251: Failed to load RSA private key from pkcs12

Valerie Peng

Hi Sean,

Can you please help reviewing the fix for JDK-8175251 "Failed to load RSA private key from pkcs12"
Bug: https://bugs.openjdk.java.net/browse/JDK-8175251
Webrev: http://cr.openjdk.java.net/~valeriep/8175251/webrev.00/

Thanks,
Valerie
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[9] RFR 8175251: Failed to load RSA private key from pkcs12

Valerie Peng

Re-send with the correct release version. This fix is intended for JDK-9.
Thanks,
Valerie

On 3/13/2017 6:24 PM, Valerie Peng wrote:

Hi Sean,

Can you please help reviewing the fix for JDK-8175251 "Failed to load RSA private key from pkcs12"
Bug: https://bugs.openjdk.java.net/browse/JDK-8175251
Webrev: http://cr.openjdk.java.net/~valeriep/8175251/webrev.00/

Thanks,
Valerie

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR 8175251: Failed to load RSA private key from pkcs12

Sean Mullan
The fix looks good.

--Sean

On 3/13/17 9:25 PM, Valerie Peng wrote:

>
> Re-send with the correct release version. This fix is intended for JDK-9.
> Thanks,
> Valerie
>
> On 3/13/2017 6:24 PM, Valerie Peng wrote:
>>
>> Hi Sean,
>>
>> Can you please help reviewing the fix for JDK-8175251 "Failed to load
>> RSA private key from pkcs12"
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8175251
>> Webrev: http://cr.openjdk.java.net/~valeriep/8175251/webrev.00/
>>
>> Thanks,
>> Valerie
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR 8175251: Failed to load RSA private key from pkcs12

Valerie Peng
Sean,
I added a regression test and fixed a minor issue in existing regression
test.
Can you please take a look?
http://cr.openjdk.java.net/~valeriep/8175251/webrev.01/

Thanks,
Valerie

On 3/14/2017 12:54 PM, Sean Mullan wrote:

> The fix looks good.
>
> --Sean
>
> On 3/13/17 9:25 PM, Valerie Peng wrote:
>>
>> Re-send with the correct release version. This fix is intended for
>> JDK-9.
>> Thanks,
>> Valerie
>>
>> On 3/13/2017 6:24 PM, Valerie Peng wrote:
>>>
>>> Hi Sean,
>>>
>>> Can you please help reviewing the fix for JDK-8175251 "Failed to load
>>> RSA private key from pkcs12"
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8175251
>>> Webrev: http://cr.openjdk.java.net/~valeriep/8175251/webrev.00/
>>>
>>> Thanks,
>>> Valerie
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR 8175251: Failed to load RSA private key from pkcs12

Sean Mullan
Looks good.

--Sean

On 3/15/17 3:35 PM, Valerie Peng wrote:

> Sean,
> I added a regression test and fixed a minor issue in existing regression
> test.
> Can you please take a look?
> http://cr.openjdk.java.net/~valeriep/8175251/webrev.01/
>
> Thanks,
> Valerie
>
> On 3/14/2017 12:54 PM, Sean Mullan wrote:
>> The fix looks good.
>>
>> --Sean
>>
>> On 3/13/17 9:25 PM, Valerie Peng wrote:
>>>
>>> Re-send with the correct release version. This fix is intended for
>>> JDK-9.
>>> Thanks,
>>> Valerie
>>>
>>> On 3/13/2017 6:24 PM, Valerie Peng wrote:
>>>>
>>>> Hi Sean,
>>>>
>>>> Can you please help reviewing the fix for JDK-8175251 "Failed to load
>>>> RSA private key from pkcs12"
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8175251
>>>> Webrev: http://cr.openjdk.java.net/~valeriep/8175251/webrev.00/
>>>>
>>>> Thanks,
>>>> Valerie
>>>
>
Loading...