Quantcast

[10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

Robbin Ehn
Hi all, please review.

INCLUDE_TRACE is set either 0 or 1.
Checks should be "#if INCLUDE_TRACE" and not "#ifdef INCLUDE_TRACE".

Bug: https://bugs.openjdk.java.net/browse/JDK-8176096
Webrev: http://cr.openjdk.java.net/~rehn/8176096/webrev/

Test built open and oracle.

Thanks Robbin
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

Markus Gronlund
Hi Robbin,

Looks good, thanks for fixing this.

Markus

-----Original Message-----
From: Robbin Ehn
Sent: den 2 mars 2017 15:12
To: [hidden email]
Cc: Markus Grönlund
Subject: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

Hi all, please review.

INCLUDE_TRACE is set either 0 or 1.
Checks should be "#if INCLUDE_TRACE" and not "#ifdef INCLUDE_TRACE".

Bug: https://bugs.openjdk.java.net/browse/JDK-8176096
Webrev: http://cr.openjdk.java.net/~rehn/8176096/webrev/

Test built open and oracle.

Thanks Robbin
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

coleen.phillimore
+1
Coleen

On 3/2/17 3:36 PM, Markus Gronlund wrote:

> Hi Robbin,
>
> Looks good, thanks for fixing this.
>
> Markus
>
> -----Original Message-----
> From: Robbin Ehn
> Sent: den 2 mars 2017 15:12
> To: [hidden email]
> Cc: Markus Grönlund
> Subject: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE
>
> Hi all, please review.
>
> INCLUDE_TRACE is set either 0 or 1.
> Checks should be "#if INCLUDE_TRACE" and not "#ifdef INCLUDE_TRACE".
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176096
> Webrev: http://cr.openjdk.java.net/~rehn/8176096/webrev/
>
> Test built open and oracle.
>
> Thanks Robbin

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

Robbin Ehn
In reply to this post by Markus Gronlund
Thanks Markus!

On 03/02/2017 03:36 PM, Markus Gronlund wrote:

> Hi Robbin,
>
> Looks good, thanks for fixing this.
>
> Markus
>
> -----Original Message-----
> From: Robbin Ehn
> Sent: den 2 mars 2017 15:12
> To: [hidden email]
> Cc: Markus Grönlund
> Subject: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE
>
> Hi all, please review.
>
> INCLUDE_TRACE is set either 0 or 1.
> Checks should be "#if INCLUDE_TRACE" and not "#ifdef INCLUDE_TRACE".
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176096
> Webrev: http://cr.openjdk.java.net/~rehn/8176096/webrev/
>
> Test built open and oracle.
>
> Thanks Robbin
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

Robbin Ehn
In reply to this post by coleen.phillimore
Thanks Coleen!

On 03/02/2017 03:54 PM, [hidden email] wrote:

> +1
> Coleen
>
> On 3/2/17 3:36 PM, Markus Gronlund wrote:
>> Hi Robbin,
>>
>> Looks good, thanks for fixing this.
>>
>> Markus
>>
>> -----Original Message-----
>> From: Robbin Ehn
>> Sent: den 2 mars 2017 15:12
>> To: [hidden email]
>> Cc: Markus Grönlund
>> Subject: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE
>>
>> Hi all, please review.
>>
>> INCLUDE_TRACE is set either 0 or 1.
>> Checks should be "#if INCLUDE_TRACE" and not "#ifdef INCLUDE_TRACE".
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8176096
>> Webrev: http://cr.openjdk.java.net/~rehn/8176096/webrev/
>>
>> Test built open and oracle.
>>
>> Thanks Robbin
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10]RFR: 8176096: Wrong marco checks for INCLUDE_TRACE

David Holmes
In reply to this post by Robbin Ehn
+1

But please fix the typo in the subject before committing :) I already
updated the bug itself.

Thanks,
David

On 3/03/2017 12:11 AM, Robbin Ehn wrote:

> Hi all, please review.
>
> INCLUDE_TRACE is set either 0 or 1.
> Checks should be "#if INCLUDE_TRACE" and not "#ifdef INCLUDE_TRACE".
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176096
> Webrev: http://cr.openjdk.java.net/~rehn/8176096/webrev/
>
> Test built open and oracle.
>
> Thanks Robbin
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10]RFR: 8176096: Wrong macro checks for INCLUDE_TRACE

Robbin Ehn
Thanks David and thanks for spotting my typo!

/Robbin

On 03/03/2017 12:21 AM, David Holmes wrote:

> +1
>
> But please fix the typo in the subject before committing :) I already updated the bug itself.
>
> Thanks,
> David
>
> On 3/03/2017 12:11 AM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> INCLUDE_TRACE is set either 0 or 1.
>> Checks should be "#if INCLUDE_TRACE" and not "#ifdef INCLUDE_TRACE".
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8176096
>> Webrev: http://cr.openjdk.java.net/~rehn/8176096/webrev/
>>
>> Test built open and oracle.
>>
>> Thanks Robbin
Loading...