[10] RFR: 8193699: AArch64 Fails to build after 8167372

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[10] RFR: 8193699: AArch64 Fails to build after 8167372

Rahul Raghavan
Hi,

Request help to review the following fix proposal.

<webrev> - http://cr.openjdk.java.net/~rraghavan/8193699/webrev.01/

Related <jbs> links -
-- https://bugs.openjdk.java.net/browse/JDK-8193699
-- https://bugs.openjdk.java.net/browse/JDK-8167372
  - 'Add code to check for getting oops while thread is in native'
-- https://bugs.openjdk.java.net/browse/JDK-8191227
  - 'Unsafe handle resolution in ConstantOopWriteValue::write_on() / print_on() and LIR_Assembler::jobject2reg()'

Found root cause of 8193699 issue, as missing changes for aarch64 in 'macroAssembler_aarch64.cpp',
similar to changes done for 8191227 before pushing 8167372 support.
So now fixed the issue of unsafe handle resolution in 'macroAssembler_aarch64.cpp' with the usage of ThreadInVMfromUnknown.
Stuart Monteith confirmed build failure fixed with above proposed changeset and no new issues with testing.

Thanks,
Rahul

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8193699: AArch64 Fails to build after 8167372

Stuart Monteith
The code looks OK, AFAICT. Having done a search, your patch appears to
cover all the relevant cases.

Thanks,
   Stuart


On 22 December 2017 at 09:35, Rahul Raghavan
<[hidden email]> wrote:

> Hi,
>
> Request help to review the following fix proposal.
>
> <webrev> - http://cr.openjdk.java.net/~rraghavan/8193699/webrev.01/
>
> Related <jbs> links -
> -- https://bugs.openjdk.java.net/browse/JDK-8193699
> -- https://bugs.openjdk.java.net/browse/JDK-8167372
>   - 'Add code to check for getting oops while thread is in native'
> -- https://bugs.openjdk.java.net/browse/JDK-8191227
>   - 'Unsafe handle resolution in ConstantOopWriteValue::write_on() /
> print_on() and LIR_Assembler::jobject2reg()'
>
> Found root cause of 8193699 issue, as missing changes for aarch64 in
> 'macroAssembler_aarch64.cpp',
> similar to changes done for 8191227 before pushing 8167372 support.
> So now fixed the issue of unsafe handle resolution in
> 'macroAssembler_aarch64.cpp' with the usage of ThreadInVMfromUnknown.
> Stuart Monteith confirmed build failure fixed with above proposed changeset
> and no new issues with testing.
>
> Thanks,
> Rahul
>
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8193699: AArch64 Fails to build after 8167372

Vladimir Ivanov
In reply to this post by Rahul Raghavan
Looks good.

Best regards,
Vladimir Ivanov

On 12/22/17 12:35 PM, Rahul Raghavan wrote:

> Hi,
>
> Request help to review the following fix proposal.
>
> <webrev> - http://cr.openjdk.java.net/~rraghavan/8193699/webrev.01/
>
> Related <jbs> links -
> -- https://bugs.openjdk.java.net/browse/JDK-8193699
> -- https://bugs.openjdk.java.net/browse/JDK-8167372
>    - 'Add code to check for getting oops while thread is in native'
> -- https://bugs.openjdk.java.net/browse/JDK-8191227
>    - 'Unsafe handle resolution in ConstantOopWriteValue::write_on() /
> print_on() and LIR_Assembler::jobject2reg()'
>
> Found root cause of 8193699 issue, as missing changes for aarch64 in
> 'macroAssembler_aarch64.cpp',
> similar to changes done for 8191227 before pushing 8167372 support.
> So now fixed the issue of unsafe handle resolution in
> 'macroAssembler_aarch64.cpp' with the usage of ThreadInVMfromUnknown.
> Stuart Monteith confirmed build failure fixed with above proposed
> changeset and no new issues with testing.
>
> Thanks,
> Rahul
>
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8193699: AArch64 Fails to build after 8167372

Rahul Raghavan
In reply to this post by Stuart Monteith
Thank you Stuart.

On Friday 22 December 2017 07:11 PM, Stuart Monteith wrote:

> The code looks OK, AFAICT. Having done a search, your patch appears to
> cover all the relevant cases.
>
> Thanks,
>     Stuart
>
>
> On 22 December 2017 at 09:35, Rahul Raghavan
> <[hidden email]> wrote:
>> Hi,
>>
>> Request help to review the following fix proposal.
>>
>> <webrev> - http://cr.openjdk.java.net/~rraghavan/8193699/webrev.01/
>>
>> Related <jbs> links -
>> -- https://bugs.openjdk.java.net/browse/JDK-8193699
>> -- https://bugs.openjdk.java.net/browse/JDK-8167372
>>    - 'Add code to check for getting oops while thread is in native'
>> -- https://bugs.openjdk.java.net/browse/JDK-8191227
>>    - 'Unsafe handle resolution in ConstantOopWriteValue::write_on() /
>> print_on() and LIR_Assembler::jobject2reg()'
>>
>> Found root cause of 8193699 issue, as missing changes for aarch64 in
>> 'macroAssembler_aarch64.cpp',
>> similar to changes done for 8191227 before pushing 8167372 support.
>> So now fixed the issue of unsafe handle resolution in
>> 'macroAssembler_aarch64.cpp' with the usage of ThreadInVMfromUnknown.
>> Stuart Monteith confirmed build failure fixed with above proposed changeset
>> and no new issues with testing.
>>
>> Thanks,
>> Rahul
>>
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR: 8193699: AArch64 Fails to build after 8167372

Rahul Raghavan
In reply to this post by Vladimir Ivanov
Thank you Vladimir.

On Friday 22 December 2017 10:04 PM, Vladimir Ivanov wrote:

> Looks good.
>
> Best regards,
> Vladimir Ivanov
>
> On 12/22/17 12:35 PM, Rahul Raghavan wrote:
>> Hi,
>>
>> Request help to review the following fix proposal.
>>
>> <webrev> - http://cr.openjdk.java.net/~rraghavan/8193699/webrev.01/
>>
>> Related <jbs> links -
>> -- https://bugs.openjdk.java.net/browse/JDK-8193699
>> -- https://bugs.openjdk.java.net/browse/JDK-8167372
>>    - 'Add code to check for getting oops while thread is in native'
>> -- https://bugs.openjdk.java.net/browse/JDK-8191227
>>    - 'Unsafe handle resolution in ConstantOopWriteValue::write_on() /
>> print_on() and LIR_Assembler::jobject2reg()'
>>
>> Found root cause of 8193699 issue, as missing changes for aarch64 in
>> 'macroAssembler_aarch64.cpp',
>> similar to changes done for 8191227 before pushing 8167372 support.
>> So now fixed the issue of unsafe handle resolution in
>> 'macroAssembler_aarch64.cpp' with the usage of ThreadInVMfromUnknown.
>> Stuart Monteith confirmed build failure fixed with above proposed
>> changeset and no new issues with testing.
>>
>> Thanks,
>> Rahul
>>