[10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

Calvin Cheung
bug: https://bugs.openjdk.java.net/browse/JDK-8192989

For JDK10, we're going for a simple and safe fix by not processing array
classes found in a class list during CDS dump time.
We'll revisit the dumping of array classes in JDK11.

webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/

Testing:
     hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows, sparc).

thanks,
Calvin


Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

Ioi Lam
Looks good. Thanks!

- Ioi


On 12/7/17 3:35 PM, Calvin Cheung wrote:

> bug: https://bugs.openjdk.java.net/browse/JDK-8192989
>
> For JDK10, we're going for a simple and safe fix by not processing
> array classes found in a class list during CDS dump time.
> We'll revisit the dumping of array classes in JDK11.
>
> webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/
>
> Testing:
>     hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows,
> sparc).
>
> thanks,
> Calvin
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

Calvin Cheung
Hi Ioi,

Thanks for your quick review.
I've file the following bug for JDK11:
     https://bugs.openjdk.java.net/browse/JDK-8193226

thanks,
Calvin

On 12/7/17, 4:07 PM, Ioi Lam wrote:

> Looks good. Thanks!
>
> - Ioi
>
>
> On 12/7/17 3:35 PM, Calvin Cheung wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8192989
>>
>> For JDK10, we're going for a simple and safe fix by not processing
>> array classes found in a class list during CDS dump time.
>> We'll revisit the dumping of array classes in JDK11.
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/
>>
>> Testing:
>>     hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows,
>> sparc).
>>
>> thanks,
>> Calvin
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

Jiangli Zhou
In reply to this post by Calvin Cheung
Hi Calvin,

The short-term fix looks good. For the test, please add a few multi-dimensional arrays in ArrayTest.arrayClasses[]. I want to make sure they are also identified if present in the class list. We need to test multi-dimensional arrays as well when we add proper handling for array classes.

For example:
[[[B
[[[[[Ljava/lang/Object;

Thanks,
Jiangli

> On Dec 7, 2017, at 3:35 PM, Calvin Cheung <[hidden email]> wrote:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8192989
>
> For JDK10, we're going for a simple and safe fix by not processing array classes found in a class list during CDS dump time.
> We'll revisit the dumping of array classes in JDK11.
>
> webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/
>
> Testing:
>    hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows, sparc).
>
> thanks,
> Calvin
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

Calvin Cheung
Hi Jiangli,

I've added two multidimensional arrays to the test case.
updated webrev:
     http://cr.openjdk.java.net/~ccheung/8192989/webrev.01/

thanks,
Calvin

On 12/7/17, 4:39 PM, Jiangli Zhou wrote:

> Hi Calvin,
>
> The short-term fix looks good. For the test, please add a few multi-dimensional arrays in ArrayTest.arrayClasses[]. I want to make sure they are also identified if present in the class list. We need to test multi-dimensional arrays as well when we add proper handling for array classes.
>
> For example:
> [[[B
> [[[[[Ljava/lang/Object;
>
> Thanks,
> Jiangli
>
>> On Dec 7, 2017, at 3:35 PM, Calvin Cheung<[hidden email]>  wrote:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8192989
>>
>> For JDK10, we're going for a simple and safe fix by not processing array classes found in a class list during CDS dump time.
>> We'll revisit the dumping of array classes in JDK11.
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/
>>
>> Testing:
>>     hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows, sparc).
>>
>> thanks,
>> Calvin
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

Jiangli Zhou

> On Dec 7, 2017, at 5:59 PM, Calvin Cheung <[hidden email]> wrote:
>
> Hi Jiangli,
>
> I've added two multidimensional arrays to the test case.
> updated webrev:
>    http://cr.openjdk.java.net/~ccheung/8192989/webrev.01/ <http://cr.openjdk.java.net/~ccheung/8192989/webrev.01/>

Looks ok. Thanks.

Jiangli

>
> thanks,
> Calvin
>
> On 12/7/17, 4:39 PM, Jiangli Zhou wrote:
>> Hi Calvin,
>>
>> The short-term fix looks good. For the test, please add a few multi-dimensional arrays in ArrayTest.arrayClasses[]. I want to make sure they are also identified if present in the class list. We need to test multi-dimensional arrays as well when we add proper handling for array classes.
>>
>> For example:
>> [[[B
>> [[[[[Ljava/lang/Object;
>>
>> Thanks,
>> Jiangli
>>
>>> On Dec 7, 2017, at 3:35 PM, Calvin Cheung<[hidden email]>  wrote:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8192989
>>>
>>> For JDK10, we're going for a simple and safe fix by not processing array classes found in a class list during CDS dump time.
>>> We'll revisit the dumping of array classes in JDK11.
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/
>>>
>>> Testing:
>>>    hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows, sparc).
>>>
>>> thanks,
>>> Calvin
>>>
>>>

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

Calvin Cheung
Thanks - Jiangli.

Calvin

On 12/8/17, 11:12 AM, Jiangli Zhou wrote:

>
>> On Dec 7, 2017, at 5:59 PM, Calvin Cheung <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>> Hi Jiangli,
>>
>> I've added two multidimensional arrays to the test case.
>> updated webrev:
>> http://cr.openjdk.java.net/~ccheung/8192989/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Eccheung/8192989/webrev.01/>
>
> Looks ok. Thanks.
>
> Jiangli
>
>>
>> thanks,
>> Calvin
>>
>> On 12/7/17, 4:39 PM, Jiangli Zhou wrote:
>>> Hi Calvin,
>>>
>>> The short-term fix looks good. For the test, please add a few
>>> multi-dimensional arrays in ArrayTest.arrayClasses[]. I want to make
>>> sure they are also identified if present in the class list. We need
>>> to test multi-dimensional arrays as well when we add proper handling
>>> for array classes.
>>>
>>> For example:
>>> [[[B
>>> [[[[[Ljava/lang/Object;
>>>
>>> Thanks,
>>> Jiangli
>>>
>>>> On Dec 7, 2017, at 3:35 PM, Calvin Cheung<[hidden email]
>>>> <mailto:[hidden email]>>  wrote:
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8192989
>>>>
>>>> For JDK10, we're going for a simple and safe fix by not processing
>>>> array classes found in a class list during CDS dump time.
>>>> We'll revisit the dumping of array classes in JDK11.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Eccheung/8192989/webrev.00/>
>>>>
>>>> Testing:
>>>>    hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows,
>>>> sparc).
>>>>
>>>> thanks,
>>>> Calvin
>>>>
>>>>
>