[10] RFR(XS): 8174101: Bootclasspath append should not invalidate CDS archive

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[10] RFR(XS): 8174101: Bootclasspath append should not invalidate CDS archive

Calvin Cheung
For the regular CDS case (UseAppCDS=0), only boot classes are loaded
from the archive. Therefore, we should not invalidate the archive when
the bootclasspath is appended.

bug: https://bugs.openjdk.java.net/browse/JDK-8174101

webrev: http://cr.openjdk.java.net/~ccheung/8174101/webrev.00/

Testing: hs-tier1 and hs-tier2 on linux-x64, solaris-sparc, macosx,
windows-x64.

thanks,
Calvin
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(XS): 8174101: Bootclasspath append should not invalidate CDS archive

Ioi Lam
Hi Calvin,

Looks good. Thanks for fixing this.

- Ioi


On 11/30/17 9:49 AM, Calvin Cheung wrote:

> For the regular CDS case (UseAppCDS=0), only boot classes are loaded
> from the archive. Therefore, we should not invalidate the archive when
> the bootclasspath is appended.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8174101
>
> webrev: http://cr.openjdk.java.net/~ccheung/8174101/webrev.00/
>
> Testing: hs-tier1 and hs-tier2 on linux-x64, solaris-sparc, macosx,
> windows-x64.
>
> thanks,
> Calvin

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(XS): 8174101: Bootclasspath append should not invalidate CDS archive

Jiangli Zhou
In reply to this post by Calvin Cheung
Hi Calvin,

The fix looks ok to me. Could you please add a comment/note above the line130 change:

“In the future we should perform the check based on the content of the mapped archive.”

Thanks,
Jiangli

> On Nov 30, 2017, at 9:49 AM, Calvin Cheung <[hidden email]> wrote:
>
> For the regular CDS case (UseAppCDS=0), only boot classes are loaded from the archive. Therefore, we should not invalidate the archive when the bootclasspath is appended.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8174101
>
> webrev: http://cr.openjdk.java.net/~ccheung/8174101/webrev.00/
>
> Testing: hs-tier1 and hs-tier2 on linux-x64, solaris-sparc, macosx, windows-x64.
>
> thanks,
> Calvin

Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(XS): 8174101: Bootclasspath append should not invalidate CDS archive

Calvin Cheung
In reply to this post by Ioi Lam
Thanks, Ioi.

Calvin

On 11/30/17, 10:28 AM, Ioi Lam wrote:

> Hi Calvin,
>
> Looks good. Thanks for fixing this.
>
> - Ioi
>
>
> On 11/30/17 9:49 AM, Calvin Cheung wrote:
>> For the regular CDS case (UseAppCDS=0), only boot classes are loaded
>> from the archive. Therefore, we should not invalidate the archive
>> when the bootclasspath is appended.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8174101
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8174101/webrev.00/
>>
>> Testing: hs-tier1 and hs-tier2 on linux-x64, solaris-sparc, macosx,
>> windows-x64.
>>
>> thanks,
>> Calvin
>
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(XS): 8174101: Bootclasspath append should not invalidate CDS archive

Calvin Cheung
In reply to this post by Jiangli Zhou
Thanks, Jiangli.
I'll add the comment before push.

Calvin

On 11/30/17, 10:40 AM, Jiangli Zhou wrote:

> Hi Calvin,
>
> The fix looks ok to me. Could you please add a comment/note above the line130 change:
>
> “In the future we should perform the check based on the content of the mapped archive.”
>
> Thanks,
> Jiangli
>
>> On Nov 30, 2017, at 9:49 AM, Calvin Cheung<[hidden email]>  wrote:
>>
>> For the regular CDS case (UseAppCDS=0), only boot classes are loaded from the archive. Therefore, we should not invalidate the archive when the bootclasspath is appended.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8174101
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8174101/webrev.00/
>>
>> Testing: hs-tier1 and hs-tier2 on linux-x64, solaris-sparc, macosx, windows-x64.
>>
>> thanks,
>> Calvin
Reply | Threaded
Open this post in threaded view
|

Re: [10] RFR(XS): 8174101: Bootclasspath append should not invalidate CDS archive

Jiangli Zhou
Thanks!

Jiangli

> On Nov 30, 2017, at 11:35 AM, Calvin Cheung <[hidden email]> wrote:
>
> Thanks, Jiangli.
> I'll add the comment before push.
>
> Calvin
>
> On 11/30/17, 10:40 AM, Jiangli Zhou wrote:
>> Hi Calvin,
>>
>> The fix looks ok to me. Could you please add a comment/note above the line130 change:
>>
>> “In the future we should perform the check based on the content of the mapped archive.”
>>
>> Thanks,
>> Jiangli
>>
>>> On Nov 30, 2017, at 9:49 AM, Calvin Cheung<[hidden email]>  wrote:
>>>
>>> For the regular CDS case (UseAppCDS=0), only boot classes are loaded from the archive. Therefore, we should not invalidate the archive when the bootclasspath is appended.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8174101
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8174101/webrev.00/
>>>
>>> Testing: hs-tier1 and hs-tier2 on linux-x64, solaris-sparc, macosx, windows-x64.
>>>
>>> thanks,
>>> Calvin