[10] RFR(XS): 8176441: assert(false) failed: modified node was not processed by IGVN.transform_old()

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[10] RFR(XS): 8176441: assert(false) failed: modified node was not processed by IGVN.transform_old()

Tobias Hartmann-2
Hi,

please review the following patch:
https://bugs.openjdk.java.net/browse/JDK-8176441
http://cr.openjdk.java.net/~thartmann/8176441/webrev.00/

The shiftNode needs to be added to the IGVN worklist after being modified. This was introduced by [1].

Tested with replay compilation and RBT (running).

Thanks,
Tobias

[1] https://bugs.openjdk.java.net/browse/JDK-8173470
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10] RFR(XS): 8176441: assert(false) failed: modified node was not processed by IGVN.transform_old()

Vladimir Ivanov
Looks good.

Best regards,
Vladimir Ivanov

On 3/9/17 4:56 PM, Tobias Hartmann wrote:

> Hi,
>
> please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8176441
> http://cr.openjdk.java.net/~thartmann/8176441/webrev.00/
>
> The shiftNode needs to be added to the IGVN worklist after being modified. This was introduced by [1].
>
> Tested with replay compilation and RBT (running).
>
> Thanks,
> Tobias
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8173470
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10] RFR(XS): 8176441: assert(false) failed: modified node was not processed by IGVN.transform_old()

Tobias Hartmann-2
Thanks, Vladimir!

Best regards,
Tobias

On 09.03.2017 16:08, Vladimir Ivanov wrote:

> Looks good.
>
> Best regards,
> Vladimir Ivanov
>
> On 3/9/17 4:56 PM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8176441
>> http://cr.openjdk.java.net/~thartmann/8176441/webrev.00/
>>
>> The shiftNode needs to be added to the IGVN worklist after being modified. This was introduced by [1].
>>
>> Tested with replay compilation and RBT (running).
>>
>> Thanks,
>> Tobias
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8173470
>>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10] RFR(XS): 8176441: assert(false) failed: modified node was not processed by IGVN.transform_old()

Vladimir Kozlov
In reply to this post by Vladimir Ivanov
+1

Vladimir K

On 3/9/17 7:08 AM, Vladimir Ivanov wrote:

> Looks good.
>
> Best regards,
> Vladimir Ivanov
>
> On 3/9/17 4:56 PM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8176441
>> http://cr.openjdk.java.net/~thartmann/8176441/webrev.00/
>>
>> The shiftNode needs to be added to the IGVN worklist after being modified. This was introduced by [1].
>>
>> Tested with replay compilation and RBT (running).
>>
>> Thanks,
>> Tobias
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8173470
>>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [10] RFR(XS): 8176441: assert(false) failed: modified node was not processed by IGVN.transform_old()

Tobias Hartmann-2
Thanks, Vladimir!

Best regards,
Tobias

On 09.03.2017 18:37, Vladimir Kozlov wrote:

> +1
>
> Vladimir K
>
> On 3/9/17 7:08 AM, Vladimir Ivanov wrote:
>> Looks good.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 3/9/17 4:56 PM, Tobias Hartmann wrote:
>>> Hi,
>>>
>>> please review the following patch:
>>> https://bugs.openjdk.java.net/browse/JDK-8176441
>>> http://cr.openjdk.java.net/~thartmann/8176441/webrev.00/
>>>
>>> The shiftNode needs to be added to the IGVN worklist after being modified. This was introduced by [1].
>>>
>>> Tested with replay compilation and RBT (running).
>>>
>>> Thanks,
>>> Tobias
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8173470
>>>
Loading...