[10] Review Request: 8184219 Fix accessibility of tables in the java.desktop module

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[10] Review Request: 8184219 Fix accessibility of tables in the java.desktop module

Sergey Bylokhov
Hello,
Please review the fix for jdk10.

This is the first step to cleanup these warnings:
http://cr.openjdk.java.net/~jjg/doc-report/jdk-by-module/java.desktop/report.html

Bug: https://bugs.openjdk.java.net/browse/JDK-8184219
Webrev can be found at: http://cr.openjdk.java.net/~serb/8184219/webrev.00
Specdiff:http://cr.openjdk.java.net/~serb/8184219/specdiff.00/java.desktop-summary.html

In this fix most of the "striped" tables in the javadoc of java.desktop
module are updated:
  - New attribute scope="col/"row" was added to all headers.
  - Optional tags like </td>, </tr> were removed.
  - Most of custom table styles like "style=text-align:center" were
removed, so all tables now unified.
  - In a few places the "&quot;" was replaced by ", because " is widely
used in our docs anyway.

Some unchanged tables will be updated later(html files inside doc-files
folder, and some tables which are used for layout).

More information about a reason for these changes is in the review
request for java.base module:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-July/048519.html

--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8184219 Fix accessibility of tables in the java.desktop module

Sergey Bylokhov
FYI.
The fix was updated based on offline comments from Jonathan Gibbons(he
approved the fix).
http://cr.openjdk.java.net/~serb/8184219/webrev.02


On 02/09/2017 17:58, Sergey Bylokhov wrote:

> Hello,
> Please review the fix for jdk10.
>
> This is the first step to cleanup these warnings:
> http://cr.openjdk.java.net/~jjg/doc-report/jdk-by-module/java.desktop/report.html 
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8184219
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8184219/webrev.00
> Specdiff:http://cr.openjdk.java.net/~serb/8184219/specdiff.00/java.desktop-summary.html 
>
>
> In this fix most of the "striped" tables in the javadoc of java.desktop
> module are updated:
>   - New attribute scope="col/"row" was added to all headers.
>   - Optional tags like </td>, </tr> were removed.
>   - Most of custom table styles like "style=text-align:center" were
> removed, so all tables now unified.
>   - In a few places the "&quot;" was replaced by ", because " is widely
> used in our docs anyway.
>
> Some unchanged tables will be updated later(html files inside doc-files
> folder, and some tables which are used for layout).
>
> More information about a reason for these changes is in the review
> request for java.base module:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-July/048519.html
>


--
Best regards, Sergey.