[10] Review request for 8190228: Remove redundant modifiers in java.desktop module

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[10] Review request for 8190228: Remove redundant modifiers in java.desktop module

Semyon Sadetsky

Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8190228

webrev: http://cr.openjdk.java.net/~ssadetsky/8190228/webrev.00/

The fix cleanups Java2D, Swing and AWT code to remove the redundant code like:

SomeClass *extends Object*

private *final* ...someMethod()

--Semyon

Reply | Threaded
Open this post in threaded view
|

Re: [10] Review request for 8190228: Remove redundant modifiers in java.desktop module

Phil Race
These all seem fine although I don't think you need bother including the jules files in this change.
In a separate webrev I just sent out I remove all the jules files.

-phil.

On 11/7/17, 9:26 AM, Semyon Sadetsky wrote:

Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8190228

webrev: http://cr.openjdk.java.net/~ssadetsky/8190228/webrev.00/

The fix cleanups Java2D, Swing and AWT code to remove the redundant code like:

SomeClass *extends Object*

private *final* ...someMethod()

--Semyon