[11] 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[11] 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap

dean.long
http://cr.openjdk.java.net/~dlong/8181855/webrev/
https://bugs.openjdk.java.net/browse/JDK-8181855

This change adds "reserved stack" support to Graal for SPARC, x64, and AArch64.
This change has already gone upstream into Graal, except for the AOT change in aotCodeHeap.cpp.

dl
Reply | Threaded
Open this post in threaded view
|

Re: [11] 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap

Vladimir Kozlov
Looks good.

Vladimir

On 7/11/18 3:33 PM, [hidden email] wrote:
> http://cr.openjdk.java.net/~dlong/8181855/webrev/
> https://bugs.openjdk.java.net/browse/JDK-8181855
>
> This change adds "reserved stack" support to Graal for SPARC, x64, and AArch64.
> This change has already gone upstream into Graal, except for the AOT change in aotCodeHeap.cpp.
>
> dl*
> *
Reply | Threaded
Open this post in threaded view
|

Re: [11] 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap

dean.long
Thanks Tom.  I'll retest with that patch.

dl

On 7/12/18 10:28 AM, Tom Rodriguez wrote:

>
>
> [hidden email] wrote on 7/12/18 10:07 AM:
>> Unfortunately, when compiler/graalunit/HotspotTest.java runs my test
>> in JDK, org.graalvm.compiler.test.SubprocessUtil thinks the
>> command-line is empty, causing a failure.  Vladimir or Katya, is
>> there anything special I need to do to run Graal unit tests in JDK?
>
> The tests that use SubprocessUtil in the JDK don't work so they are
> disabled in ProblemList-graal.txt.  Here's my edit to that file from
> the Graal update I was preparing.  It's also restores the regular
> ReservedStackTestCompiler test.
>
> diff -r e0028bb6dd3d test/hotspot/jtreg/ProblemList-graal.txt
> --- a/test/hotspot/jtreg/ProblemList-graal.txt
> +++ b/test/hotspot/jtreg/ProblemList-graal.txt
> @@ -67,8 +67,6 @@
>
>  gc/TestNUMAPageSize.java 8194949   generic-all
>
> -runtime/ReservedStack/ReservedStackTestCompiler.java 8181855  
> generic-all
> -
>  serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java
> 8195156   generic-all
>
>  compiler/compilercontrol/directives/LogTest.java 8181753 generic-all
> @@ -174,6 +172,7 @@
>  org.graalvm.compiler.hotspot.test.CompilationWrapperTest          
> 8205081
>  org.graalvm.compiler.hotspot.test.HsErrLogTest           8205081
>  org.graalvm.compiler.hotspot.test.OptionsInFileTest 8205081
> +org.graalvm.compiler.hotspot.test.ReservedStackAccessTest         
> 8205081
>
> org.graalvm.compiler.replacements.test.classfile.ClassfileBytecodeProviderTest
>   8205081
>  org.graalvm.compiler.replacements.test.classfile.RedefineIntrinsicTest
>           8205081
>
>
>>
>> dl
>>
>> On 7/11/18 4:20 PM, Vladimir Kozlov wrote:
>>> Looks good.
>>>
>>> Vladimir
>>>
>>> On 7/11/18 3:33 PM, [hidden email] wrote:
>>>> http://cr.openjdk.java.net/~dlong/8181855/webrev/
>>>> https://bugs.openjdk.java.net/browse/JDK-8181855
>>>>
>>>> This change adds "reserved stack" support to Graal for SPARC, x64,
>>>> and AArch64.
>>>> This change has already gone upstream into Graal, except for the
>>>> AOT change in aotCodeHeap.cpp.
>>>>
>>>> dl*
>>>> *
>>

Reply | Threaded
Open this post in threaded view
|

Re: [11] 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap

dean.long
New webrev:

http://cr.openjdk.java.net/~dlong/8181855/webrev.2/

The only change is to test/hotspot/jtreg/ProblemList-graal.txt

The only test failure was an existing bug (JDK-8206241).

dl

On 7/12/18 10:46 AM, [hidden email] wrote:

> Thanks Tom.  I'll retest with that patch.
>
> dl
>
> On 7/12/18 10:28 AM, Tom Rodriguez wrote:
>>
>>
>> [hidden email] wrote on 7/12/18 10:07 AM:
>>> Unfortunately, when compiler/graalunit/HotspotTest.java runs my test
>>> in JDK, org.graalvm.compiler.test.SubprocessUtil thinks the
>>> command-line is empty, causing a failure.  Vladimir or Katya, is
>>> there anything special I need to do to run Graal unit tests in JDK?
>>
>> The tests that use SubprocessUtil in the JDK don't work so they are
>> disabled in ProblemList-graal.txt.  Here's my edit to that file from
>> the Graal update I was preparing.  It's also restores the regular
>> ReservedStackTestCompiler test.
>>
>> diff -r e0028bb6dd3d test/hotspot/jtreg/ProblemList-graal.txt
>> --- a/test/hotspot/jtreg/ProblemList-graal.txt
>> +++ b/test/hotspot/jtreg/ProblemList-graal.txt
>> @@ -67,8 +67,6 @@
>>
>>  gc/TestNUMAPageSize.java 8194949   generic-all
>>
>> -runtime/ReservedStack/ReservedStackTestCompiler.java 8181855
>> generic-all
>> -
>>  serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java
>> 8195156   generic-all
>>
>>  compiler/compilercontrol/directives/LogTest.java 8181753 generic-all
>> @@ -174,6 +172,7 @@
>>  org.graalvm.compiler.hotspot.test.CompilationWrapperTest          
>> 8205081
>>  org.graalvm.compiler.hotspot.test.HsErrLogTest 8205081
>>  org.graalvm.compiler.hotspot.test.OptionsInFileTest 8205081
>> +org.graalvm.compiler.hotspot.test.ReservedStackAccessTest         
>> 8205081
>>
>> org.graalvm.compiler.replacements.test.classfile.ClassfileBytecodeProviderTest
>>   8205081
>>  org.graalvm.compiler.replacements.test.classfile.RedefineIntrinsicTest
>>           8205081
>>
>>
>>>
>>> dl
>>>
>>> On 7/11/18 4:20 PM, Vladimir Kozlov wrote:
>>>> Looks good.
>>>>
>>>> Vladimir
>>>>
>>>> On 7/11/18 3:33 PM, [hidden email] wrote:
>>>>> http://cr.openjdk.java.net/~dlong/8181855/webrev/
>>>>> https://bugs.openjdk.java.net/browse/JDK-8181855
>>>>>
>>>>> This change adds "reserved stack" support to Graal for SPARC, x64,
>>>>> and AArch64.
>>>>> This change has already gone upstream into Graal, except for the
>>>>> AOT change in aotCodeHeap.cpp.
>>>>>
>>>>> dl*
>>>>> *
>>>
>

Reply | Threaded
Open this post in threaded view
|

Re: [11] 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap

Vladimir Kozlov
Good.

Thanks,
Vladimir

On 7/12/18 2:15 PM, [hidden email] wrote:

> New webrev:
>
> http://cr.openjdk.java.net/~dlong/8181855/webrev.2/
>
> The only change is to test/hotspot/jtreg/ProblemList-graal.txt
>
> The only test failure was an existing bug (JDK-8206241).
>
> dl
>
> On 7/12/18 10:46 AM, [hidden email] wrote:
>> Thanks Tom.  I'll retest with that patch.
>>
>> dl
>>
>> On 7/12/18 10:28 AM, Tom Rodriguez wrote:
>>>
>>>
>>> [hidden email] wrote on 7/12/18 10:07 AM:
>>>> Unfortunately, when compiler/graalunit/HotspotTest.java runs my test in JDK,
>>>> org.graalvm.compiler.test.SubprocessUtil thinks the command-line is empty, causing a failure.  
>>>> Vladimir or Katya, is there anything special I need to do to run Graal unit tests in JDK?
>>>
>>> The tests that use SubprocessUtil in the JDK don't work so they are disabled in
>>> ProblemList-graal.txt.  Here's my edit to that file from the Graal update I was preparing.  It's
>>> also restores the regular ReservedStackTestCompiler test.
>>>
>>> diff -r e0028bb6dd3d test/hotspot/jtreg/ProblemList-graal.txt
>>> --- a/test/hotspot/jtreg/ProblemList-graal.txt
>>> +++ b/test/hotspot/jtreg/ProblemList-graal.txt
>>> @@ -67,8 +67,6 @@
>>>
>>>  gc/TestNUMAPageSize.java 8194949   generic-all
>>>
>>> -runtime/ReservedStack/ReservedStackTestCompiler.java 8181855 generic-all
>>> -
>>>  serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java 8195156   generic-all
>>>
>>>  compiler/compilercontrol/directives/LogTest.java 8181753 generic-all
>>> @@ -174,6 +172,7 @@
>>>  org.graalvm.compiler.hotspot.test.CompilationWrapperTest 8205081
>>>  org.graalvm.compiler.hotspot.test.HsErrLogTest 8205081
>>>  org.graalvm.compiler.hotspot.test.OptionsInFileTest 8205081
>>> +org.graalvm.compiler.hotspot.test.ReservedStackAccessTest 8205081
>>>
>>> org.graalvm.compiler.replacements.test.classfile.ClassfileBytecodeProviderTest   8205081
>>>  org.graalvm.compiler.replacements.test.classfile.RedefineIntrinsicTest           8205081
>>>
>>>
>>>>
>>>> dl
>>>>
>>>> On 7/11/18 4:20 PM, Vladimir Kozlov wrote:
>>>>> Looks good.
>>>>>
>>>>> Vladimir
>>>>>
>>>>> On 7/11/18 3:33 PM, [hidden email] wrote:
>>>>>> http://cr.openjdk.java.net/~dlong/8181855/webrev/
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8181855
>>>>>>
>>>>>> This change adds "reserved stack" support to Graal for SPARC, x64, and AArch64.
>>>>>> This change has already gone upstream into Graal, except for the AOT change in aotCodeHeap.cpp.
>>>>>>
>>>>>> dl*
>>>>>> *
>>>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [11] 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap

dean.long
Thanks Vladimir.

dl

On 7/12/18 2:30 PM, Vladimir Kozlov wrote:

> Good.
>
> Thanks,
> Vladimir
>
> On 7/12/18 2:15 PM, [hidden email] wrote:
>> New webrev:
>>
>> http://cr.openjdk.java.net/~dlong/8181855/webrev.2/
>>
>> The only change is to test/hotspot/jtreg/ProblemList-graal.txt
>>
>> The only test failure was an existing bug (JDK-8206241).
>>
>> dl
>>
>> On 7/12/18 10:46 AM, [hidden email] wrote:
>>> Thanks Tom.  I'll retest with that patch.
>>>
>>> dl
>>>
>>> On 7/12/18 10:28 AM, Tom Rodriguez wrote:
>>>>
>>>>
>>>> [hidden email] wrote on 7/12/18 10:07 AM:
>>>>> Unfortunately, when compiler/graalunit/HotspotTest.java runs my
>>>>> test in JDK, org.graalvm.compiler.test.SubprocessUtil thinks the
>>>>> command-line is empty, causing a failure.  Vladimir or Katya, is
>>>>> there anything special I need to do to run Graal unit tests in JDK?
>>>>
>>>> The tests that use SubprocessUtil in the JDK don't work so they are
>>>> disabled in ProblemList-graal.txt.  Here's my edit to that file
>>>> from the Graal update I was preparing.  It's also restores the
>>>> regular ReservedStackTestCompiler test.
>>>>
>>>> diff -r e0028bb6dd3d test/hotspot/jtreg/ProblemList-graal.txt
>>>> --- a/test/hotspot/jtreg/ProblemList-graal.txt
>>>> +++ b/test/hotspot/jtreg/ProblemList-graal.txt
>>>> @@ -67,8 +67,6 @@
>>>>
>>>>  gc/TestNUMAPageSize.java 8194949   generic-all
>>>>
>>>> -runtime/ReservedStack/ReservedStackTestCompiler.java 8181855
>>>> generic-all
>>>> -
>>>>  serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java
>>>> 8195156   generic-all
>>>>
>>>>  compiler/compilercontrol/directives/LogTest.java 8181753 generic-all
>>>> @@ -174,6 +172,7 @@
>>>>  org.graalvm.compiler.hotspot.test.CompilationWrapperTest 8205081
>>>>  org.graalvm.compiler.hotspot.test.HsErrLogTest 8205081
>>>>  org.graalvm.compiler.hotspot.test.OptionsInFileTest 8205081
>>>> +org.graalvm.compiler.hotspot.test.ReservedStackAccessTest 8205081
>>>>
>>>> org.graalvm.compiler.replacements.test.classfile.ClassfileBytecodeProviderTest
>>>>   8205081
>>>>  org.graalvm.compiler.replacements.test.classfile.RedefineIntrinsicTest
>>>>           8205081
>>>>
>>>>
>>>>>
>>>>> dl
>>>>>
>>>>> On 7/11/18 4:20 PM, Vladimir Kozlov wrote:
>>>>>> Looks good.
>>>>>>
>>>>>> Vladimir
>>>>>>
>>>>>> On 7/11/18 3:33 PM, [hidden email] wrote:
>>>>>>> http://cr.openjdk.java.net/~dlong/8181855/webrev/
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8181855
>>>>>>>
>>>>>>> This change adds "reserved stack" support to Graal for SPARC,
>>>>>>> x64, and AArch64.
>>>>>>> This change has already gone upstream into Graal, except for the
>>>>>>> AOT change in aotCodeHeap.cpp.
>>>>>>>
>>>>>>> dl*
>>>>>>> *
>>>>>
>>>
>>