(11) RFR (S) JDK-8197864: VS2017 (C4334) Result of 32-bit Shift Implicitly Converted to 64 bits

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

(11) RFR (S) JDK-8197864: VS2017 (C4334) Result of 32-bit Shift Implicitly Converted to 64 bits

Lois Foltan
Please review this fix to properly perform a 64-bit shift when setting
SlowSignatureHandler::_fp_identifiers within _WIN64 conditional code. 
Since the compiler determined that the constant could fit into an int
and the type of SlowSignatureHandler::_num_args is of unsigned int as
well, a 32-bit shift would result yielding a VS2017 compilation warning.

open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8197864/webrev/
bug link https://bugs.openjdk.java.net/browse/JDK-8197864
contributed-by: Kim Barrett & Lois Foltan

Testing: hs-tier(1-3), jdk-tier(1-3) complete

Thanks,
Lois


Reply | Threaded
Open this post in threaded view
|

Re: (11) RFR (S) JDK-8197864: VS2017 (C4334) Result of 32-bit Shift Implicitly Converted to 64 bits

Harold Seigel
Hi Lois,

This looks good!

Thanks, Harold


On 2/22/2018 1:55 PM, Lois Foltan wrote:

> Please review this fix to properly perform a 64-bit shift when setting
> SlowSignatureHandler::_fp_identifiers within _WIN64 conditional code. 
> Since the compiler determined that the constant could fit into an int
> and the type of SlowSignatureHandler::_num_args is of unsigned int as
> well, a 32-bit shift would result yielding a VS2017 compilation warning.
>
> open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8197864/webrev/
> bug link https://bugs.openjdk.java.net/browse/JDK-8197864
> contributed-by: Kim Barrett & Lois Foltan
>
> Testing: hs-tier(1-3), jdk-tier(1-3) complete
>
> Thanks,
> Lois
>
>

Reply | Threaded
Open this post in threaded view
|

Re: (11) RFR (S) JDK-8197864: VS2017 (C4334) Result of 32-bit Shift Implicitly Converted to 64 bits

George Triantafillou
In reply to this post by Lois Foltan
Hi Lois,

Looks good!

-George

On 2/22/2018 1:55 PM, Lois Foltan wrote:

> Please review this fix to properly perform a 64-bit shift when setting
> SlowSignatureHandler::_fp_identifiers within _WIN64 conditional code. 
> Since the compiler determined that the constant could fit into an int
> and the type of SlowSignatureHandler::_num_args is of unsigned int as
> well, a 32-bit shift would result yielding a VS2017 compilation warning.
>
> open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8197864/webrev/
> bug link https://bugs.openjdk.java.net/browse/JDK-8197864
> contributed-by: Kim Barrett & Lois Foltan
>
> Testing: hs-tier(1-3), jdk-tier(1-3) complete
>
> Thanks,
> Lois
>
>

Reply | Threaded
Open this post in threaded view
|

Re: (11) RFR (S) JDK-8197864: VS2017 (C4334) Result of 32-bit Shift Implicitly Converted to 64 bits

Lois Foltan
In reply to this post by Harold Seigel
Thanks Harold.
Lois

On 2/22/2018 3:18 PM, harold seigel wrote:

> Hi Lois,
>
> This looks good!
>
> Thanks, Harold
>
>
> On 2/22/2018 1:55 PM, Lois Foltan wrote:
>> Please review this fix to properly perform a 64-bit shift when
>> setting SlowSignatureHandler::_fp_identifiers within _WIN64
>> conditional code.  Since the compiler determined that the constant
>> could fit into an int and the type of SlowSignatureHandler::_num_args
>> is of unsigned int as well, a 32-bit shift would result yielding a
>> VS2017 compilation warning.
>>
>> open webrev at
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8197864/webrev/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8197864
>> contributed-by: Kim Barrett & Lois Foltan
>>
>> Testing: hs-tier(1-3), jdk-tier(1-3) complete
>>
>> Thanks,
>> Lois
>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: (11) RFR (S) JDK-8197864: VS2017 (C4334) Result of 32-bit Shift Implicitly Converted to 64 bits

Lois Foltan
In reply to this post by George Triantafillou
Thanks George.
Lois

On 2/22/2018 4:36 PM, George Triantafillou wrote:

> Hi Lois,
>
> Looks good!
>
> -George
>
> On 2/22/2018 1:55 PM, Lois Foltan wrote:
>> Please review this fix to properly perform a 64-bit shift when
>> setting SlowSignatureHandler::_fp_identifiers within _WIN64
>> conditional code.  Since the compiler determined that the constant
>> could fit into an int and the type of SlowSignatureHandler::_num_args
>> is of unsigned int as well, a 32-bit shift would result yielding a
>> VS2017 compilation warning.
>>
>> open webrev at
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8197864/webrev/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8197864
>> contributed-by: Kim Barrett & Lois Foltan
>>
>> Testing: hs-tier(1-3), jdk-tier(1-3) complete
>>
>> Thanks,
>> Lois
>>
>>
>