(13) RFR (S): 8226603: accessibility issues in specs/jvmti.html

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

(13) RFR (S): 8226603: accessibility issues in specs/jvmti.html

serguei.spitsyn@oracle.com
Please, review a fix for:
   https://bugs.openjdk.java.net/browse/JDK-8226603

Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226603-jvmti-a11y.1/


Summary:
   The change fixes the a11y issues reported by the Axe tool.


Testing:
   Alex checked that the Axe tool reports noting with the updated
jvmti.html.
   Also, the DocCheck reported the following heading errors for the
original jvmti.html:

% grep heading report0/accessibility.log
0/jvmti.html:30: headings omitted
0/jvmti.html:27: Note: This is the previous heading
0/jvmti.html:880: headings omitted
0/jvmti.html:879: Note: This is the previous heading
0/jvmti.html:5308: headings omitted
0/jvmti.html:5253: Note: This is the previous heading
0/jvmti.html:7700: headings omitted
0/jvmti.html:7607: Note: This is the previous heading
0/jvmti.html:19857: headings omitted
0/jvmti.html:19797: Note: This is the previous heading
0/jvmti.html:23821: headings omitted
0/jvmti.html:23593: Note: This is the previous heading
0/jvmti.html:24546: headings omitted
0/jvmti.html:24416: Note: This is the previous heading
0/jvmti.html:25404: headings omitted
0/jvmti.html:25362: Note: This is the previous heading
0/jvmti.html:30724: headings omitted
0/jvmti.html:30723: Note: This is the previous heading

Now all these errors are gone.

Thanks,
Serguei

Reply | Threaded
Open this post in threaded view
|

Re: (13) RFR (S): 8226603: accessibility issues in specs/jvmti.html

David Holmes
Hi Serguei,

Looks good and trivial.

Thanks,
David

On 28/06/2019 9:55 pm, [hidden email] wrote:

> Please, review a fix for:
>    https://bugs.openjdk.java.net/browse/JDK-8226603
>
> Webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226603-jvmti-a11y.1/
>
>
> Summary:
>    The change fixes the a11y issues reported by the Axe tool.
>
>
> Testing:
>    Alex checked that the Axe tool reports noting with the updated
> jvmti.html.
>    Also, the DocCheck reported the following heading errors for the
> original jvmti.html:
>
> % grep heading report0/accessibility.log
> 0/jvmti.html:30: headings omitted
> 0/jvmti.html:27: Note: This is the previous heading
> 0/jvmti.html:880: headings omitted
> 0/jvmti.html:879: Note: This is the previous heading
> 0/jvmti.html:5308: headings omitted
> 0/jvmti.html:5253: Note: This is the previous heading
> 0/jvmti.html:7700: headings omitted
> 0/jvmti.html:7607: Note: This is the previous heading
> 0/jvmti.html:19857: headings omitted
> 0/jvmti.html:19797: Note: This is the previous heading
> 0/jvmti.html:23821: headings omitted
> 0/jvmti.html:23593: Note: This is the previous heading
> 0/jvmti.html:24546: headings omitted
> 0/jvmti.html:24416: Note: This is the previous heading
> 0/jvmti.html:25404: headings omitted
> 0/jvmti.html:25362: Note: This is the previous heading
> 0/jvmti.html:30724: headings omitted
> 0/jvmti.html:30723: Note: This is the previous heading
>
> Now all these errors are gone.
>
> Thanks,
> Serguei
>
Reply | Threaded
Open this post in threaded view
|

Re: (13) RFR (S): 8226603: accessibility issues in specs/jvmti.html

serguei.spitsyn@oracle.com
Thanks a lot, David!
Serguei


On 6/28/19 21:44, David Holmes wrote:

> Hi Serguei,
>
> Looks good and trivial.
>
> Thanks,
> David
>
> On 28/06/2019 9:55 pm, [hidden email] wrote:
>> Please, review a fix for:
>>    https://bugs.openjdk.java.net/browse/JDK-8226603
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226603-jvmti-a11y.1/
>>
>>
>> Summary:
>>    The change fixes the a11y issues reported by the Axe tool.
>>
>>
>> Testing:
>>    Alex checked that the Axe tool reports noting with the updated
>> jvmti.html.
>>    Also, the DocCheck reported the following heading errors for the
>> original jvmti.html:
>>
>> % grep heading report0/accessibility.log
>> 0/jvmti.html:30: headings omitted
>> 0/jvmti.html:27: Note: This is the previous heading
>> 0/jvmti.html:880: headings omitted
>> 0/jvmti.html:879: Note: This is the previous heading
>> 0/jvmti.html:5308: headings omitted
>> 0/jvmti.html:5253: Note: This is the previous heading
>> 0/jvmti.html:7700: headings omitted
>> 0/jvmti.html:7607: Note: This is the previous heading
>> 0/jvmti.html:19857: headings omitted
>> 0/jvmti.html:19797: Note: This is the previous heading
>> 0/jvmti.html:23821: headings omitted
>> 0/jvmti.html:23593: Note: This is the previous heading
>> 0/jvmti.html:24546: headings omitted
>> 0/jvmti.html:24416: Note: This is the previous heading
>> 0/jvmti.html:25404: headings omitted
>> 0/jvmti.html:25362: Note: This is the previous heading
>> 0/jvmti.html:30724: headings omitted
>> 0/jvmti.html:30723: Note: This is the previous heading
>>
>> Now all these errors are gone.
>>
>> Thanks,
>> Serguei
>>

Reply | Threaded
Open this post in threaded view
|

Re: (13) RFR (S): 8226603: accessibility issues in specs/jvmti.html

Alex Menkov-2
In reply to this post by David Holmes
+1

--alex

On 06/28/2019 21:44, David Holmes wrote:

> Hi Serguei,
>
> Looks good and trivial.
>
> Thanks,
> David
>
> On 28/06/2019 9:55 pm, [hidden email] wrote:
>> Please, review a fix for:
>>    https://bugs.openjdk.java.net/browse/JDK-8226603
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226603-jvmti-a11y.1/
>>
>>
>> Summary:
>>    The change fixes the a11y issues reported by the Axe tool.
>>
>>
>> Testing:
>>    Alex checked that the Axe tool reports noting with the updated
>> jvmti.html.
>>    Also, the DocCheck reported the following heading errors for the
>> original jvmti.html:
>>
>> % grep heading report0/accessibility.log
>> 0/jvmti.html:30: headings omitted
>> 0/jvmti.html:27: Note: This is the previous heading
>> 0/jvmti.html:880: headings omitted
>> 0/jvmti.html:879: Note: This is the previous heading
>> 0/jvmti.html:5308: headings omitted
>> 0/jvmti.html:5253: Note: This is the previous heading
>> 0/jvmti.html:7700: headings omitted
>> 0/jvmti.html:7607: Note: This is the previous heading
>> 0/jvmti.html:19857: headings omitted
>> 0/jvmti.html:19797: Note: This is the previous heading
>> 0/jvmti.html:23821: headings omitted
>> 0/jvmti.html:23593: Note: This is the previous heading
>> 0/jvmti.html:24546: headings omitted
>> 0/jvmti.html:24416: Note: This is the previous heading
>> 0/jvmti.html:25404: headings omitted
>> 0/jvmti.html:25362: Note: This is the previous heading
>> 0/jvmti.html:30724: headings omitted
>> 0/jvmti.html:30723: Note: This is the previous heading
>>
>> Now all these errors are gone.
>>
>> Thanks,
>> Serguei
>>
Reply | Threaded
Open this post in threaded view
|

Re: (13) RFR (S): 8226603: accessibility issues in specs/jvmti.html

serguei.spitsyn@oracle.com
Thanks a lot, Alex!
Serguei


On 7/1/19 11:25, Alex Menkov wrote:

> +1
>
> --alex
>
> On 06/28/2019 21:44, David Holmes wrote:
>> Hi Serguei,
>>
>> Looks good and trivial.
>>
>> Thanks,
>> David
>>
>> On 28/06/2019 9:55 pm, [hidden email] wrote:
>>> Please, review a fix for:
>>>    https://bugs.openjdk.java.net/browse/JDK-8226603
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226603-jvmti-a11y.1/
>>>
>>>
>>> Summary:
>>>    The change fixes the a11y issues reported by the Axe tool.
>>>
>>>
>>> Testing:
>>>    Alex checked that the Axe tool reports noting with the updated
>>> jvmti.html.
>>>    Also, the DocCheck reported the following heading errors for the
>>> original jvmti.html:
>>>
>>> % grep heading report0/accessibility.log
>>> 0/jvmti.html:30: headings omitted
>>> 0/jvmti.html:27: Note: This is the previous heading
>>> 0/jvmti.html:880: headings omitted
>>> 0/jvmti.html:879: Note: This is the previous heading
>>> 0/jvmti.html:5308: headings omitted
>>> 0/jvmti.html:5253: Note: This is the previous heading
>>> 0/jvmti.html:7700: headings omitted
>>> 0/jvmti.html:7607: Note: This is the previous heading
>>> 0/jvmti.html:19857: headings omitted
>>> 0/jvmti.html:19797: Note: This is the previous heading
>>> 0/jvmti.html:23821: headings omitted
>>> 0/jvmti.html:23593: Note: This is the previous heading
>>> 0/jvmti.html:24546: headings omitted
>>> 0/jvmti.html:24416: Note: This is the previous heading
>>> 0/jvmti.html:25404: headings omitted
>>> 0/jvmti.html:25362: Note: This is the previous heading
>>> 0/jvmti.html:30724: headings omitted
>>> 0/jvmti.html:30723: Note: This is the previous heading
>>>
>>> Now all these errors are gone.
>>>
>>> Thanks,
>>> Serguei
>>>