Quantcast

8172307(S): Remove ununsed JVM API JVM_GetModuleByPackageName()

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

8172307(S): Remove ununsed JVM API JVM_GetModuleByPackageName()

harold seigel
Hi,

Please review this JDK-10 change to finish removing the implementation
of JVM_GetModuleByPackageName(). JDK-8171855
<https://bugs.openjdk.java.net/browse/JDK-8171855> removed the
JVM_GetModuleByPackageName() API but not its underlying support in the
JVM.  This change removes that support because it is no longer needed.

Open Webrevs:

    http://cr.openjdk.java.net/~hseigel/bug_8172307.hs/webrev/

    http://cr.openjdk.java.net/~hseigel/bug_8172307.test/webrev/

JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172307

The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
tests, the colocated and non-colocated NSK tests, and with JPRT.

Thanks, Harold

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8172307(S): Remove ununsed JVM API JVM_GetModuleByPackageName()

George Triantafillou
Hi Harold,

Your changes look good.

-George

On 2/28/2017 8:58 AM, harold seigel wrote:

> Hi,
>
> Please review this JDK-10 change to finish removing the implementation
> of JVM_GetModuleByPackageName(). JDK-8171855
> <https://bugs.openjdk.java.net/browse/JDK-8171855> removed the
> JVM_GetModuleByPackageName() API but not its underlying support in the
> JVM.  This change removes that support because it is no longer needed.
>
> Open Webrevs:
>
>    http://cr.openjdk.java.net/~hseigel/bug_8172307.hs/webrev/
>
>    http://cr.openjdk.java.net/~hseigel/bug_8172307.test/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172307
>
> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
> tests, the colocated and non-colocated NSK tests, and with JPRT.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8172307(S): Remove ununsed JVM API JVM_GetModuleByPackageName()

harold seigel
Thanks George!

Harold


On 2/28/2017 10:09 AM, George Triantafillou wrote:

> Hi Harold,
>
> Your changes look good.
>
> -George
>
> On 2/28/2017 8:58 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 change to finish removing the
>> implementation of JVM_GetModuleByPackageName(). JDK-8171855
>> <https://bugs.openjdk.java.net/browse/JDK-8171855> removed the
>> JVM_GetModuleByPackageName() API but not its underlying support in
>> the JVM.  This change removes that support because it is no longer
>> needed.
>>
>> Open Webrevs:
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8172307.hs/webrev/
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8172307.test/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172307
>>
>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
>> tests, the colocated and non-colocated NSK tests, and with JPRT.
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8172307(S): Remove ununsed JVM API JVM_GetModuleByPackageName()

serguei.spitsyn@oracle.com
In reply to this post by harold seigel
Hi Harold,

It looks good.

Thanks,
Serguei


On 2/28/17 05:58, harold seigel wrote:

> Hi,
>
> Please review this JDK-10 change to finish removing the implementation
> of JVM_GetModuleByPackageName(). JDK-8171855
> <https://bugs.openjdk.java.net/browse/JDK-8171855> removed the
> JVM_GetModuleByPackageName() API but not its underlying support in the
> JVM.  This change removes that support because it is no longer needed.
>
> Open Webrevs:
>
>    http://cr.openjdk.java.net/~hseigel/bug_8172307.hs/webrev/
>
>    http://cr.openjdk.java.net/~hseigel/bug_8172307.test/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172307
>
> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
> tests, the colocated and non-colocated NSK tests, and with JPRT.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8172307(S): Remove ununsed JVM API JVM_GetModuleByPackageName()

harold seigel
Thanks Serguei!

Harold


On 2/28/2017 12:07 PM, [hidden email] wrote:

> Hi Harold,
>
> It looks good.
>
> Thanks,
> Serguei
>
>
> On 2/28/17 05:58, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 change to finish removing the
>> implementation of JVM_GetModuleByPackageName(). JDK-8171855
>> <https://bugs.openjdk.java.net/browse/JDK-8171855> removed the
>> JVM_GetModuleByPackageName() API but not its underlying support in
>> the JVM.  This change removes that support because it is no longer
>> needed.
>>
>> Open Webrevs:
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8172307.hs/webrev/
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8172307.test/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172307
>>
>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
>> tests, the colocated and non-colocated NSK tests, and with JPRT.
>>
>> Thanks, Harold
>>
>

Loading...