8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

George Triantafillou
Please review this very small JDK-10 enhancement to remove unused
Solaris assembly files:

JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
webrev: http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ 
<http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>

The change was tested by building on Solaris sparcv9/x64.

Thanks.

-George

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

harold seigel
Hi George,

The change looks good.

Harold


On 7/25/2017 1:31 PM, George Triantafillou wrote:

> Please review this very small JDK-10 enhancement to remove unused
> Solaris assembly files:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
> webrev:
> http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ 
> <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>
> The change was tested by building on Solaris sparcv9/x64.
>
> Thanks.
>
> -George
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

Gerald Thornbrugh
In reply to this post by George Triantafillou
Hi George,

Your change looks good.

Jerry

> On Jul 25, 2017, at 11:31 AM, George Triantafillou <[hidden email]> wrote:
>
> Please review this very small JDK-10 enhancement to remove unused Solaris assembly files:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
> webrev: http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>
> The change was tested by building on Solaris sparcv9/x64.
>
> Thanks.
>
> -George
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

Daniel D. Daugherty
In reply to this post by harold seigel
Agreed that the change looks good.

Thumbs up!

Since this changeset is about removal of two files that shouldn't be
used by the build, does this qualify under the HotSpot Trivial Change
rule? I would vote yes...

Dan


On 7/25/17 11:37 AM, harold seigel wrote:

> Hi George,
>
> The change looks good.
>
> Harold
>
>
> On 7/25/2017 1:31 PM, George Triantafillou wrote:
>> Please review this very small JDK-10 enhancement to remove unused
>> Solaris assembly files:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
>> webrev:
>> http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ 
>> <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>>
>> The change was tested by building on Solaris sparcv9/x64.
>>
>> Thanks.
>>
>> -George
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

Vladimir Kozlov
In reply to this post by George Triantafillou
Good.

Vladimir

On 7/25/17 10:31 AM, George Triantafillou wrote:

> Please review this very small JDK-10 enhancement to remove unused Solaris assembly files:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
> webrev: http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>
> The change was tested by building on Solaris sparcv9/x64.
>
> Thanks.
>
> -George
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

George Triantafillou
In reply to this post by harold seigel
Thanks Harold.

-George

On 7/25/2017 1:37 PM, harold seigel wrote:

> Hi George,
>
> The change looks good.
>
> Harold
>
>
> On 7/25/2017 1:31 PM, George Triantafillou wrote:
>> Please review this very small JDK-10 enhancement to remove unused
>> Solaris assembly files:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
>> webrev:
>> http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ 
>> <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>>
>> The change was tested by building on Solaris sparcv9/x64.
>>
>> Thanks.
>>
>> -George
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

George Triantafillou
In reply to this post by Gerald Thornbrugh
Thanks Jerry.

-George

On 7/25/2017 1:39 PM, Gerald Thornbrugh wrote:

> Hi George,
>
> Your change looks good.
>
> Jerry
>
>> On Jul 25, 2017, at 11:31 AM, George Triantafillou <[hidden email]> wrote:
>>
>> Please review this very small JDK-10 enhancement to remove unused Solaris assembly files:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
>> webrev: http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>>
>> The change was tested by building on Solaris sparcv9/x64.
>>
>> Thanks.
>>
>> -George
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

George Triantafillou
In reply to this post by Daniel D. Daugherty
Thanks Dan!

-George

On 7/25/2017 1:40 PM, Daniel D. Daugherty wrote:

> Agreed that the change looks good.
>
> Thumbs up!
>
> Since this changeset is about removal of two files that shouldn't be
> used by the build, does this qualify under the HotSpot Trivial Change
> rule? I would vote yes...
>
> Dan
>
>
> On 7/25/17 11:37 AM, harold seigel wrote:
>> Hi George,
>>
>> The change looks good.
>>
>> Harold
>>
>>
>> On 7/25/2017 1:31 PM, George Triantafillou wrote:
>>> Please review this very small JDK-10 enhancement to remove unused
>>> Solaris assembly files:
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
>>> webrev:
>>> http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ 
>>> <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>>>
>>> The change was tested by building on Solaris sparcv9/x64.
>>>
>>> Thanks.
>>>
>>> -George
>>>
>>
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: 8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

George Triantafillou
In reply to this post by Vladimir Kozlov
Thanks Vladimir.

-George

On 7/25/2017 1:42 PM, Vladimir Kozlov wrote:

> Good.
>
> Vladimir
>
> On 7/25/17 10:31 AM, George Triantafillou wrote:
>> Please review this very small JDK-10 enhancement to remove unused
>> Solaris assembly files:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
>> webrev:
>> http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ 
>> <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>>
>> The change was tested by building on Solaris sparcv9/x64.
>>
>> Thanks.
>>
>> -George
>>

Loading...