8192072(one-liner): 8191782 fix for VMDeprecatedOptions.java missed DeferThrSuspendLoopCount and duplicated DeferPollingPageLoopCount

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

8192072(one-liner): 8191782 fix for VMDeprecatedOptions.java missed DeferThrSuspendLoopCount and duplicated DeferPollingPageLoopCount

Robbin Ehn
Hi all, please review.

Tested VMDeprecatedOptions which still passes.
Issue:
https://bugs.openjdk.java.net/browse/JDK-8192072
Old issue with bad fix:
https://bugs.openjdk.java.net/browse/JDK-8191782

Thanks, Robbin

diff -r bc1cffa26561 test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
--- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 29 09:26:58 2017 +0900
+++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 29 13:15:46 2017 +0100
@@ -51,5 +51,5 @@
          {"DeferPollingPageLoopCount", "-1"},
          {"SafepointSpinBeforeYield",  "2000"},
-        {"DeferPollingPageLoopCount", "4000"},
+        {"DeferThrSuspendLoopCount",  "4000"},

          // deprecated alias flags (see also aliased_jvm_flags):
Reply | Threaded
Open this post in threaded view
|

Re: 8192072(one-liner): 8191782 fix for VMDeprecatedOptions.java missed DeferThrSuspendLoopCount and duplicated DeferPollingPageLoopCount

coleen.phillimore
Looks good, and trivial.
thanks,
Coleen

On 11/29/17 7:19 AM, Robbin Ehn wrote:

> Hi all, please review.
>
> Tested VMDeprecatedOptions which still passes.
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8192072
> Old issue with bad fix:
> https://bugs.openjdk.java.net/browse/JDK-8191782
>
> Thanks, Robbin
>
> diff -r bc1cffa26561
> test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> Wed Nov 29 09:26:58 2017 +0900
> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> Wed Nov 29 13:15:46 2017 +0100
> @@ -51,5 +51,5 @@
>          {"DeferPollingPageLoopCount", "-1"},
>          {"SafepointSpinBeforeYield",  "2000"},
> -        {"DeferPollingPageLoopCount", "4000"},
> +        {"DeferThrSuspendLoopCount",  "4000"},
>
>          // deprecated alias flags (see also aliased_jvm_flags):

Reply | Threaded
Open this post in threaded view
|

Re: 8192072(one-liner): 8191782 fix for VMDeprecatedOptions.java missed DeferThrSuspendLoopCount and duplicated DeferPollingPageLoopCount

Robbin Ehn
Thanks Coleen, Robbin.

On 2017-11-29 13:24, [hidden email] wrote:

> Looks good, and trivial.
> thanks,
> Coleen
>
> On 11/29/17 7:19 AM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Tested VMDeprecatedOptions which still passes.
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8192072
>> Old issue with bad fix:
>> https://bugs.openjdk.java.net/browse/JDK-8191782
>>
>> Thanks, Robbin
>>
>> diff -r bc1cffa26561 test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
>> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 29 09:26:58 2017 +0900
>> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 29 13:15:46 2017 +0100
>> @@ -51,5 +51,5 @@
>>          {"DeferPollingPageLoopCount", "-1"},
>>          {"SafepointSpinBeforeYield",  "2000"},
>> -        {"DeferPollingPageLoopCount", "4000"},
>> +        {"DeferThrSuspendLoopCount",  "4000"},
>>
>>          // deprecated alias flags (see also aliased_jvm_flags):
>