8214761: Bug in parallel Kahan summation implementation

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

8214761: Bug in parallel Kahan summation implementation

Chris Dennis
I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 - but have been stuck waiting on OCA signatory status to be confirmed. Did something get lost in the shuffle or do I just need to be more patient.

Thanks,

Chris
Reply | Threaded
Open this post in threaded view
|

Re: 8214761: Bug in parallel Kahan summation implementation

Chris Dennis
A gentle prod. Am I misunderstanding procedure here?

From: Chris Dennis <[hidden email]>
Date: Monday, March 22, 2021 at 2:28 PM
To: core-libs-dev <[hidden email]>
Subject: 8214761: Bug in parallel Kahan summation implementation
I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 - but have been stuck waiting on OCA signatory status to be confirmed. Did something get lost in the shuffle or do I just need to be more patient.

Thanks,

Chris
Reply | Threaded
Open this post in threaded view
|

Re: 8214761: Bug in parallel Kahan summation implementation

Pavel Rappo
Hey Chris,

I don't know exactly what triggers removal of the "oca" and "oca-verify" labels. The only OCA entry for Chris Dennis I could find [1] had a different GitHub username. Did you mistype it or it belongs to another person? Mind you, that person's GitHub page is 404.

-Pavel

[1] https://oca.opensource.oracle.com/?ojr=contrib-list

> On 3 Apr 2021, at 16:12, Chris Dennis <[hidden email]> wrote:
>
> A gentle prod. Am I misunderstanding procedure here?
>
> From: Chris Dennis <[hidden email]>
> Date: Monday, March 22, 2021 at 2:28 PM
> To: core-libs-dev <[hidden email]>
> Subject: 8214761: Bug in parallel Kahan summation implementation
> I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 - but have been stuck waiting on OCA signatory status to be confirmed. Did something get lost in the shuffle or do I just need to be more patient.
>
> Thanks,
>
> Chris

Reply | Threaded
Open this post in threaded view
|

Re: 8214761: Bug in parallel Kahan summation implementation

Chris Dennis
I’m pretty certain that is meant to be me but ‘chris_dennis’ is a now defunct java.net username and not a Github one. The username appears in this list https://oca.opensource.oracle.com/?ojr=old-contrib-list#t too as: “Terracotta Inc. (Christopher Dennis), OpenJDK, chris_dennis”. My Github username is tied to the previous commits I’ve authored though: https://github.com/openjdk/jdk/commits?author=chrisdennis. I also believe there should be a signed OCA for my current employer “Software AG” too since I’ve contributed under it to both OpenJDK and JSR-107.

Chris


From: Pavel Rappo <[hidden email]>
Date: Saturday, April 3, 2021 at 2:35 PM
To: Chris Dennis <[hidden email]>
Cc: core-libs-dev <[hidden email]>
Subject: Re: 8214761: Bug in parallel Kahan summation implementation
Hey Chris,

I don't know exactly what triggers removal of the "oca" and "oca-verify" labels. The only OCA entry for Chris Dennis I could find [1] had a different GitHub username. Did you mistype it or it belongs to another person? Mind you, that person's GitHub page is 404.

-Pavel

[1] https://oca.opensource.oracle.com/?ojr=contrib-list

> On 3 Apr 2021, at 16:12, Chris Dennis <[hidden email]> wrote:
>
> A gentle prod. Am I misunderstanding procedure here?
>
> From: Chris Dennis <[hidden email]>
> Date: Monday, March 22, 2021 at 2:28 PM
> To: core-libs-dev <[hidden email]>
> Subject: 8214761: Bug in parallel Kahan summation implementation
> I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 - but have been stuck waiting on OCA signatory status to be confirmed. Did something get lost in the shuffle or do I just need to be more patient.
>
> Thanks,
>
> Chris
Reply | Threaded
Open this post in threaded view
|

Re: 8214761: Bug in parallel Kahan summation implementation

Anirvan Sarkar
In reply to this post by Pavel Rappo
Hi Pavel,

I think I have the same issue as Chris.

The new OCA contributors list [1] is incorrectly linking the user names to
GitHub as compared to the old contributors list [2].
It seems the new OCA contributors list is assuming that the GitHub username
of past contributors is the same as the username of the project, when they
had signed the OCA in the past.

When I had signed OCA a few years back for the OpenJFX project, I had
provided my username as *anirvan.sarkar*.
This was my username on java.net / javafx-jira.kenai.com (the old JIRA for
JavaFX project).
But my GitHub username is *AnirvanSarkar*, not *anirvan.sarkar* which user
does not exist on GitHub.

[1] : https://oca.opensource.oracle.com/?ojr=contrib-list
[2] : https://oca.opensource.oracle.com/?ojr=old-contrib-list


On Sun, 4 Apr 2021 at 03:35, Pavel Rappo <[hidden email]> wrote:

> Hey Chris,
>
> I don't know exactly what triggers removal of the "oca" and "oca-verify"
> labels. The only OCA entry for Chris Dennis I could find [1] had a
> different GitHub username. Did you mistype it or it belongs to another
> person? Mind you, that person's GitHub page is 404.
>
> -Pavel
>
> [1] https://oca.opensource.oracle.com/?ojr=contrib-list
>
> > On 3 Apr 2021, at 16:12, Chris Dennis <[hidden email]> wrote:
> >
> > A gentle prod. Am I misunderstanding procedure here?
> >
> > From: Chris Dennis <[hidden email]>
> > Date: Monday, March 22, 2021 at 2:28 PM
> > To: core-libs-dev <[hidden email]>
> > Subject: 8214761: Bug in parallel Kahan summation implementation
> > I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 -
> but have been stuck waiting on OCA signatory status to be confirmed. Did
> something get lost in the shuffle or do I just need to be more patient.
> >
> > Thanks,
> >
> > Chris
>
>

--
Anirvan
Reply | Threaded
Open this post in threaded view
|

Re: 8214761: Bug in parallel Kahan summation implementation

dalibor topic-2
Hi Anirvan,

You can contact contact Oracle’s open-source administrators at
[hidden email], who run the OCA app.

We don't use the github usernames from the OCA app for OpenJDK pull
requests, so you should not be running into issues with that for
contributions to OpenJDK. If you do, please let me know off-list which
pull request is involved.

cheers,
dalibor topic

On 03.04.2021 22:11, Anirvan Sarkar wrote:

> Hi Pavel,
>
> I think I have the same issue as Chris.
>
> The new OCA contributors list [1] is incorrectly linking the user names to
> GitHub as compared to the old contributors list [2].
> It seems the new OCA contributors list is assuming that the GitHub username
> of past contributors is the same as the username of the project, when they
> had signed the OCA in the past.
>
> When I had signed OCA a few years back for the OpenJFX project, I had
> provided my username as *anirvan.sarkar*.
> This was my username on java.net / javafx-jira.kenai.com (the old JIRA for
> JavaFX project).
> But my GitHub username is *AnirvanSarkar*, not *anirvan.sarkar* which user
> does not exist on GitHub.
>
> [1] : https://oca.opensource.oracle.com/?ojr=contrib-list
> [2] : https://oca.opensource.oracle.com/?ojr=old-contrib-list
>
>
> On Sun, 4 Apr 2021 at 03:35, Pavel Rappo <[hidden email]> wrote:
>
>> Hey Chris,
>>
>> I don't know exactly what triggers removal of the "oca" and "oca-verify"
>> labels. The only OCA entry for Chris Dennis I could find [1] had a
>> different GitHub username. Did you mistype it or it belongs to another
>> person? Mind you, that person's GitHub page is 404.
>>
>> -Pavel
>>
>> [1] https://oca.opensource.oracle.com/?ojr=contrib-list
>>
>>> On 3 Apr 2021, at 16:12, Chris Dennis <[hidden email]> wrote:
>>>
>>> A gentle prod. Am I misunderstanding procedure here?
>>>
>>> From: Chris Dennis <[hidden email]>
>>> Date: Monday, March 22, 2021 at 2:28 PM
>>> To: core-libs-dev <[hidden email]>
>>> Subject: 8214761: Bug in parallel Kahan summation implementation
>>> I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 -
>> but have been stuck waiting on OCA signatory status to be confirmed. Did
>> something get lost in the shuffle or do I just need to be more patient.
>>>
>>> Thanks,
>>>
>>> Chris
>>
>>
>

--
<http://www.oracle.com> Dalibor Topic
Consulting Product Manager
Phone: +494089091214 <tel:+494089091214>, Mobile: +491737185961
<tel:+491737185961>, Video: [hidden email]
<sip:[hidden email]>

Oracle Global Services Germany GmbH
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRB 246209
Geschäftsführer: Ralf Herrmann