[8u] RFR: 8170578: CUPS Printing is broken with Ubuntu 16.10 (CUPS 2.2)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[8u] RFR: 8170578: CUPS Printing is broken with Ubuntu 16.10 (CUPS 2.2)

prasanta sadhukhan
Hi All,

This is a backport review request to jdk8u for an issue fixed in jdk9
for CUPS printing issue in ubuntu16.10
(mail-thread:
http://mail.openjdk.java.net/pipermail/2d-dev/2017-January/008174.html)

While backporting, it is found that the build fails citing

error: incompatible types: Object cannot be converted to Entry<String,AttributeClass>
                                 for (Map.Entry<String, AttributeClass> entry : responseMap[i].entrySet()) {
so the fix is slightly modified to store the "entrySet" to a Set and iterating on that Set.

webrev: http://cr.openjdk.java.net/~psadhukhan/8170578/8udev/webrev.00/

With this modification, the build succeeds and test passed.

Regards
Prasanta


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [8u] RFR: 8170578: CUPS Printing is broken with Ubuntu 16.10 (CUPS 2.2)

Philip Race
Looks fine. Please send email to 8u-dev asking for approval to push.

-phil.

On 2/2/17, 9:38 PM, Prasanta Sadhukhan wrote:

> Hi All,
>
> This is a backport review request to jdk8u for an issue fixed in jdk9
> for CUPS printing issue in ubuntu16.10
> (mail-thread:
> http://mail.openjdk.java.net/pipermail/2d-dev/2017-January/008174.html)
>
> While backporting, it is found that the build fails citing
>
> error: incompatible types: Object cannot be converted to
> Entry<String,AttributeClass>
>                                 for (Map.Entry<String, AttributeClass>
> entry : responseMap[i].entrySet()) {
> so the fix is slightly modified to store the "entrySet" to a Set and
> iterating on that Set.
>
> webrev: http://cr.openjdk.java.net/~psadhukhan/8170578/8udev/webrev.00/
>
> With this modification, the build succeeds and test passed.
>
> Regards
> Prasanta
>
>
Loading...