Quantcast

[8u] RFR 8173373: C1: NPE is thrown instead of LinkageError when accessing inaccessible field on NULL receiver

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[8u] RFR 8173373: C1: NPE is thrown instead of LinkageError when accessing inaccessible field on NULL receiver

vladimir kempik
Hello

Please review this backport of 8173373 for jdk8u.

The fix applied cleanly to jdk8, except one place:

in src/share/vm/c1/c1_LIR.cpp

I had to change

+    CodeStub* deopt = new DeoptimizeStub(info,
Deoptimization::Reason_null_check, Deoptimization::Action_none);

to

+    CodeStub* deopt = new DeoptimizeStub(info);

The fix passes jprt and testcase.

Bug: https://bugs.openjdk.java.net/browse/JDK-8173373
Webrev: http://cr.openjdk.java.net/~vkempik/8173373/webrev.00/

Thanks
-Vladimir

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [8u] RFR 8173373: C1: NPE is thrown instead of LinkageError when accessing inaccessible field on NULL receiver

Vladimir Ivanov
Looks good.

Best regards,
Vladimir Ivanov

On 4/10/17 8:18 PM, Vladimir Kempik wrote:

> Hello
>
> Please review this backport of 8173373 for jdk8u.
>
> The fix applied cleanly to jdk8, except one place:
>
> in src/share/vm/c1/c1_LIR.cpp
>
> I had to change
>
> +    CodeStub* deopt = new DeoptimizeStub(info,
> Deoptimization::Reason_null_check, Deoptimization::Action_none);
>
> to
>
> +    CodeStub* deopt = new DeoptimizeStub(info);
>
> The fix passes jprt and testcase.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8173373
> Webrev: http://cr.openjdk.java.net/~vkempik/8173373/webrev.00/
>
> Thanks
> -Vladimir
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [8u] RFR 8173373: C1: NPE is thrown instead of LinkageError when accessing inaccessible field on NULL receiver

Tobias Hartmann-2
In reply to this post by vladimir kempik
Hi Vladimir,

looks good to me, thanks for taking care of the backport!

Best regards,
Tobias

On 10.04.2017 19:18, Vladimir Kempik wrote:

> Hello
>
> Please review this backport of 8173373 for jdk8u.
>
> The fix applied cleanly to jdk8, except one place:
>
> in src/share/vm/c1/c1_LIR.cpp
>
> I had to change
>
> +    CodeStub* deopt = new DeoptimizeStub(info, Deoptimization::Reason_null_check, Deoptimization::Action_none);
>
> to
>
> +    CodeStub* deopt = new DeoptimizeStub(info);
>
> The fix passes jprt and testcase.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8173373
> Webrev: http://cr.openjdk.java.net/~vkempik/8173373/webrev.00/
>
> Thanks
> -Vladimir
>
Loading...