[8u] RFR for backport of JDK-8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[8u] RFR for backport of JDK-8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394

Shafi Ahmad
Hi,

Please review the backport of 'JDK- 8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394' to jdk8u.
Please note that this is not a clean backport because the code change in jdk8u is under if-block 'if ( loc != NULL ) {'  whereas in jdk9 this if-block is not there.    

Webrev: http://cr.openjdk.java.net/~shshahma/8180855/webrev.00/
Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8180855
Original patch pushed to jdk9: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/1ae9e84f68b3

Test:  Run jprt.

Regards,
Shafi
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: [8u] RFR for backport of JDK-8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394

Shafi Ahmad
May I get the review of this backport.

Regards,
Shafi

> -----Original Message-----
> From: Shafi Ahmad
> Sent: Monday, July 24, 2017 5:00 PM
> To: [hidden email]
> Cc: Vladimir Kozlov <[hidden email]>
> Subject: [8u] RFR for backport of JDK-8180855: Null pointer dereference in
> OopMapSet::all_do of oopMap.cpp:394
>
> Hi,
>
> Please review the backport of 'JDK- 8180855: Null pointer dereference in
> OopMapSet::all_do of oopMap.cpp:394' to jdk8u.
> Please note that this is not a clean backport because the code change in
> jdk8u is under if-block 'if ( loc != NULL ) {'  whereas in jdk9 this if-block is not
> there.
>
> Webrev: http://cr.openjdk.java.net/~shshahma/8180855/webrev.00/
> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8180855
> Original patch pushed to jdk9:
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/1ae9e84f68b3
>
> Test:  Run jprt.
>
> Regards,
> Shafi
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [8u] RFR for backport of JDK-8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394

Vladimir Kozlov
In reply to this post by Shafi Ahmad
Looks good.

Thanks,
Vladimir

On 7/24/17 4:29 AM, Shafi Ahmad wrote:

> Hi,
>
> Please review the backport of 'JDK- 8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394' to jdk8u.
> Please note that this is not a clean backport because the code change in jdk8u is under if-block 'if ( loc != NULL ) {'  whereas in jdk9 this if-block is not there.
>
> Webrev: http://cr.openjdk.java.net/~shshahma/8180855/webrev.00/
> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8180855
> Original patch pushed to jdk9: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/1ae9e84f68b3
>
> Test:  Run jprt.
>
> Regards,
> Shafi
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: [8u] RFR for backport of JDK-8180855: Null pointer dereference in OopMapSet::all_do of oopMap.cpp:394

Shafi Ahmad
Thank you Vladimir for reviewing it.

Regards,
Shafi

> -----Original Message-----
> From: Vladimir Kozlov
> Sent: Wednesday, July 26, 2017 9:29 AM
> To: Shafi Ahmad <[hidden email]>; hotspot-compiler-
> [hidden email]
> Subject: Re: [8u] RFR for backport of JDK-8180855: Null pointer dereference
> in OopMapSet::all_do of oopMap.cpp:394
>
> Looks good.
>
> Thanks,
> Vladimir
>
> On 7/24/17 4:29 AM, Shafi Ahmad wrote:
> > Hi,
> >
> > Please review the backport of 'JDK- 8180855: Null pointer dereference in
> OopMapSet::all_do of oopMap.cpp:394' to jdk8u.
> > Please note that this is not a clean backport because the code change in
> jdk8u is under if-block 'if ( loc != NULL ) {'  whereas in jdk9 this if-block is not
> there.
> >
> > Webrev: http://cr.openjdk.java.net/~shshahma/8180855/webrev.00/
> > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8180855
> > Original patch pushed to jdk9:
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/1ae9e84f68b3
> >
> > Test:  Run jprt.
> >
> > Regards,
> > Shafi
> >
Loading...