[8u-dev] Request to Review and for Approval to Backport 8192987 : keytool should remember real storetype if it is not provided

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[8u-dev] Request to Review and for Approval to Backport 8192987 : keytool should remember real storetype if it is not provided

Ivan Gerasimov
Hello!

I'd like to backport this fix to JDK 8u-dev.

The patch did NOT apply cleanly, thus a Review request.

Patched JDK builds fine on all platforms, the tests pass well.

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8192987
WEBREV: http://cr.openjdk.java.net/~igerasim/8192987/00/webrev/
JDK 10 Change: http://hg.openjdk.java.net/jdk/jdk/rev/e3b6cb90d7ce
JDK 10 Review:
http://mail.openjdk.java.net/pipermail/security-dev/2017-December/016613.html

Thanks in advance!

--
With kind regards,
Ivan Gerasimov

Reply | Threaded
Open this post in threaded view
|

Re: [8u-dev] Request to Review and for Approval to Backport 8192987 : keytool should remember real storetype if it is not provided

Wang Weijun
The code change looks fine to me.

Thanks
Max

> On Jan 3, 2018, at 9:16 AM, Ivan Gerasimov <[hidden email]> wrote:
>
> Hello!
>
> I'd like to backport this fix to JDK 8u-dev.
>
> The patch did NOT apply cleanly, thus a Review request.
>
> Patched JDK builds fine on all platforms, the tests pass well.
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8192987
> WEBREV: http://cr.openjdk.java.net/~igerasim/8192987/00/webrev/
> JDK 10 Change: http://hg.openjdk.java.net/jdk/jdk/rev/e3b6cb90d7ce
> JDK 10 Review: http://mail.openjdk.java.net/pipermail/security-dev/2017-December/016613.html
>
> Thanks in advance!
>
> --
> With kind regards,
> Ivan Gerasimov
>

Reply | Threaded
Open this post in threaded view
|

Re: [8u-dev] Request to Review and for Approval to Backport 8192987 : keytool should remember real storetype if it is not provided

Seán Coffey
Looks fine. Approved for jdk8u-dev.

regards,
Sean.


On 03/01/2018 02:44, Weijun Wang wrote:

> The code change looks fine to me.
>
> Thanks
> Max
>
>> On Jan 3, 2018, at 9:16 AM, Ivan Gerasimov <[hidden email]> wrote:
>>
>> Hello!
>>
>> I'd like to backport this fix to JDK 8u-dev.
>>
>> The patch did NOT apply cleanly, thus a Review request.
>>
>> Patched JDK builds fine on all platforms, the tests pass well.
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8192987
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8192987/00/webrev/
>> JDK 10 Change: http://hg.openjdk.java.net/jdk/jdk/rev/e3b6cb90d7ce
>> JDK 10 Review: http://mail.openjdk.java.net/pipermail/security-dev/2017-December/016613.html
>>
>> Thanks in advance!
>>
>> --
>> With kind regards,
>> Ivan Gerasimov
>>