[8u] request for approval: 8174164 & 8175097: SafePointNode::_replaced_nodes breaks with irreducible loops

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[8u] request for approval: 8174164 & 8175097: SafePointNode::_replaced_nodes breaks with irreducible loops

Roland Westrelin-3

Hi,

I'd like to backport 8174164 (and its test case 8175097) to 8u as it's
an issue reported by one of our (Red Hat) customers. The patch doesn't
apply cleanly: the part of library_call.cpp fails to apply but given
library_call.cpp in 8u doesn't need to be changed for that fix, that
part of the patch can simply be removed. So I assume no re-review is
necessary. It was pushed to jdk9 1 week ago and hasn't caused any follow
up bugs that I know of.

https://bugs.openjdk.java.net/browse/JDK-8174164
http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/35db0413819a
https://bugs.openjdk.java.net/browse/JDK-8175097
http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/8241f87c4712

8u webrev:

http://cr.openjdk.java.net/~roland/8174164.8u/webrev.00/

Roland.
Reply | Threaded
Open this post in threaded view
|

Re: [8u] request for approval: 8174164 & 8175097: SafePointNode::_replaced_nodes breaks with irreducible loops

Vladimir Kozlov
8u changes looks good.

Thanks,
Vladimir

On 2/24/17 6:17 AM, Roland Westrelin wrote:

>
> Hi,
>
> I'd like to backport 8174164 (and its test case 8175097) to 8u as it's
> an issue reported by one of our (Red Hat) customers. The patch doesn't
> apply cleanly: the part of library_call.cpp fails to apply but given
> library_call.cpp in 8u doesn't need to be changed for that fix, that
> part of the patch can simply be removed. So I assume no re-review is
> necessary. It was pushed to jdk9 1 week ago and hasn't caused any follow
> up bugs that I know of.
>
> https://bugs.openjdk.java.net/browse/JDK-8174164
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/35db0413819a
> https://bugs.openjdk.java.net/browse/JDK-8175097
> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/8241f87c4712
>
> 8u webrev:
>
> http://cr.openjdk.java.net/~roland/8174164.8u/webrev.00/
>
> Roland.
>
Reply | Threaded
Open this post in threaded view
|

Re: [8u] request for approval: 8174164 & 8175097: SafePointNode::_replaced_nodes breaks with irreducible loops

Roland Westrelin-3

> 8u changes looks good.

Thanks Vladimir. Can I get approval from the jdk 8u gatekeepers for this
and a sponsor?

Thanks,
Roland.
Reply | Threaded
Open this post in threaded view
|

Re: [8u] request for approval: 8174164 & 8175097: SafePointNode::_replaced_nodes breaks with irreducible loops

Rob McKenna
Approved, please work with the hotspot team to find a sponsor.

    -Rob

On 02/03/17 05:35, Roland Westrelin wrote:
>
> > 8u changes looks good.
>
> Thanks Vladimir. Can I get approval from the jdk 8u gatekeepers for this
> and a sponsor?
>
> Thanks,
> Roland.
Reply | Threaded
Open this post in threaded view
|

Re: [8u] request for approval: 8174164 & 8175097: SafePointNode::_replaced_nodes breaks with irreducible loops

Tobias Hartmann-2
In reply to this post by Roland Westrelin-3
Hi Roland,

On 02.03.2017 17:35, Roland Westrelin wrote:
>
>> 8u changes looks good.
>
> Thanks Vladimir. Can I get approval from the jdk 8u gatekeepers for this
> and a sponsor?

I can do the sponsoring, please send me the 8u changeset.

Best regards,
Tobias