Quantcast

[9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Vladimir Kozlov
https://bugs.openjdk.java.net/browse/JDK-8174879

jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal
module and not to export any API.

Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.

Webrevs:

top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/

Tested with RBT.

Thanks,
Vladimir
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Mandy Chung

> On Feb 15, 2017, at 5:37 PM, Vladimir Kozlov <[hidden email]> wrote:
>
> https://bugs.openjdk.java.net/browse/JDK-8174879
>
> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.
>
> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.
>
> Webrevs:
>
> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/

The change looks fine to me.

Mandy

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Vladimir Kozlov
Thank you, Mandy

Vladimir

On 2/15/17 8:35 PM, Mandy Chung wrote:

>
>> On Feb 15, 2017, at 5:37 PM, Vladimir Kozlov <[hidden email]> wrote:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8174879
>>
>> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.
>>
>> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
>> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.
>>
>> Webrevs:
>>
>> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
>> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
>> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/
>
> The change looks fine to me.
>
> Mandy
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Magnus Ihse Bursie
In reply to this post by Vladimir Kozlov
On 2017-02-16 02:37, Vladimir Kozlov wrote:
https://bugs.openjdk.java.net/browse/JDK-8174879

jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.

Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.

Webrevs:

top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/

Looks good to me.

/Magnus

Tested with RBT.

Thanks,
Vladimir

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Doug Simon @ Oracle
Just to note here, this means an external version of Graal will now have to use --add-exports VM options to access JVMCI. Which is ok since additional VM options are required anyway to put an external Graal on the module path.

-Doug

> On 16 Feb 2017, at 08:54, Magnus Ihse Bursie <[hidden email]> wrote:
>
> On 2017-02-16 02:37, Vladimir Kozlov wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8174879 
>>
>> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.
>>
>> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
>> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.
>>
>> Webrevs:
>>
>> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/ 
>> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/ 
>> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/ 
>
> Looks good to me.
>
> /Magnus
>>
>> Tested with RBT.
>>
>> Thanks,
>> Vladimir
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Vladimir Kozlov
In reply to this post by Magnus Ihse Bursie
Thank you, Magnus

Vladimir

On 2/15/17 11:54 PM, Magnus Ihse Bursie wrote:

> On 2017-02-16 02:37, Vladimir Kozlov wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8174879
>>
>> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and
>> researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.
>>
>> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
>> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.
>>
>> Webrevs:
>>
>> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
>> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
>> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/
>
> Looks good to me.
>
> /Magnus
>>
>> Tested with RBT.
>>
>> Thanks,
>> Vladimir
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Vladimir Kozlov
In reply to this post by Doug Simon @ Oracle
Hi Doug,

Is it because of next change?:

    module jdk.internal.vm.ci {
-      exports jdk.vm.ci.services;
+      exports jdk.vm.ci.services to jdk.internal.vm.compiler;

But you said before that your version of graal has the same module name. Why you need --add-exports?

Thanks,
Vladimir

On 2/16/17 2:01 AM, Doug Simon wrote:

> Just to note here, this means an external version of Graal will now have to use --add-exports VM options to access JVMCI. Which is ok since additional VM options are required anyway to put an external Graal on the module path.
>
> -Doug
>
>> On 16 Feb 2017, at 08:54, Magnus Ihse Bursie <[hidden email]> wrote:
>>
>> On 2017-02-16 02:37, Vladimir Kozlov wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8174879
>>>
>>> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.
>>>
>>> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
>>> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.
>>>
>>> Webrevs:
>>>
>>> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
>>> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
>>> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/
>>
>> Looks good to me.
>>
>> /Magnus
>>>
>>> Tested with RBT.
>>>
>>> Thanks,
>>> Vladimir
>>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

Doug Simon @ Oracle

> On 16 Feb 2017, at 19:30, Vladimir Kozlov <[hidden email]> wrote:
>
> Hi Doug,
>
> Is it because of next change?:
>
>   module jdk.internal.vm.ci {
> -      exports jdk.vm.ci.services;
> +      exports jdk.vm.ci.services to jdk.internal.vm.compiler;
>
> But you said before that your version of graal has the same module name. Why you need --add-exports?

I am projecting ahead to the bug fix Mandy talks about in http://mail.openjdk.java.net/pipermail/graal-dev/2017-February/004889.html which means patching in an external version of Graal will no longer benefit from the qualified exports of JVMCI to jdk.vm.compiler.

-Doug

> On 2/16/17 2:01 AM, Doug Simon wrote:
>> Just to note here, this means an external version of Graal will now have to use --add-exports VM options to access JVMCI. Which is ok since additional VM options are required anyway to put an external Graal on the module path.
>>
>> -Doug
>>
>>> On 16 Feb 2017, at 08:54, Magnus Ihse Bursie <[hidden email]> wrote:
>>>
>>> On 2017-02-16 02:37, Vladimir Kozlov wrote:
>>>> https://bugs.openjdk.java.net/browse/JDK-8174879
>>>>
>>>> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.
>>>>
>>>> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
>>>> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.
>>>>
>>>> Webrevs:
>>>>
>>>> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
>>>> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
>>>> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/
>>>
>>> Looks good to me.
>>>
>>> /Magnus
>>>>
>>>> Tested with RBT.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>
>>

Loading...