[9] RFR (S): 8174721: C1: Inlining through MH invokers/linkers in unreachable code is unsafe

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[9] RFR (S): 8174721: C1: Inlining through MH invokers/linkers in unreachable code is unsafe

Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8174721/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8174721

8166110 didn't touch C1, but newly added regression test provoked
similar failure there.

Add signature checks between linker & target methods to ensure inlining
doesn't happen for evidently broken cases.

Testing: regression test, JPRT, RBT

Thanks!

Best regards,
Vladimir Ivanov
Reply | Threaded
Open this post in threaded view
|

Re: [9] RFR (S): 8174721: C1: Inlining through MH invokers/linkers in unreachable code is unsafe

Igor Veresov
Looks good to me.

igor

> On Feb 10, 2017, at 8:37 AM, Vladimir Ivanov <[hidden email]> wrote:
>
> http://cr.openjdk.java.net/~vlivanov/8174721/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8174721
>
> 8166110 didn't touch C1, but newly added regression test provoked similar failure there.
>
> Add signature checks between linker & target methods to ensure inlining doesn't happen for evidently broken cases.
>
> Testing: regression test, JPRT, RBT
>
> Thanks!
>
> Best regards,
> Vladimir Ivanov

Reply | Threaded
Open this post in threaded view
|

Re: [9] RFR (S): 8174721: C1: Inlining through MH invokers/linkers in unreachable code is unsafe

Vladimir Ivanov
Thanks, Igor.

Best regards,
Vladimir Ivanov

On 2/10/17 8:00 PM, Igor Veresov wrote:

> Looks good to me.
>
> igor
>
>> On Feb 10, 2017, at 8:37 AM, Vladimir Ivanov <[hidden email]> wrote:
>>
>> http://cr.openjdk.java.net/~vlivanov/8174721/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8174721
>>
>> 8166110 didn't touch C1, but newly added regression test provoked similar failure there.
>>
>> Add signature checks between linker & target methods to ensure inlining doesn't happen for evidently broken cases.
>>
>> Testing: regression test, JPRT, RBT
>>
>> Thanks!
>>
>> Best regards,
>> Vladimir Ivanov
>