[9] RFR(S) 8175052: [AOT] jaotc does not accept file name with .class

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[9] RFR(S) 8175052: [AOT] jaotc does not accept file name with .class

Vladimir Kozlov
https://bugs.openjdk.java.net/browse/JDK-8175052

http://cr.openjdk.java.net/~kvn/8175052/webrev/

After 8169588 change jaotc stop accepting file.class names. Add back such ability.
Print stack trace for "not found" error only with --info flag.
Also changed error message to be less confusing. Instead of:

Error: Failed to find: unknown:my.class
Error: Failed to find: classname:my.class

output:
Error: Failed to find file: my.class

when --class-name flag is used:
Error: Failed to find class file: my.class

Thanks,
Vladimir
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR(S) 8175052: [AOT] jaotc does not accept file name with .class

Igor Veresov
Looks good.

igor

> On Feb 17, 2017, at 2:01 PM, Vladimir Kozlov <[hidden email]> wrote:
>
> https://bugs.openjdk.java.net/browse/JDK-8175052
>
> http://cr.openjdk.java.net/~kvn/8175052/webrev/
>
> After 8169588 change jaotc stop accepting file.class names. Add back such ability.
> Print stack trace for "not found" error only with --info flag.
> Also changed error message to be less confusing. Instead of:
>
> Error: Failed to find: unknown:my.class
> Error: Failed to find: classname:my.class
>
> output:
> Error: Failed to find file: my.class
>
> when --class-name flag is used:
> Error: Failed to find class file: my.class
>
> Thanks,
> Vladimir

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR(S) 8175052: [AOT] jaotc does not accept file name with .class

Vladimir Kozlov
Thank you, Igor

Vladimir

On 2/17/17 8:36 PM, Igor Veresov wrote:

> Looks good.
>
> igor
>
>> On Feb 17, 2017, at 2:01 PM, Vladimir Kozlov <[hidden email]> wrote:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8175052
>>
>> http://cr.openjdk.java.net/~kvn/8175052/webrev/
>>
>> After 8169588 change jaotc stop accepting file.class names. Add back such ability.
>> Print stack trace for "not found" error only with --info flag.
>> Also changed error message to be less confusing. Instead of:
>>
>> Error: Failed to find: unknown:my.class
>> Error: Failed to find: classname:my.class
>>
>> output:
>> Error: Failed to find file: my.class
>>
>> when --class-name flag is used:
>> Error: Failed to find class file: my.class
>>
>> Thanks,
>> Vladimir
>
Loading...