Quantcast

[9] RFR(XS) 8175516: JNI exception pending in jdk_tools_jaotc_jnilibelf_JNILibELFAPI.c:97

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[9] RFR(XS) 8175516: JNI exception pending in jdk_tools_jaotc_jnilibelf_JNILibELFAPI.c:97

Vladimir Kozlov
http://cr.openjdk.java.net/~kvn/8175516/webrev/

Added missing NULL check after JNI call.

Thanks,
Vladimir
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR(XS) 8175516: JNI exception pending in jdk_tools_jaotc_jnilibelf_JNILibELFAPI.c:97

Igor Veresov
retObj probably needs to be nulled out?

Also there is a whole bunch of return values we don’t check in getNativeAddress() and makePointerObject().

igor

> On Feb 24, 2017, at 9:28 AM, Vladimir Kozlov <[hidden email]> wrote:
>
> http://cr.openjdk.java.net/~kvn/8175516/webrev/
>
> Added missing NULL check after JNI call.
>
> Thanks,
> Vladimir

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR(XS) 8175516: JNI exception pending in jdk_tools_jaotc_jnilibelf_JNILibELFAPI.c:97

Vladimir Kozlov
On 2/26/17 10:29 PM, Igor Veresov wrote:
> retObj probably needs to be nulled out?

Right, I forgot that it is not Java.

>
> Also there is a whole bunch of return values we don’t check in getNativeAddress() and makePointerObject().

Fixed:

http://cr.openjdk.java.net/~kvn/8175516/webrev/

Thanks,
Vladimir

>
> igor
>
>> On Feb 24, 2017, at 9:28 AM, Vladimir Kozlov <[hidden email]> wrote:
>>
>> http://cr.openjdk.java.net/~kvn/8175516/webrev/
>>
>> Added missing NULL check after JNI call.
>>
>> Thanks,
>> Vladimir
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR(XS) 8175516: JNI exception pending in jdk_tools_jaotc_jnilibelf_JNILibELFAPI.c:97

Igor Veresov
Looks good.

igor

> On Feb 27, 2017, at 12:51 PM, Vladimir Kozlov <[hidden email]> wrote:
>
> On 2/26/17 10:29 PM, Igor Veresov wrote:
>> retObj probably needs to be nulled out?
>
> Right, I forgot that it is not Java.
>
>>
>> Also there is a whole bunch of return values we don’t check in getNativeAddress() and makePointerObject().
>
> Fixed:
>
> http://cr.openjdk.java.net/~kvn/8175516/webrev/
>
> Thanks,
> Vladimir
>
>>
>> igor
>>
>>> On Feb 24, 2017, at 9:28 AM, Vladimir Kozlov <[hidden email]> wrote:
>>>
>>> http://cr.openjdk.java.net/~kvn/8175516/webrev/
>>>
>>> Added missing NULL check after JNI call.
>>>
>>> Thanks,
>>> Vladimir
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] RFR(XS) 8175516: JNI exception pending in jdk_tools_jaotc_jnilibelf_JNILibELFAPI.c:97

Vladimir Kozlov
Thank you, Igor

Vladimir

On 2/27/17 3:40 PM, Igor Veresov wrote:

> Looks good.
>
> igor
>
>> On Feb 27, 2017, at 12:51 PM, Vladimir Kozlov <[hidden email]> wrote:
>>
>> On 2/26/17 10:29 PM, Igor Veresov wrote:
>>> retObj probably needs to be nulled out?
>>
>> Right, I forgot that it is not Java.
>>
>>>
>>> Also there is a whole bunch of return values we don’t check in getNativeAddress() and makePointerObject().
>>
>> Fixed:
>>
>> http://cr.openjdk.java.net/~kvn/8175516/webrev/
>>
>> Thanks,
>> Vladimir
>>
>>>
>>> igor
>>>
>>>> On Feb 24, 2017, at 9:28 AM, Vladimir Kozlov <[hidden email]> wrote:
>>>>
>>>> http://cr.openjdk.java.net/~kvn/8175516/webrev/
>>>>
>>>> Added missing NULL check after JNI call.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>
>
Loading...