[9] Review Request: 8177461 Wrong references are used in the javadoc in the java.desktop module

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[9] Review Request: 8177461 Wrong references are used in the javadoc in the java.desktop module

Sergey Bylokhov
Hello,
Please review the fix for jdk9.

In java.desktop module in a various places we use incorrect links.
Most of them are in the documentation in non-public classes/methods(But there are two places in public API - specdiff is provided)

Common issues:
 - The method is referenced without #
 - The method which have some parameters is referenced as «#method()» instead of «#method» or «#method(ParameterDescription)"
 - The type which is referenced is not imported
 - The reference to non-existed method/type.
 - Copy pasted javadoc was removed.
 - The type was renamed (like AppReOpenedListener to AppReopenedListener)


Bug: https://bugs.openjdk.java.net/browse/JDK-8177461
Webrev can be found at: http://cr.openjdk.java.net/~serb/8177461/webrev.00
Specdiff: http://cr.openjdk.java.net/~serb/8177461/specdiff/overview-summary.html
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [9] Review Request: 8177461 Wrong references are used in the javadoc in the java.desktop module

Alexandr Scherbatiy
The fix looks good to me.

Thanks,
Alexandr.

On 23/03/17 18:24, Sergey Bylokhov wrote:

> Hello,
> Please review the fix for jdk9.
>
> In java.desktop module in a various places we use incorrect links.
> Most of them are in the documentation in non-public classes/methods(But there are two places in public API - specdiff is provided)
>
> Common issues:
>   - The method is referenced without #
>   - The method which have some parameters is referenced as «#method()» instead of «#method» or «#method(ParameterDescription)"
>   - The type which is referenced is not imported
>   - The reference to non-existed method/type.
>   - Copy pasted javadoc was removed.
>   - The type was renamed (like AppReOpenedListener to AppReopenedListener)
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8177461
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8177461/webrev.00
> Specdiff: http://cr.openjdk.java.net/~serb/8177461/specdiff/overview-summary.html

Loading...