Quantcast

[Bug 3318] New: [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] New: [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
Bug ID 3318
Summary [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering
Product IcedTea
Version 7-hg
Hardware all
OS All
Status NEW
Severity normal
Priority P5
Component IcedTea
Assignee gnu.andrew@redhat.com
Reporter gnu.andrew@redhat.com
CC unassigned@icedtea.classpath.org

Clone of bug 3271 for IcedTea 2.x.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
[hidden email] changed bug 3318
What Removed Added
Status NEW ASSIGNED
Target Milestone --- 2.6.9


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 1 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/icedtea7?cmd=changeset;node=e1c68cfd0b30
author: Andrew John Hughes <[hidden email]>
date: Mon Feb 06 09:48:33 2017 +0000

    Bump to icedtea-2.7.0pre09.

    Upstream changes:
      - Bump to icedtea-2.7.0pre09
      - PR3209: Backed out changeset 3cc3ab869ccf
      - PR3211: AArch64 build fails with pre-compiled headers disabled
      - PR3318: Always round glyph advance in 26.6 space
      - PR3318: Fix compatibility with vanilla Fontconfig
      - PR3318: Fix glyph y advance
      - PR3318: Replace 'infinality' with 'improved font rendering'
      - PR3318: Simplify glyph advance handling
      - S7102489, PR3316: RFE: cleanup jlong typedef on __APPLE__and _LLP64
systems.
      - S8000351, PR3316: Tenuring threshold should be unsigned
      - S8153711, PR3313: [REDO] JDWP: Memory Leak: GlobalRefs never deleted
when processing invokeMethod command
      - S8165673: AArch64: Fix JNI floating point argument handling
      - S8170888, PR3316: [linux] Experimental support for cgroup memory limits
in container (ie Docker) environments

    ChangeLog:

    2017-02-05  Andrew John Hughes  <[hidden email]>

        Bump to icedtea-2.7.0pre09.
        * patches/pr3209-backout.patch,
        * patches/pr3211.patch:
        Remove upstreamed patches.
        (CORBA_CHANGESET): Update to icedtea-2.7.0pre09.
        (JAXP_CHANGESET): Likewise.
        (JAXWS_CHANGESET): Likewise.
        (JDK_CHANGESET): Likewise.
        (LANGTOOLS_CHANGESET): Likewise.
        (OPENJDK_CHANGESET): Likewise.
        (CORBA_SHA256SUM): Likewise.
        (JAXP_SHA256SUM): Likewise.
        (JAXWS_SHA256SUM): Likewise.
        (JDK_SHA256SUM): Likewise.
        (LANGTOOLS_SHA256SUM): Likewise.
        (OPENJDK_SHA256SUM): Likewise.
        (ICEDTEA_PATCHES): Remove PR3211 patch
        and PR3209 backout now applied upstream.
        (ICEDTEA_ENV): Update INFINALITY_SUPPORT
        setting to IMPROVED_FONT_RENDERING,
        following PR3318.
        * NEWS: Updated.
        * configure.ac: Bump to 2.7.0pre09.
        * hotspot.map.in: Update to icedtea-2.7.0pre09.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 2 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/icedtea7?cmd=changeset;node=69f98e212dac
author: Andrew John Hughes <[hidden email]>
date: Mon Feb 06 09:57:00 2017 +0000

    PR3318: Replace 'infinality' with 'improved font rendering'
(--enable-improved-font-rendering)

    2017-01-24  Andrew John Hughes  <[hidden email]>

        PR3318: Replace 'infinality' with
        'improved font rendering'
        * INSTALL:
        Rename --enable-infinality to
        --enable-improved-font-rendering, as
        the code no longer relies on the infinality
        patch set.
        * Makefile.am:
        Use ENABLE_IMPROVED_FONT_RENDERING, not
        ENABLE_INFINALITY.
        * acinclude.m4:
        (IT_ENABLE_IMPROVED_FONT_RENDERING): Renamed
        from IT_ENABLE_INFINALITY. Fix variables to match
        and remove unneeded test for infinality patches.
        * configure.ac:
        Invoke IT_ENABLE_IMPROVED_FONT_RENDERING instead
        of IT_ENABLE_INFINALITY.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 3 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/icedtea7-forest/jdk?cmd=changeset;node=52de2c27b131
author: andrew
date: Tue Jan 24 23:02:54 2017 +0000

    PR3318: Fix compatibility with vanilla Fontconfig
    Contributed-by: Matthias Dahl <[hidden email]>

    With vanilla Fontconfig, most text is not rendered.

    The "Infinality"-patched Fontconfig with its own configuration,
    supplies an additional config file that sets the antialias key
    (FC_ANTIALIAS) which is not part of the vanilla Fontconfig and also
    has no default in its source code.

    In the case that FC_ANTIALIAS is not being provided for a given font
    because the font does not contain the appropriate information (which
    is quite common) or a specific config file is missing,
    FcPatternGetBool for the key will return an error and no valid
    result. Thus, ftRenderMode stays uninitialized due to the way its
    initialized in the conditional constructs, eventually causing the text
    rendering anomaly.

    Furthermore, the logic is flawed as well. The specific subpixel
    rendering modes are only properly set if FC_ANTIALIAS is set and true,
    no matter what was requested by the caller (aaType).

    This patch makes the following changes to address those problems:

    1. ftRenderMode is always properly initialized.

    2. FC_ANTIALIAS is only evaluated if antialiasing was requested and only
       used to turn off antialiasing if that is suggested by Fontconfig.

    3. Subpixel rendering modes are properly set according to Fontconfig
       results and only if subpixel rendering was actually requested.

    In order to properly adjust for the "forced off" antialiasing, it is
    necessary to change the signature of readFontconfig and give it full
    access to FTScalerContext, so it can properly set the new aaType.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 5 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/icedtea7-forest/jdk?cmd=changeset;node=412d3eb66e5b
author: andrew
date: Tue Jan 24 23:41:30 2017 +0000

    PR3318: Always round glyph advance in 26.6 space
    Contributed-by: Matthias Dahl <[hidden email]>

    By rounding in the 26.6 space, the glyph advance can be snapped to the
    next 64 boundary by integer arithmetic alone, thus avoiding floating
    arithmetic and improving accuracy.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 7 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/icedtea7-forest/jdk?cmd=changeset;node=e7f45775d9a8
author: andrew
date: Mon Feb 06 04:37:12 2017 +0000

    PR3318: Replace 'infinality' with 'improved font rendering'


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 6 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/icedtea7-forest/jdk?cmd=changeset;node=fbda034f33b2
author: andrew
date: Wed Jan 25 00:24:10 2017 +0000

    PR3318: Simplify glyph advance handling
    Contributed-by: Matthias Dahl <[hidden email]>

    Reduce the branches and always round and convert the advance, no matter
    if its zero or not since it is guaranteed that 0 divided by a floating
    point always equals zero.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 4 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/icedtea7-forest/jdk?cmd=changeset;node=809e541ee8ff
author: andrew
date: Tue Jan 24 23:21:34 2017 +0000

    PR3318: Fix glyph y advance
    Contributed-by: Matthias Dahl <[hidden email]>

    The y advance needs to be negated as the final step, otherwise the
    rounding will naturally be wrong.

    This did show itself for example as shifted into each other glyphs in
    Android Studio for text where a rotation was applied (e.g. scale on
    the ui builder).


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 9 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/release/icedtea7-forest-2.6/jdk?cmd=changeset;node=97fe50561c93
author: andrew
date: Tue Jan 24 23:21:34 2017 +0000

    PR3318: Fix glyph y advance
    Contributed-by: Matthias Dahl <[hidden email]>

    The y advance needs to be negated as the final step, otherwise the
    rounding will naturally be wrong.

    This did show itself for example as shifted into each other glyphs in
    Android Studio for text where a rotation was applied (e.g. scale on
    the ui builder).


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 8 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/release/icedtea7-forest-2.6/jdk?cmd=changeset;node=feb34a6d03ee
author: andrew
date: Tue Jan 24 23:02:54 2017 +0000

    PR3318: Fix compatibility with vanilla Fontconfig
    Contributed-by: Matthias Dahl <[hidden email]>

    With vanilla Fontconfig, most text is not rendered.

    The "Infinality"-patched Fontconfig with its own configuration,
    supplies an additional config file that sets the antialias key
    (FC_ANTIALIAS) which is not part of the vanilla Fontconfig and also
    has no default in its source code.

    In the case that FC_ANTIALIAS is not being provided for a given font
    because the font does not contain the appropriate information (which
    is quite common) or a specific config file is missing,
    FcPatternGetBool for the key will return an error and no valid
    result. Thus, ftRenderMode stays uninitialized due to the way its
    initialized in the conditional constructs, eventually causing the text
    rendering anomaly.

    Furthermore, the logic is flawed as well. The specific subpixel
    rendering modes are only properly set if FC_ANTIALIAS is set and true,
    no matter what was requested by the caller (aaType).

    This patch makes the following changes to address those problems:

    1. ftRenderMode is always properly initialized.

    2. FC_ANTIALIAS is only evaluated if antialiasing was requested and only
       used to turn off antialiasing if that is suggested by Fontconfig.

    3. Subpixel rendering modes are properly set according to Fontconfig
       results and only if subpixel rendering was actually requested.

    In order to properly adjust for the "forced off" antialiasing, it is
    necessary to change the signature of readFontconfig and give it full
    access to FTScalerContext, so it can properly set the new aaType.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 10 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/release/icedtea7-forest-2.6/jdk?cmd=changeset;node=49a475eb9ffd
author: andrew
date: Tue Jan 24 23:41:30 2017 +0000

    PR3318: Always round glyph advance in 26.6 space
    Contributed-by: Matthias Dahl <[hidden email]>

    By rounding in the 26.6 space, the glyph advance can be snapped to the
    next 64 boundary by integer arithmetic alone, thus avoiding floating
    arithmetic and improving accuracy.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 11 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/release/icedtea7-forest-2.6/jdk?cmd=changeset;node=9a7b641574ce
author: andrew
date: Wed Jan 25 00:24:10 2017 +0000

    PR3318: Simplify glyph advance handling
    Contributed-by: Matthias Dahl <[hidden email]>

    Reduce the branches and always round and convert the advance, no matter
    if its zero or not since it is guaranteed that 0 divided by a floating
    point always equals zero.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 12 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/release/icedtea7-forest-2.6/jdk?cmd=changeset;node=f09b408bbec6
author: andrew
date: Mon Feb 06 04:37:12 2017 +0000

    PR3318: Replace 'infinality' with 'improved font rendering'


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 13 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/release/icedtea7-2.6?cmd=changeset;node=364b56695512
author: Andrew John Hughes <[hidden email]>
date: Mon Feb 06 22:53:13 2017 +0000

    Bump to icedtea-2.6.9pre01.

    Upstream changes:
      - Bump to icedtea-2.6.9pre01
      - PR3318: Always round glyph advance in 26.6 space
      - PR3318: Fix compatibility with vanilla Fontconfig
      - PR3318: Fix glyph y advance
      - PR3318: Replace 'infinality' with 'improved font rendering'
      - PR3318: Simplify glyph advance handling
      - S7102489, PR3316, RH1390708: RFE: cleanup jlong typedef on __APPLE__and
_LLP64 systems.
      - S8000351, PR3316, RH1390708: Tenuring threshold should be unsigned
      - S8153711, PR3315, RH1284948: [REDO] JDWP: Memory Leak: GlobalRefs never
deleted when processing invokeMethod command
      - S8165673, PR3320: AArch64: Fix JNI floating point argument handling
      - S8170888, PR3316, RH1390708: [linux] Experimental support for cgroup
memory limits in container (ie Docker) environments

    ChangeLog:

    2017-02-06  Andrew John Hughes  <[hidden email]>

        Bump to icedtea-2.6.9pre01.
        * Makefile.am,
        (CORBA_CHANGESET): Update to icedtea-2.6.9pre01.
        (JAXP_CHANGESET): Likewise.
        (JAXWS_CHANGESET): Likewise.
        (JDK_CHANGESET): Likewise.
        (LANGTOOLS_CHANGESET): Likewise.
        (OPENJDK_CHANGESET): Likewise.
        (CORBA_SHA256SUM): Likewise.
        (JAXP_SHA256SUM): Likewise.
        (JAXWS_SHA256SUM): Likewise.
        (JDK_SHA256SUM): Likewise.
        (LANGTOOLS_SHA256SUM): Likewise.
        (OPENJDK_SHA256SUM): Likewise.
        (ICEDTEA_ENV): Update INFINALITY_SUPPORT
        setting to IMPROVED_FONT_RENDERING,
        following PR3318.
        * NEWS: Updated.
        * configure.ac: Bump to 2.6.9pre01.
        * hotspot.map.in: Update to icedtea-2.6.9pre01.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon

Comment # 14 on bug 3318 from [hidden email]
details:
http://icedtea.classpath.org//hg/release/icedtea7-2.6?cmd=changeset;node=e7d2eae14d02
author: Andrew John Hughes <[hidden email]>
date: Mon Feb 06 09:57:00 2017 +0000

    PR3318: Replace 'infinality' with 'improved font rendering'
(--enable-improved-font-rendering)

    2017-01-24  Andrew John Hughes  <[hidden email]>

        PR3318: Replace 'infinality' with
        'improved font rendering'
        * INSTALL:
        Rename --enable-infinality to
        --enable-improved-font-rendering, as
        the code no longer relies on the infinality
        patch set.
        * Makefile.am:
        Use ENABLE_IMPROVED_FONT_RENDERING, not
        ENABLE_INFINALITY.
        * acinclude.m4:
        (IT_ENABLE_IMPROVED_FONT_RENDERING): Renamed
        from IT_ENABLE_INFINALITY. Fix variables to match
        and remove unneeded test for infinality patches.
        * configure.ac:
        Invoke IT_ENABLE_IMPROVED_FONT_RENDERING instead
        of IT_ENABLE_INFINALITY.


You are receiving this mail because:
  • You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 3318] [IcedTea7] Freetype 2.7's TT_CONFIG_OPTION_SUBPIXEL_HINTING=2 and OpenJDK enabled infinality causes missing text in rendering

bugzilla-daemon
In reply to this post by bugzilla-daemon
[hidden email] changed bug 3318
What Removed Added
Status ASSIGNED RESOLVED
Resolution --- FIXED

Comment # 15 on bug 3318 from [hidden email]
Fixed in icedtea-2.6.9pre01 and icedtea-2.7.0pre09.


You are receiving this mail because:
  • You are on the CC list for the bug.
Loading...