Code Review Request, JDK-8180643 Illegal handshake message

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Code Review Request, JDK-8180643 Illegal handshake message

Xuelei Fan-2
Hi,

Please review the update:
    http://cr.openjdk.java.net/~xuelei/8180643/webrev.00/

This update is trying to detect unknown or unsupported handshake
messages sooner rather later.

Thanks,
Xuelei
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Code Review Request, JDK-8180643 Illegal handshake message

Weijun Wang
Looks fine.

Maybe you can add a comment near the definition of these constants that when a new one is added it should be listed in the isUnsupported() method.

Thanks
Max

> On Aug 3, 2017, at 6:18 AM, Xuelei Fan <[hidden email]> wrote:
>
> Hi,
>
> Please review the update:
>   http://cr.openjdk.java.net/~xuelei/8180643/webrev.00/
>
> This update is trying to detect unknown or unsupported handshake messages sooner rather later.
>
> Thanks,
> Xuelei

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Code Review Request, JDK-8180643 Illegal handshake message

Xuelei Fan-2


On 8/2/2017 3:29 PM, Weijun Wang wrote:
> Looks fine.
>
> Maybe you can add a comment near the definition of these constants that when a new one is added it should be listed in the isUnsupported() method.
>
Good suggestion!  It's a concern of mine, too.

Thanks,
Xuelei

> Thanks
> Max
>
>> On Aug 3, 2017, at 6:18 AM, Xuelei Fan <[hidden email]> wrote:
>>
>> Hi,
>>
>> Please review the update:
>>    http://cr.openjdk.java.net/~xuelei/8180643/webrev.00/
>>
>> This update is trying to detect unknown or unsupported handshake messages sooner rather later.
>>
>> Thanks,
>> Xuelei
>
Loading...