Code Review request, JDK-6645409, Remove not used DefaultHostnameVerifier

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Code Review request, JDK-6645409, Remove not used DefaultHostnameVerifier

Xuelei Fan-2
Hi,

Please review a code cleanup update:

    https://bugs.openjdk.java.net/browse/JDK-6645409

The sun.net.www.protocol.https.DefaultHostnameVerifier is not used any
more. We can remove it safely now.

% hg remove
src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java

% hg status
src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java
R
src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java


Thanks,
Xuelei
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Code Review request, JDK-6645409, Remove not used DefaultHostnameVerifier

Sean Mullan
The bug needs a noreg-cleanup label. Also, I would change the title to
"Remove unused DefaultHostNameVerifier".

Looks fine otherwise.

--Sean

On 7/25/17 1:47 PM, Xuelei Fan wrote:

> Hi,
>
> Please review a code cleanup update:
>
>     https://bugs.openjdk.java.net/browse/JDK-6645409
>
> The sun.net.www.protocol.https.DefaultHostnameVerifier is not used any
> more. We can remove it safely now.
>
> % hg remove
> src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java
>
>
> % hg status
> src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java
>
> R
> src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java
>
>
>
> Thanks,
> Xuelei
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Code Review request, JDK-6645409, Remove not used DefaultHostnameVerifier

Xuelei Fan-2
Updated.  Thanks for the quick review.

Xuelei

On 7/25/2017 10:54 AM, Sean Mullan wrote:

> The bug needs a noreg-cleanup label. Also, I would change the title to
> "Remove unused DefaultHostNameVerifier".
>
> Looks fine otherwise.
>
> --Sean
>
> On 7/25/17 1:47 PM, Xuelei Fan wrote:
>> Hi,
>>
>> Please review a code cleanup update:
>>
>>     https://bugs.openjdk.java.net/browse/JDK-6645409
>>
>> The sun.net.www.protocol.https.DefaultHostnameVerifier is not used any
>> more. We can remove it safely now.
>>
>> % hg remove
>> src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java
>>
>>
>> % hg status
>> src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java
>>
>> R
>> src/java.base/share/classes/sun/net/www/protocol/https/DefaultHostnameVerifier.java
>>
>>
>>
>> Thanks,
>> Xuelei
Loading...