Integrated: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Integrated: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages

Yumin Qi-3
On Fri, 19 Feb 2021 18:15:45 GMT, Yumin Qi <[hidden email]> wrote:

> Hi, Please review
>   Usually most OSes are configured with page size of 4K, but some others are configured with 64K. If jdk binary is built on 4K platform and run on different configured platforms, CDS fails to be loaded due to region alignment mismatch:
>   Unable to map CDS archive -- os::vm_allocation_granularity() expected: 4096 actual: 65536
>   This change uses 64K as region alignment if OS page size is less than 64K. For most of the current OSes, means always use 64K as file map region alignment.
>    The archive size will increase about 300K due to the change.
>    Tests: tier1-4
>               Run MacOS/X64 binary on MacOS/aarch64
>
>    Thanks
>    Yumin

This pull request has now been integrated.

Changeset: 3820ab9e
Author:    Yumin Qi <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/3820ab9e
Stats:     222 lines in 16 files changed: 163 ins; 16 del; 43 mod

8236847: CDS archive with 4K alignment unusable on machines with 64k pages

Reviewed-by: iklam, stuefe, erikj, ihse

-------------

PR: https://git.openjdk.java.net/jdk/pull/2651