Integrated: 8263754: HexFormat 'fromHex' methods should be static

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Integrated: 8263754: HexFormat 'fromHex' methods should be static

Roger Riggs-2
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs <[hidden email]> wrote:

> A number of HexFormat methods converting from strings to numbers do not use delimiter, prefix, suffix, and uppercase parameters and would be more convenient if the methods were static.
> These  APIs were added early in JDK 17 and are being updated before GA.
> This PR updates existing uses in the JDK but there may be compiler warnings in non-JDK source files.
>    public boolean isHexDigit(int);
>    public int fromHexDigit(int);
>    public int fromHexDigits(java.lang.CharSequence);
>    public int fromHexDigits(java.lang.CharSequence, int, int);
>    public long fromHexDigitsToLong(java.lang.CharSequence);
>    public long fromHexDigitsToLong(java.lang.CharSequence, int, int);

This pull request has now been integrated.

Changeset: 8cf1c62c
Author:    Roger Riggs <[hidden email]>
Stats:     54 lines in 5 files changed: 0 ins; 15 del; 39 mod

8263754: HexFormat 'fromHex' methods should be static

Reviewed-by: redestad, naoto, chegar