Integrated: JDK-8264664: use text blocks in javac module tests

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8264664: use text blocks in javac module tests

Jonathan Gibbons-2
Please review an update to the javac module tests to use text blocks to represent multi-line strings.

The conversion was done mostly semi-automatically, using a utility used to covert the javadoc tests. Some edits were manual.

In all cases, there are no changes to the semantics of any test. In particular, no diagnostic messages containing line and column information were updated.

All `:tier1` tests pass on all standard platforms.

-------------

Commit messages:
 - fix whitespace issues
 - JDK-8264664: use text blocks in javac module tests

Changes: https://git.openjdk.java.net/jdk/pull/3335/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3335&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264664
  Stats: 632 lines in 18 files changed: 127 ins; 0 del; 505 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3335.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3335/head:pull/3335

PR: https://git.openjdk.java.net/jdk/pull/3335
Reply | Threaded
Open this post in threaded view
|

Re: Integrated: JDK-8264664: use text blocks in javac module tests

Joe Darcy-2
On Sat, 3 Apr 2021 00:33:54 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Please review an update to the javac module tests to use text blocks to represent multi-line strings.
>
> The conversion was done mostly semi-automatically, using a utility used to covert the javadoc tests. Some edits were manual.
>
> In all cases, there are no changes to the semantics of any test. In particular, no diagnostic messages containing line and column information were updated.
>
> All `:tier1` tests pass on all standard platforms.

Marked as reviewed by darcy (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3335
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8264664: use text blocks in javac module tests

Jonathan Gibbons-2
In reply to this post by Jonathan Gibbons-2
On Sat, 3 Apr 2021 00:33:54 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Please review an update to the javac module tests to use text blocks to represent multi-line strings.
>
> The conversion was done mostly semi-automatically, using a utility used to covert the javadoc tests. Some edits were manual.
>
> In all cases, there are no changes to the semantics of any test. In particular, no diagnostic messages containing line and column information were updated.
>
> All `:tier1` tests pass on all standard platforms.

This pull request has now been integrated.

Changeset: e8eda655
Author:    Jonathan Gibbons <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/e8eda655
Stats:     632 lines in 18 files changed: 127 ins; 0 del; 505 mod

8264664: use text blocks in javac module tests

Reviewed-by: darcy

-------------

PR: https://git.openjdk.java.net/jdk/pull/3335