JDK 10 RFR of JDK-8193489: Add information about local variable type inference to SourceVersion.RELEASE_10

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

JDK 10 RFR of JDK-8193489: Add information about local variable type inference to SourceVersion.RELEASE_10

Joseph D. Darcy
Hello,

The javadoc for the enum constants in javax.lang.model.SourceVersion
have short informative descriptions of the languages changes in each
release. The text for SourceVersion.RELEASE_10 should be updated to
mention local variable type inference (var).

Please review the patch below which adds this text.

Thanks,

-Joe

---
a/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
Wed Dec 13 17:28:24 2017 -0800
+++
b/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
Wed Dec 13 19:11:55 2017 -0800
@@ -56,7 +56,7 @@
       * 1.7: diamond syntax, try-with-resources, etc.
       * 1.8: lambda expressions and default methods
       *   9: modules, small cleanups to 1.7 and 1.8 changes
-     *  10: to-be-determined changes
+     *  10: local variable type inference (var)
       */

      /**
@@ -157,9 +157,20 @@
       * The version recognized by the Java Platform, Standard Edition
       * 10.
       *
+     * Additions in this release include local variable type inference
+     * ({@code var}).
+     *
       * @since 10
       */
       RELEASE_10;


Reply | Threaded
Open this post in threaded view
|

Re: JDK 10 RFR of JDK-8193489: Add information about local variable type inference to SourceVersion.RELEASE_10

Sundararajan Athijegannathan
Looks good

-Sundar

On 14/12/17, 8:47 AM, joe darcy wrote:

> Hello,
>
> The javadoc for the enum constants in javax.lang.model.SourceVersion
> have short informative descriptions of the languages changes in each
> release. The text for SourceVersion.RELEASE_10 should be updated to
> mention local variable type inference (var).
>
> Please review the patch below which adds this text.
>
> Thanks,
>
> -Joe
>
> ---
> a/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
> Wed Dec 13 17:28:24 2017 -0800
> +++
> b/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
> Wed Dec 13 19:11:55 2017 -0800
> @@ -56,7 +56,7 @@
>       * 1.7: diamond syntax, try-with-resources, etc.
>       * 1.8: lambda expressions and default methods
>       *   9: modules, small cleanups to 1.7 and 1.8 changes
> -     *  10: to-be-determined changes
> +     *  10: local variable type inference (var)
>       */
>
>      /**
> @@ -157,9 +157,20 @@
>       * The version recognized by the Java Platform, Standard Edition
>       * 10.
>       *
> +     * Additions in this release include local variable type inference
> +     * ({@code var}).
> +     *
>       * @since 10
>       */
>       RELEASE_10;
>
>
Reply | Threaded
Open this post in threaded view
|

Re: JDK 10 RFR of JDK-8193489: Add information about local variable type inference to SourceVersion.RELEASE_10

mark.reinhold
In reply to this post by Joseph D. Darcy
2017/12/13 19:17:56 -0800, [hidden email]:
> The javadoc for the enum constants in javax.lang.model.SourceVersion
> have short informative descriptions of the languages changes in each
> release. The text for SourceVersion.RELEASE_10 should be updated to
> mention local variable type inference (var).
>
> Please review the patch below which adds this text.

-     *  10: to-be-determined changes
+     *  10: local variable type inference (var)

+     * Additions in this release include local variable type inference

In both hunks use "local-variable type" (as in the name of its JEP, 286)
so as to distinguish it from "local variable-type".

Otherwise, looks good.

- Mark