Quantcast

JDK 9 RFR of DK-8176477: Use DirectiveVisitor to print module information

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

JDK 9 RFR of DK-8176477: Use DirectiveVisitor to print module information

joe darcy
Hello,

The printing processor's support for modules ( JDK-8173609 ) was added
before the directive visitor was added ( JDK-8175118 ).

The printing implementation should be refactored to use the directive
visitor. Please review the webrev implementation that refactoring:

     http://cr.openjdk.java.net/~darcy/8176477.0/

Thanks,

-Joe

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: JDK 9 RFR of DK-8176477: Use DirectiveVisitor to print module information

Jonathan Gibbons
Nice ;-)

-- Jon

On 03/09/2017 05:19 PM, joe darcy wrote:

> Hello,
>
> The printing processor's support for modules ( JDK-8173609 ) was added
> before the directive visitor was added ( JDK-8175118 ).
>
> The printing implementation should be refactored to use the directive
> visitor. Please review the webrev implementation that refactoring:
>
>     http://cr.openjdk.java.net/~darcy/8176477.0/
>
> Thanks,
>
> -Joe
>

Loading...