JDK 9 RFR to Fix javax.lang.model javadoc link issues

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

JDK 9 RFR to Fix javax.lang.model javadoc link issues

joe darcy
Hello,

Please review the patch below to fix two bad links in the
javax.lang.model javadoc.

Thanks,

-Joe


diff -r c73b98b79148
src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
---
a/src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
Mon Feb 13 10:29:04 2017 -0800
+++
b/src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
Mon Feb 13 10:45:40 2017 -0800
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 2005, 2017, Oracle and/or its affiliates. All rights
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -92,7 +92,7 @@
       * same set of strings as the annotation.  If the class is not so
       * annotated, an empty set is returned.
       *
-     * If the {@link ProcessingEvironment#getSourceVersion source
+     * If the {@link ProcessingEnvironment#getSourceVersion source
       * version} does not support modules, in other words if it is less
       * than or equal to {@link SourceVersion#RELEASE_8 RELEASE_8},
       * then any leading {@link Processor#getSupportedAnnotationTypes
diff -r c73b98b79148
src/java.compiler/share/classes/javax/annotation/processing/Processor.java
---
a/src/java.compiler/share/classes/javax/annotation/processing/Processor.java
Mon Feb 13 10:29:04 2017 -0800
+++
b/src/java.compiler/share/classes/javax/annotation/processing/Processor.java
Mon Feb 13 10:45:40 2017 -0800
@@ -291,7 +291,7 @@
       * @apiNote When running in an environment which supports modules,
       * processors are encouraged to include the module prefix when
       * describing their supported annotation types. The method {@link
-     * AbstractProcessor.getSupportedAnnotationTypes
+     * AbstractProcessor#getSupportedAnnotationTypes
       * AbstractProcessor.getSupportedAnnotationTypes} provides support
       * for stripping off the module prefix when running in an
       * environment without modules.

Reply | Threaded
Open this post in threaded view
|

Re: JDK 9 RFR to Fix javax.lang.model javadoc link issues

Mandy Chung
+1

Mandy

> On Feb 13, 2017, at 10:48 AM, joe darcy <[hidden email]> wrote:
>
> Hello,
>
> Please review the patch below to fix two bad links in the javax.lang.model javadoc.
>
> Thanks,
>
> -Joe
>
>
> diff -r c73b98b79148 src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
> --- a/src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java Mon Feb 13 10:29:04 2017 -0800
> +++ b/src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java Mon Feb 13 10:45:40 2017 -0800
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2005, 2017, Oracle and/or its affiliates. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -92,7 +92,7 @@
>      * same set of strings as the annotation.  If the class is not so
>      * annotated, an empty set is returned.
>      *
> -     * If the {@link ProcessingEvironment#getSourceVersion source
> +     * If the {@link ProcessingEnvironment#getSourceVersion source
>      * version} does not support modules, in other words if it is less
>      * than or equal to {@link SourceVersion#RELEASE_8 RELEASE_8},
>      * then any leading {@link Processor#getSupportedAnnotationTypes
> diff -r c73b98b79148 src/java.compiler/share/classes/javax/annotation/processing/Processor.java
> --- a/src/java.compiler/share/classes/javax/annotation/processing/Processor.java Mon Feb 13 10:29:04 2017 -0800
> +++ b/src/java.compiler/share/classes/javax/annotation/processing/Processor.java Mon Feb 13 10:45:40 2017 -0800
> @@ -291,7 +291,7 @@
>      * @apiNote When running in an environment which supports modules,
>      * processors are encouraged to include the module prefix when
>      * describing their supported annotation types. The method {@link
> -     * AbstractProcessor.getSupportedAnnotationTypes
> +     * AbstractProcessor#getSupportedAnnotationTypes
>      * AbstractProcessor.getSupportedAnnotationTypes} provides support
>      * for stripping off the module prefix when running in an
>      * environment without modules.
>

Reply | Threaded
Open this post in threaded view
|

Re: JDK 9 RFR to Fix javax.lang.model javadoc link issues

Jonathan Gibbons
In reply to this post by joe darcy
Looks good.

-- Jon

On 02/13/2017 10:48 AM, joe darcy wrote:

> Hello,
>
> Please review the patch below to fix two bad links in the
> javax.lang.model javadoc.
>
> Thanks,
>
> -Joe
>
>
> diff -r c73b98b79148
> src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
> ---
> a/src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
> Mon Feb 13 10:29:04 2017 -0800
> +++
> b/src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
> Mon Feb 13 10:45:40 2017 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights
> reserved.
> + * Copyright (c) 2005, 2017, Oracle and/or its affiliates. All rights
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -92,7 +92,7 @@
>       * same set of strings as the annotation.  If the class is not so
>       * annotated, an empty set is returned.
>       *
> -     * If the {@link ProcessingEvironment#getSourceVersion source
> +     * If the {@link ProcessingEnvironment#getSourceVersion source
>       * version} does not support modules, in other words if it is less
>       * than or equal to {@link SourceVersion#RELEASE_8 RELEASE_8},
>       * then any leading {@link Processor#getSupportedAnnotationTypes
> diff -r c73b98b79148
> src/java.compiler/share/classes/javax/annotation/processing/Processor.java
> ---
> a/src/java.compiler/share/classes/javax/annotation/processing/Processor.java
> Mon Feb 13 10:29:04 2017 -0800
> +++
> b/src/java.compiler/share/classes/javax/annotation/processing/Processor.java
> Mon Feb 13 10:45:40 2017 -0800
> @@ -291,7 +291,7 @@
>       * @apiNote When running in an environment which supports modules,
>       * processors are encouraged to include the module prefix when
>       * describing their supported annotation types. The method {@link
> -     * AbstractProcessor.getSupportedAnnotationTypes
> +     * AbstractProcessor#getSupportedAnnotationTypes
>       * AbstractProcessor.getSupportedAnnotationTypes} provides support
>       * for stripping off the module prefix when running in an
>       * environment without modules.
>