More careful identification of @ignore

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

More careful identification of @ignore

Martin Buchholz-3
Hi jtreg maintainers,

This is a bug report.

If I try to test  jdk/test/sun/net/idn/PunycodeTest.java,
with @ignore'd tests suppressed, I get:

 jdk/test/sun/net/idn  $ ~/jct-tools/3.2.2_03/linux/bin/jtreg
-v:nopass,fail -automatic "-k:\!ignore"
-testjdk:$FOREST/jdk/../build/linux-i586/j2sdk-image PunycodeTest.java
Test results: no tests selected

This is due to the occurrence of the string "ignore" in

 * @compile -XDignore.symbol.file PunycodeTest.java

as any mangling of that string in the sources and retesting demonstrates.

Probably the original coder was lazy and simply searched for the
"ignore" substring,
whereas a more disciplined search for @ignore or maybe @key WORD ...
is necessary.

Martin
Reply | Threaded
Open this post in threaded view
|

Re: More careful identification of @ignore

jonathan.gibbons
Eeeek, so noted. I'll investigate.

-- Jon


Martin Buchholz wrote:

> Hi jtreg maintainers,
>
> This is a bug report.
>
> If I try to test  jdk/test/sun/net/idn/PunycodeTest.java,
> with @ignore'd tests suppressed, I get:
>
>  jdk/test/sun/net/idn  $ ~/jct-tools/3.2.2_03/linux/bin/jtreg
> -v:nopass,fail -automatic "-k:\!ignore"
> -testjdk:$FOREST/jdk/../build/linux-i586/j2sdk-image PunycodeTest.java
> Test results: no tests selected
>
> This is due to the occurrence of the string "ignore" in
>
>  * @compile -XDignore.symbol.file PunycodeTest.java
>
> as any mangling of that string in the sources and retesting demonstrates.
>
> Probably the original coder was lazy and simply searched for the
> "ignore" substring,
> whereas a more disciplined search for @ignore or maybe @key WORD ...
> is necessary.
>
> Martin
>  

Reply | Threaded
Open this post in threaded view
|

Re: More careful identification of @ignore

jonathan.gibbons
Egads, 'twould appear t'be true.

As a workaround, I suggest you use the -ignore switch (e.g. -ignore:quiet)
instead of -k:\!ignore.

-- Jon


Jonathan Gibbons wrote:

> Eeeek, so noted. I'll investigate.
>
> -- Jon
>
>
> Martin Buchholz wrote:
>> Hi jtreg maintainers,
>>
>> This is a bug report.
>>
>> If I try to test  jdk/test/sun/net/idn/PunycodeTest.java,
>> with @ignore'd tests suppressed, I get:
>>
>>  jdk/test/sun/net/idn  $ ~/jct-tools/3.2.2_03/linux/bin/jtreg
>> -v:nopass,fail -automatic "-k:\!ignore"
>> -testjdk:$FOREST/jdk/../build/linux-i586/j2sdk-image PunycodeTest.java
>> Test results: no tests selected
>>
>> This is due to the occurrence of the string "ignore" in
>>
>>  * @compile -XDignore.symbol.file PunycodeTest.java
>>
>> as any mangling of that string in the sources and retesting
>> demonstrates.
>>
>> Probably the original coder was lazy and simply searched for the
>> "ignore" substring,
>> whereas a more disciplined search for @ignore or maybe @key WORD ...
>> is necessary.
>>
>> Martin
>>  
>
>

Reply | Threaded
Open this post in threaded view
|

Re: More careful identification of @ignore

Martin Buchholz-3
On Thu, Oct 2, 2008 at 11:47, Jonathan Gibbons <[hidden email]> wrote:
> Egads, 'twould appear t'be true.
>
> As a workaround, I suggest you use the -ignore switch (e.g. -ignore:quiet)
> instead of -k:\!ignore.

I tried -ignore:quiet,
but that appears to have the same bug;
that is, it is not a workaround.

Martin
Reply | Threaded
Open this post in threaded view
|

Re: More careful identification of @ignore

jonathan.gibbons
I'm sorry; that is  ... disappointing.  I'll raise the priority to fix this.

-- Jon

Martin Buchholz wrote:
On Thu, Oct 2, 2008 at 11:47, Jonathan Gibbons [hidden email] wrote:
  
Egads, 'twould appear t'be true.

As a workaround, I suggest you use the -ignore switch (e.g. -ignore:quiet)
instead of -k:\!ignore.
    

I tried -ignore:quiet,
but that appears to have the same bug;
that is, it is not a workaround.

Martin