[Patch] 8081820: Generate warnings for multiple «@param» and «@return»

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] 8081820: Generate warnings for multiple «@param» and «@return»

Denis Istomin
Hi,
Made patch for bug 8081820. Warnings are generated in doclint.

--
Denis Istomin

8081820 patch.txt (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] 8081820: Generate warnings for multiple «@param» and «@return»

Jonathan Gibbons


On 01/09/2017 05:29 PM, Denis Istomin wrote:
> Hi,
> Made patch for bug 8081820. Warnings are generated in doclint.
>
> --
> Denis Istomin

Denis,

The changes to the mainline src/ code look OK, but your two new tests do
not follow
the pattern of existing tests. If you look at a random test, such as
EndTagsTest,
you'll see there are a couple of @run main lines.

EndTagsTest.java: * @run main DocLintTester -Xmsgs:-html EndTagsTest.java
EndTagsTest.java: * @run main DocLintTester -ref EndTagsTest.out
EndTagsTest.java

The purpose of the pair is that together they verify the checks are
enabled in
the right category.  The first line verifies that no output is generated
for bad input
when the category is disabled; the second line verifies that the
expected output
is generated when the category is not disabled.

-- Jon
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] 8081820: Generate warnings for multiple «@param» and «@return»

Jonathan Gibbons
Denis,

We wanted to get this issue closed out, so I have made the minor
corrections to your
patch and pushed it on your behalf.

Thank you for your contribution.

-- Jon


On 01/24/2017 06:29 PM, Jonathan Gibbons wrote:

>
>
> On 01/09/2017 05:29 PM, Denis Istomin wrote:
>> Hi,
>> Made patch for bug 8081820. Warnings are generated in doclint.
>>
>> --
>> Denis Istomin
>
> Denis,
>
> The changes to the mainline src/ code look OK, but your two new tests
> do not follow
> the pattern of existing tests. If you look at a random test, such as
> EndTagsTest,
> you'll see there are a couple of @run main lines.
>
> EndTagsTest.java: * @run main DocLintTester -Xmsgs:-html EndTagsTest.java
> EndTagsTest.java: * @run main DocLintTester -ref EndTagsTest.out
> EndTagsTest.java
>
> The purpose of the pair is that together they verify the checks are
> enabled in
> the right category.  The first line verifies that no output is
> generated for bad input
> when the category is disabled; the second line verifies that the
> expected output
> is generated when the category is not disabled.
>
> -- Jon