RE: FW: RFR(M): 8189102: All tools should support -?, -h and --help

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

RE: FW: RFR(M): 8189102: All tools should support -?, -h and --help

Lindenmaier, Goetz
Hi Alan,

Javadoc combines documentation and support of a flag in the
way the flag handling is implemented.  On the other side,
it prints the help message anyways if a wrong flag is presented
to it, so if you call it with -help you get the help message.
Therefore, in my original change where I tried to get it
more cleaned up, I removed -help support and documentation
from Javadoc.

I added it again and updated the table in the CSR:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.06/

Best regards,
  Goetz.

> -----Original Message-----
> From: Alan Bateman [mailto:[hidden email]]
> Sent: Montag, 11. Dezember 2017 17:53
> To: Lindenmaier, Goetz <[hidden email]>; core-libs-
> [hidden email]; '[hidden email]' <compiler-
> [hidden email]>; serviceability-dev (serviceability-
> [hidden email]) <[hidden email]>
> Subject: Re: FW: RFR(M): 8189102: All tools should support -?, -h and --help
>
>
>
> On 07/12/2017 11:20, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > ... missed some lists in my first post ...
> >
> > I prepared a fifth webrev for this change.  Please review.
> >
> > It incorporates the changes requested by the CSR reviewers
> > (not to remove docuemtation of '-help' where is was documented
> > before) and the changes proposed by Kumar:
> > http://cr.openjdk.java.net/~goetz/wr17/8189102-
> helpMessage/webrev.05/
> >
> >
> Looks like it still drops -help from the javadoc usage message, I can't
> tell if you meant to do that.
>
> -Alan.