RE: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RE: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

Kharbas, Kishor

Thanks Sangheon!

 

I will make the change.

 

-Kishor

 

From: sangheon.kim [mailto:[hidden email]]
Sent: Friday, November 3, 2017 2:38 PM
To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <[hidden email]>; '[hidden email]' <[hidden email]>; [hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

 

Hi Kishor,

On 11/03/2017 11:39 AM, Kharbas, Kishor wrote:

Thanks a lot!
 
Link to updated webrevs -
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/

Thank you for fixing all.
Looks good to me except below.

Could you update the copyright format in TestAllocateHeapAt.java?
2  * Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved.
- Missing comma: * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.

Thanks,
Sangheon



 
 
@Sangheon: Please let me know if you see any corrections needed.
 
-Kishor
 
-----Original Message-----
From: Thomas Schatzl [[hidden email]]
Sent: Friday, November 3, 2017 7:31 AM
To: Kharbas, Kishor [hidden email]; sangheon.kim
[hidden email]; '[hidden email]'
[hidden email]; hotspot-runtime-
[hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative
memory devices and CSR review
 
Hi,
 
On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
Hi Sangheon,
 
Thanks for the review and comments. Here is an updated webrev-
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
 
In addition to your suggested corrections, I added code to set Linux
core dump filter ensuring Heap is dumped correctly when this feature
is used. This is follow-up to Jini George’s comment
(http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
allocation-on-alternative-memory-devices-td300109.html#a300450).
 
Some minor nits:
 
 - os_posix.cpp:300: please move the else next to the brace
 - arguments.cpp:4624: please add a space between "if" and the bracket
 
I do not need to see a new webrev for these changes. Looks good.
 
Thanks,
  Thomas
 

 

Reply | Threaded
Open this post in threaded view
|

RE: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

Kharbas, Kishor

Hi Sangheon,

 

Here is link to the updated webrev-

http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14/

http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14_to_13/

 

Thanks

Kishor

 

From: sangheon.kim [mailto:[hidden email]]
Sent: Friday, November 3, 2017 2:38 PM
To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <[hidden email]>; '[hidden email]' <[hidden email]>; [hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

 

Hi Kishor,

On 11/03/2017 11:39 AM, Kharbas, Kishor wrote:

Thanks a lot!
 
Link to updated webrevs -
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/

Thank you for fixing all.
Looks good to me except below.

Could you update the copyright format in TestAllocateHeapAt.java?
2  * Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved.
- Missing comma: * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.

Thanks,
Sangheon



 
 
@Sangheon: Please let me know if you see any corrections needed.
 
-Kishor
 
-----Original Message-----
From: Thomas Schatzl [[hidden email]]
Sent: Friday, November 3, 2017 7:31 AM
To: Kharbas, Kishor [hidden email]; sangheon.kim
[hidden email]; '[hidden email]'
[hidden email]; hotspot-runtime-
[hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative
memory devices and CSR review
 
Hi,
 
On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
Hi Sangheon,
 
Thanks for the review and comments. Here is an updated webrev-
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
 
In addition to your suggested corrections, I added code to set Linux
core dump filter ensuring Heap is dumped correctly when this feature
is used. This is follow-up to Jini George’s comment
(http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
allocation-on-alternative-memory-devices-td300109.html#a300450).
 
Some minor nits:
 
 - os_posix.cpp:300: please move the else next to the brace
 - arguments.cpp:4624: please add a space between "if" and the bracket
 
I do not need to see a new webrev for these changes. Looks good.
 
Thanks,
  Thomas
 

 

Reply | Threaded
Open this post in threaded view
|

Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

sangheon.kim@oracle.com
Hi Kishor,


On 11/03/2017 02:59 PM, Kharbas, Kishor wrote:
Looks good to me.

Thanks,
Sangheon


 

Thanks

Kishor

 

From: sangheon.kim [[hidden email]]
Sent: Friday, November 3, 2017 2:38 PM
To: Kharbas, Kishor [hidden email]; Thomas Schatzl [hidden email]; '[hidden email]' [hidden email]; [hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

 

Hi Kishor,

On 11/03/2017 11:39 AM, Kharbas, Kishor wrote:

Thanks a lot!
 
Link to updated webrevs -
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/

Thank you for fixing all.
Looks good to me except below.

Could you update the copyright format in TestAllocateHeapAt.java?
2  * Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved.
- Missing comma: * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.

Thanks,
Sangheon



 
 
@Sangheon: Please let me know if you see any corrections needed.
 
-Kishor
 
-----Original Message-----
From: Thomas Schatzl [[hidden email]]
Sent: Friday, November 3, 2017 7:31 AM
To: Kharbas, Kishor [hidden email]; sangheon.kim
[hidden email]; '[hidden email]'
[hidden email]; hotspot-runtime-
[hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative
memory devices and CSR review
 
Hi,
 
On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
Hi Sangheon,
 
Thanks for the review and comments. Here is an updated webrev-
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
 
In addition to your suggested corrections, I added code to set Linux
core dump filter ensuring Heap is dumped correctly when this feature
is used. This is follow-up to Jini George’s comment
(http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
allocation-on-alternative-memory-devices-td300109.html#a300450).
 
Some minor nits:
 
 - os_posix.cpp:300: please move the else next to the brace
 - arguments.cpp:4624: please add a space between "if" and the bracket
 
I do not need to see a new webrev for these changes. Looks good.
 
Thanks,
  Thomas
 

 


Reply | Threaded
Open this post in threaded view
|

RE: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

Kharbas, Kishor

Greetings,

 

I have an updated webrev to remove compilation warning on Windows 32-bit.

http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15/

http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15_to_14/

 

Sorry missed this earlier. I request for a review on this update.

 

Thanks

Kishor

 

From: sangheon.kim [mailto:[hidden email]]
Sent: Friday, November 3, 2017 4:07 PM
To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <[hidden email]>; '[hidden email]' <[hidden email]>; [hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

 

Hi Kishor,

On 11/03/2017 02:59 PM, Kharbas, Kishor wrote:

Hi Sangheon,

 

Here is link to the updated webrev-

http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14/

http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14_to_13/

Looks good to me.

Thanks,
Sangheon



 

Thanks

Kishor

 

From: sangheon.kim [[hidden email]]
Sent: Friday, November 3, 2017 2:38 PM
To: Kharbas, Kishor [hidden email]; Thomas Schatzl [hidden email]; '[hidden email]' [hidden email]; [hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

 

Hi Kishor,

On 11/03/2017 11:39 AM, Kharbas, Kishor wrote:

Thanks a lot!
 
Link to updated webrevs -
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/

Thank you for fixing all.
Looks good to me except below.

Could you update the copyright format in TestAllocateHeapAt.java?
2  * Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved.
- Missing comma: * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.

Thanks,
Sangheon




 
 
@Sangheon: Please let me know if you see any corrections needed.
 
-Kishor
 
-----Original Message-----
From: Thomas Schatzl [[hidden email]]
Sent: Friday, November 3, 2017 7:31 AM
To: Kharbas, Kishor [hidden email]; sangheon.kim
[hidden email]; '[hidden email]'
[hidden email]; hotspot-runtime-
[hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative
memory devices and CSR review
 
Hi,
 
On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
Hi Sangheon,
 
Thanks for the review and comments. Here is an updated webrev-
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
 
In addition to your suggested corrections, I added code to set Linux
core dump filter ensuring Heap is dumped correctly when this feature
is used. This is follow-up to Jini George’s comment
(http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
allocation-on-alternative-memory-devices-td300109.html#a300450).
 
Some minor nits:
 
 - os_posix.cpp:300: please move the else next to the brace
 - arguments.cpp:4624: please add a space between "if" and the bracket
 
I do not need to see a new webrev for these changes. Looks good.
 
Thanks,
  Thomas
 

 

 

Reply | Threaded
Open this post in threaded view
|

Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

Thomas Schatzl
Hi Kishor,

On Mon, 2017-11-13 at 19:40 +0000, Kharbas, Kishor wrote:
> Greetings,
>  
> I have an updated webrev to remove compilation warning on Windows 32-
> bit.
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15/
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15_to_14/
>  
> Sorry missed this earlier. I request for a review on this update.

  looks good. The other changes from webrev.13 on also look good.

Thanks,
  Thomas

>  
> Thanks
> Kishor
>  
> From: sangheon.kim [mailto:[hidden email]
> Sent: Friday, November 3, 2017 4:07 PM
> To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <thoma
> [hidden email]>; '[hidden email]' <hotspot-gc-
> [hidden email]>; [hidden email]
> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
> alternative memory devices and CSR review
>  
> Hi Kishor,
>
>
> On 11/03/2017 02:59 PM, Kharbas, Kishor wrote:
> Hi Sangheon,
>  
> Here is link to the updated webrev-
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14/
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14_to_13/
> Looks good to me.
>
> Thanks,
> Sangheon
>
>
>
>  
> Thanks
> Kishor
>  
> From: sangheon.kim [mailto:[hidden email]
> Sent: Friday, November 3, 2017 2:38 PM
> To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <thoma
> [hidden email]>; '[hidden email]' <hotspot-gc-
> [hidden email]>; [hidden email]
> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
> alternative memory devices and CSR review
>  
> Hi Kishor,
>
> On 11/03/2017 11:39 AM, Kharbas, Kishor wrote:
> Thanks a lot!
>  
> Link to updated webrevs -
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/
> Thank you for fixing all.
> Looks good to me except below.
>
> Could you update the copyright format in TestAllocateHeapAt.java?
> 2  * Copyright (c) 2017 Oracle and/or its affiliates. All rights
> reserved.
> - Missing comma: * Copyright (c) 2017, Oracle and/or its affiliates.
> All rights reserved.
>
> Thanks,
> Sangheon
>
>
>
>
>  
>  
> @Sangheon: Please let me know if you see any corrections needed.
>  
> -Kishor
>  
> -----Original Message-----
> From: Thomas Schatzl [mailto:[hidden email]]
> Sent: Friday, November 3, 2017 7:31 AM
> To: Kharbas, Kishor <[hidden email]>; sangheon.kim
> <[hidden email]>; '[hidden email]'
> <[hidden email]>; hotspot-runtime-
> [hidden email]
> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
> alternative
> memory devices and CSR review
>  
> Hi,
>  
> On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
> Hi Sangheon,
>  
> Thanks for the review and comments. Here is an updated webrev-
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
>  
> In addition to your suggested corrections, I added code to set Linux
> core dump filter ensuring Heap is dumped correctly when this feature
> is used. This is follow-up to Jini George’s comment
> (http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
> allocation-on-alternative-memory-devices-td300109.html#a300450).
>  
> Some minor nits:
>  
>  - os_posix.cpp:300: please move the else next to the brace
>  - arguments.cpp:4624: please add a space between "if" and the
> bracket
>  
> I do not need to see a new webrev for these changes. Looks good.
>  
> Thanks,
>   Thomas
>  
>  
>  

Reply | Threaded
Open this post in threaded view
|

Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

sangheon.kim@oracle.com
Hi Kishor,

On 11/13/2017 12:40 PM, Thomas Schatzl wrote:

> Hi Kishor,
>
> On Mon, 2017-11-13 at 19:40 +0000, Kharbas, Kishor wrote:
>> Greetings,
>>  
>> I have an updated webrev to remove compilation warning on Windows 32-
>> bit.
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15/
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15_to_14/
>>  
>> Sorry missed this earlier. I request for a review on this update.
>    looks good. The other changes from webrev.13 on also look good.
+1

Thanks,
Sangheon


>
> Thanks,
>    Thomas
>
>>  
>> Thanks
>> Kishor
>>  
>> From: sangheon.kim [mailto:[hidden email]]
>> Sent: Friday, November 3, 2017 4:07 PM
>> To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <thoma
>> [hidden email]>; '[hidden email]' <hotspot-gc-
>> [hidden email]>; [hidden email]
>> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
>> alternative memory devices and CSR review
>>  
>> Hi Kishor,
>>
>>
>> On 11/03/2017 02:59 PM, Kharbas, Kishor wrote:
>> Hi Sangheon,
>>  
>> Here is link to the updated webrev-
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14/
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14_to_13/
>> Looks good to me.
>>
>> Thanks,
>> Sangheon
>>
>>
>>
>>  
>> Thanks
>> Kishor
>>  
>> From: sangheon.kim [mailto:[hidden email]]
>> Sent: Friday, November 3, 2017 2:38 PM
>> To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <thoma
>> [hidden email]>; '[hidden email]' <hotspot-gc-
>> [hidden email]>; [hidden email]
>> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
>> alternative memory devices and CSR review
>>  
>> Hi Kishor,
>>
>> On 11/03/2017 11:39 AM, Kharbas, Kishor wrote:
>> Thanks a lot!
>>  
>> Link to updated webrevs -
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/
>> Thank you for fixing all.
>> Looks good to me except below.
>>
>> Could you update the copyright format in TestAllocateHeapAt.java?
>> 2  * Copyright (c) 2017 Oracle and/or its affiliates. All rights
>> reserved.
>> - Missing comma: * Copyright (c) 2017, Oracle and/or its affiliates.
>> All rights reserved.
>>
>> Thanks,
>> Sangheon
>>
>>
>>
>>
>>  
>>  
>> @Sangheon: Please let me know if you see any corrections needed.
>>  
>> -Kishor
>>  
>> -----Original Message-----
>> From: Thomas Schatzl [mailto:[hidden email]]
>> Sent: Friday, November 3, 2017 7:31 AM
>> To: Kharbas, Kishor <[hidden email]>; sangheon.kim
>> <[hidden email]>; '[hidden email]'
>> <[hidden email]>; hotspot-runtime-
>> [hidden email]
>> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
>> alternative
>> memory devices and CSR review
>>  
>> Hi,
>>  
>> On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
>> Hi Sangheon,
>>  
>> Thanks for the review and comments. Here is an updated webrev-
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
>>  
>> In addition to your suggested corrections, I added code to set Linux
>> core dump filter ensuring Heap is dumped correctly when this feature
>> is used. This is follow-up to Jini George’s comment
>> (http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
>> allocation-on-alternative-memory-devices-td300109.html#a300450).
>>  
>> Some minor nits:
>>  
>>   - os_posix.cpp:300: please move the else next to the brace
>>   - arguments.cpp:4624: please add a space between "if" and the
>> bracket
>>  
>> I do not need to see a new webrev for these changes. Looks good.
>>  
>> Thanks,
>>    Thomas
>>  
>>  
>>  

Reply | Threaded
Open this post in threaded view
|

RE: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

Kharbas, Kishor
Thanks Sangheon and Thomas!

-----Original Message-----
From: sangheon.kim [mailto:[hidden email]]
Sent: Monday, November 13, 2017 12:41 PM
To: Thomas Schatzl <[hidden email]>; Kharbas, Kishor <[hidden email]>; '[hidden email]' <[hidden email]>; [hidden email]
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

Hi Kishor,

On 11/13/2017 12:40 PM, Thomas Schatzl wrote:

> Hi Kishor,
>
> On Mon, 2017-11-13 at 19:40 +0000, Kharbas, Kishor wrote:
>> Greetings,
>>  
>> I have an updated webrev to remove compilation warning on Windows 32-
>> bit.
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15/
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15_to_14/
>>  
>> Sorry missed this earlier. I request for a review on this update.
>    looks good. The other changes from webrev.13 on also look good.
+1

Thanks,
Sangheon


>
> Thanks,
>    Thomas
>
>>  
>> Thanks
>> Kishor
>>  
>> From: sangheon.kim [mailto:[hidden email]]
>> Sent: Friday, November 3, 2017 4:07 PM
>> To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <thoma
>> [hidden email]>; '[hidden email]' <hotspot-gc-
>> [hidden email]>; [hidden email]
>> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
>> alternative memory devices and CSR review
>>  
>> Hi Kishor,
>>
>>
>> On 11/03/2017 02:59 PM, Kharbas, Kishor wrote:
>> Hi Sangheon,
>>  
>> Here is link to the updated webrev-
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14/
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14_to_13/
>> Looks good to me.
>>
>> Thanks,
>> Sangheon
>>
>>
>>
>>  
>> Thanks
>> Kishor
>>  
>> From: sangheon.kim [mailto:[hidden email]]
>> Sent: Friday, November 3, 2017 2:38 PM
>> To: Kharbas, Kishor <[hidden email]>; Thomas Schatzl <thoma
>> [hidden email]>; '[hidden email]' <hotspot-gc-
>> [hidden email]>; [hidden email]
>> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
>> alternative memory devices and CSR review
>>  
>> Hi Kishor,
>>
>> On 11/03/2017 11:39 AM, Kharbas, Kishor wrote:
>> Thanks a lot!
>>  
>> Link to updated webrevs -
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/
>> Thank you for fixing all.
>> Looks good to me except below.
>>
>> Could you update the copyright format in TestAllocateHeapAt.java?
>> 2  * Copyright (c) 2017 Oracle and/or its affiliates. All rights
>> reserved.
>> - Missing comma: * Copyright (c) 2017, Oracle and/or its affiliates.
>> All rights reserved.
>>
>> Thanks,
>> Sangheon
>>
>>
>>
>>
>>  
>>  
>> @Sangheon: Please let me know if you see any corrections needed.
>>  
>> -Kishor
>>  
>> -----Original Message-----
>> From: Thomas Schatzl [mailto:[hidden email]]
>> Sent: Friday, November 3, 2017 7:31 AM
>> To: Kharbas, Kishor <[hidden email]>; sangheon.kim
>> <[hidden email]>; '[hidden email]'
>> <[hidden email]>; hotspot-runtime-
>> [hidden email]
>> Subject: Re: RFR(M): 8190308: Supporting heap allocation on
>> alternative memory devices and CSR review
>>  
>> Hi,
>>  
>> On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
>> Hi Sangheon,
>>  
>> Thanks for the review and comments. Here is an updated webrev-
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
>> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
>>  
>> In addition to your suggested corrections, I added code to set Linux
>> core dump filter ensuring Heap is dumped correctly when this feature
>> is used. This is follow-up to Jini George’s comment
>> (http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
>> allocation-on-alternative-memory-devices-td300109.html#a300450).
>>  
>> Some minor nits:
>>  
>>   - os_posix.cpp:300: please move the else next to the brace
>>   - arguments.cpp:4624: please add a space between "if" and the
>> bracket
>>  
>> I do not need to see a new webrev for these changes. Looks good.
>>  
>> Thanks,
>>    Thomas
>>  
>>  
>>