RFR[10]: 8185072 network006 times out in many configs in JDK10-hs nightly

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR[10]: 8185072 network006 times out in many configs in JDK10-hs nightly

Vyom Tewari
Hi,

Please review, small code change below.

webrev: http://cr.openjdk.java.net/~vtewari/8185072/webrev0.0/index.html

BugId:  https://bugs.openjdk.java.net/browse/JDK-8185072

this is regression because of "JDK-8179905".

Thanks,

Vyom

Reply | Threaded
Open this post in threaded view
|

Re: RFR[10]: 8185072 network006 times out in many configs in JDK10-hs nightly

Vyom Tewari
ping!!

Vyom


On Friday 15 September 2017 02:59 PM, vyom tewari wrote:

> Hi,
>
> Please review, small code change below.
>
> webrev: http://cr.openjdk.java.net/~vtewari/8185072/webrev0.0/index.html
>
> BugId:  https://bugs.openjdk.java.net/browse/JDK-8185072
>
> this is regression because of "JDK-8179905".
>
> Thanks,
>
> Vyom
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR[10]: 8185072 network006 times out in many configs in JDK10-hs nightly

Chris Hegarty
In reply to this post by Vyom Tewari

> On 15 Sep 2017, at 10:29, vyom tewari <[hidden email]> wrote:
>
> Hi,
>
> Please review, small code change below.
>
> webrev: http://cr.openjdk.java.net/~vtewari/8185072/webrev0.0/index.html

The changes look good to me Vyom. ( I only took a cursory look at the test changes )

-Chris.

Reply | Threaded
Open this post in threaded view
|

Re: RFR[10]: 8185072 network006 times out in many configs in JDK10-hs nightly

roger riggs
Hi Vyom,

Looks fine to me too.

My only concern was adding an intensive test (used to be a stress test)
to the normal
test cycles.  I'd be more comfortable with it being in a separate/lower
tier or as @manual.

Roger



On 9/24/2017 1:15 PM, Chris Hegarty wrote:

>> On 15 Sep 2017, at 10:29, vyom tewari <[hidden email]> wrote:
>>
>> Hi,
>>
>> Please review, small code change below.
>>
>> webrev: http://cr.openjdk.java.net/~vtewari/8185072/webrev0.0/index.html
> The changes look good to me Vyom. ( I only took a cursory look at the test changes )
>
> -Chris.
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR[10]: 8185072 network006 times out in many configs in JDK10-hs nightly

Vyom Tewari


On Monday 25 September 2017 08:08 PM, Roger Riggs wrote:
> Hi Vyom,
>
> Looks fine to me too.
>
> My only concern was adding an intensive test (used to be a stress
> test) to the normal
> test cycles.  I'd be more comfortable with it being in a
> separate/lower tier or as @manual.
thanks for review, i will make it "manual" before pushing as we already
have similar test at lower tier.
Vyom

>
> Roger
>
>
>
> On 9/24/2017 1:15 PM, Chris Hegarty wrote:
>>> On 15 Sep 2017, at 10:29, vyom tewari <[hidden email]> wrote:
>>>
>>> Hi,
>>>
>>> Please review, small code change below.
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~vtewari/8185072/webrev0.0/index.html
>> The changes look good to me Vyom. ( I only took a cursory look at the
>> test changes )
>>
>> -Chris.
>>
>