RFR [10] 8194883: Unhandleable Push Promises should be cancelled

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR [10] 8194883: Unhandleable Push Promises should be cancelled

Chris Hegarty
Push promises should be implicitly cancelled/rejected by the
HTTP Client implementation when a client-initiated request
does not provide a handler for push promises, rather than
causing the initiating-request to fail. 


Note: the condition need not check noMorePushes, as push
promises, or any other message for that matter, that are
received after the main responses end of stream has been
received are already handled elsewhere.

-Chris. 
Reply | Threaded
Open this post in threaded view
|

Re: RFR [10] 8194883: Unhandleable Push Promises should be cancelled

Daniel Fuchs

Looks fine to me Chris!

best regards,

-- daniel

On 10/01/2018 17:03, Chris Hegarty wrote:

> Push promises should be implicitly cancelled/rejected by the
> HTTP Client implementation when a client-initiated request
> does not provide a handler for push promises, rather than
> causing the initiating-request to fail.
>
> http://cr.openjdk.java.net/~chegar/8194883/webrev/
>
> Note: the condition need not check noMorePushes, as push
> promises, or any other message for that matter, that are
> received after the main responses end of stream has been
> received are already handled elsewhere.
>
> -Chris.