Hi all,
This patch replaces javac's `Filter` with `Predicate` and set `Filter` as `Deprecated`. Two existing tests failed and I fixed it. Currently, all the tests in `test/langtools` passed locally by using the following command. make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/ Thank you for taking the time to review. Best Regards. ------------- Commit messages: - Add comments. - 8057543: Replace javac's Filter with Predicate (and lambdas) Changes: https://git.openjdk.java.net/jdk/pull/1898/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1898&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8057543 Stats: 147 lines in 19 files changed: 22 ins; 6 del; 119 mod Patch: https://git.openjdk.java.net/jdk/pull/1898.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1898/head:pull/1898 PR: https://git.openjdk.java.net/jdk/pull/1898 |
On Sun, 27 Dec 2020 14:54:16 GMT, Guoxiong Li <[hidden email]> wrote:
> Hi all, > > This patch replaces javac's `Filter` with `Predicate` and sets `Filter` as `Deprecated`. > Two existing tests failed and I fixed it. > Currently, all the tests in `test/langtools` passed locally by using the following command. > > make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/ > > Thank you for taking the time to review. > > Best Regards. More information and some similar issues: These four issues were fixed in [this patch](https://github.com/openjdk/jdk/commit/c4e8276376676bda9aa4cb00b6d071fb70c21b85) [JDK-8057542](https://bugs.openjdk.java.net/browse/JDK-8057542) [JDK-8057545](https://bugs.openjdk.java.net/browse/JDK-8057545) [JDK-8057546](https://bugs.openjdk.java.net/browse/JDK-8057546) [JDK-8057547](https://bugs.openjdk.java.net/browse/JDK-8057547) This issue was fixed in [this patch](https://github.com/openjdk/jdk/commit/582a4ebd92e60f95ae77d25eb00c6a146e727fab) [JDK-8057544](https://bugs.openjdk.java.net/browse/JDK-8057544) But their status are still `NEW`. It should be revised to `RESOLVED` or `CLOSED`. ------------- PR: https://git.openjdk.java.net/jdk/pull/1898 |
In reply to this post by Guoxiong Li-2
On Sun, 27 Dec 2020 14:54:16 GMT, Guoxiong Li <[hidden email]> wrote:
> Hi all, > > This patch replaces javac's `Filter` with `Predicate` and sets `Filter` as `Deprecated`. > Two existing tests failed and I fixed it. > Currently, all the tests in `test/langtools` passed locally by using the following command. > > make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/ > > Thank you for taking the time to review. > > Best Regards. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk/pull/1898 |
In reply to this post by Guoxiong Li-2
On Sun, 27 Dec 2020 14:54:16 GMT, Guoxiong Li <[hidden email]> wrote:
> Hi all, > > This patch replaces javac's `Filter` with `Predicate` and sets `Filter` as `Deprecated`. > Two existing tests failed and I fixed it. > Currently, all the tests in `test/langtools` passed locally by using the following command. > > make test CONF=linux-x86_64-server-release JOBS=4 TEST=test/langtools/ > > Thank you for taking the time to review. > > Best Regards. This looks very good - sorry I missed it. If you reopen I will approve! ------------- PR: https://git.openjdk.java.net/jdk/pull/1898 |
Free forum by Nabble | Edit this page |