RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Kumar Srinivasan
Hello,

Please review [1] which addresses bug [2]. This test is unnecessary, as
there
are other components and tests within the jdk, which will fail if ASM
is not included, therefore this test is  removed.

Thanks
Kumar

[1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/
[2] https://bugs.openjdk.java.net/browse/JDK-8076417
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Sundararajan Athijegannathan
+1

-Sundar

On 19/04/17, 12:09 AM, Kumar Srinivasan wrote:

> Hello,
>
> Please review [1] which addresses bug [2]. This test is unnecessary,
> as there
> are other components and tests within the jdk, which will fail if ASM
> is not included, therefore this test is  removed.
>
> Thanks
> Kumar
>
> [1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/
> [2] https://bugs.openjdk.java.net/browse/JDK-8076417
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Amy Lu-2
In reply to this post by Kumar Srinivasan
Hi, Kumar

As the removed test is the only one test under jdk/asm, it needs to be
removed from jdk_other test group:

--- a/test/TEST.groups
+++ b/test/TEST.groups
@@ -269,7 +269,6 @@
      javax/transaction \
      javax/xml \
      -javax/xml/crypto \
-    jdk/asm \


Thanks,
Amy

On 4/19/17 2:39 AM, Kumar Srinivasan wrote:

> Hello,
>
> Please review [1] which addresses bug [2]. This test is unnecessary,
> as there
> are other components and tests within the jdk, which will fail if ASM
> is not included, therefore this test is  removed.
>
> Thanks
> Kumar
>
> [1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/
> [2] https://bugs.openjdk.java.net/browse/JDK-8076417

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Kumar Srinivasan

Ah, yes, good catch. Thanks Amy.

Kumar

> Hi, Kumar
>
> As the removed test is the only one test under jdk/asm, it needs to be
> removed from jdk_other test group:
>
> --- a/test/TEST.groups
> +++ b/test/TEST.groups
> @@ -269,7 +269,6 @@
>      javax/transaction \
>      javax/xml \
>      -javax/xml/crypto \
> -    jdk/asm \
>
>
> Thanks,
> Amy
>
> On 4/19/17 2:39 AM, Kumar Srinivasan wrote:
>> Hello,
>>
>> Please review [1] which addresses bug [2]. This test is unnecessary,
>> as there
>> are other components and tests within the jdk, which will fail if ASM
>> is not included, therefore this test is  removed.
>>
>> Thanks
>> Kumar
>>
>> [1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/
>> [2] https://bugs.openjdk.java.net/browse/JDK-8076417
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Kumar Srinivasan
In reply to this post by Amy Lu-2

Made the change you recommended, and here is the updated webrev
http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/

Thanks
Kumar

> Hi, Kumar
>
> As the removed test is the only one test under jdk/asm, it needs to be
> removed from jdk_other test group:
>
> --- a/test/TEST.groups
> +++ b/test/TEST.groups
> @@ -269,7 +269,6 @@
>      javax/transaction \
>      javax/xml \
>      -javax/xml/crypto \
> -    jdk/asm \
>
>
> Thanks,
> Amy
>
> On 4/19/17 2:39 AM, Kumar Srinivasan wrote:
>> Hello,
>>
>> Please review [1] which addresses bug [2]. This test is unnecessary,
>> as there
>> are other components and tests within the jdk, which will fail if ASM
>> is not included, therefore this test is  removed.
>>
>> Thanks
>> Kumar
>>
>> [1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/
>> [2] https://bugs.openjdk.java.net/browse/JDK-8076417
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Amy Lu-2
On 4/20/17 2:26 AM, Kumar Srinivasan wrote:
>
> Made the change you recommended, and here is the updated webrev
> http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/
Thank you Kumar!Looks good.

(I'm not official reviewer)
Thanks,
Amy

>
> Thanks
> Kumar
>
>> Hi, Kumar
>>
>> As the removed test is the only one test under jdk/asm, it needs to
>> be removed from jdk_other test group:
>>
>> --- a/test/TEST.groups
>> +++ b/test/TEST.groups
>> @@ -269,7 +269,6 @@
>>      javax/transaction \
>>      javax/xml \
>>      -javax/xml/crypto \
>> -    jdk/asm \
>>
>>
>> Thanks,
>> Amy
>>
>> On 4/19/17 2:39 AM, Kumar Srinivasan wrote:
>>> Hello,
>>>
>>> Please review [1] which addresses bug [2]. This test is unnecessary,
>>> as there
>>> are other components and tests within the jdk, which will fail if ASM
>>> is not included, therefore this test is  removed.
>>>
>>> Thanks
>>> Kumar
>>>
>>> [1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8076417
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Mandy Chung
In reply to this post by Kumar Srinivasan

> On Apr 19, 2017, at 11:26 AM, Kumar Srinivasan <[hidden email]> wrote:
>
>
> Made the change you recommended, and here is the updated webrev
> http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/

+1

Mandy
Loading...