RFR (): 8140255: Move the management of G1YoungRemSetSamplingThread from G1ConcurrentRefine

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR (): 8140255: Move the management of G1YoungRemSetSamplingThread from G1ConcurrentRefine

Thomas Schatzl
Hi all,

  can I have reviews for this change that moves the ownership of the
young gen sampling thread from G1ConcurrentRefine to G1CollectedHeap,
in the process removing a few comments like "// The RS sampling thread
has nothing to do with refinement, but is here for now.".

CR:
https://bugs.openjdk.java.net/browse/JDK-8140255
Webrev:
http://cr.openjdk.java.net/~tschatzl/8140255/webrev/
Testing:
hs-tier1, hs-tier2, local testing

Thanks,
  Thomas
Reply | Threaded
Open this post in threaded view
|

Re: RFR (): 8140255: Move the management of G1YoungRemSetSamplingThread from G1ConcurrentRefine

Stefan Johansson
Hi Thomas,

On 2017-11-02 16:45, Thomas Schatzl wrote:

> Hi all,
>
>    can I have reviews for this change that moves the ownership of the
> young gen sampling thread from G1ConcurrentRefine to G1CollectedHeap,
> in the process removing a few comments like "// The RS sampling thread
> has nothing to do with refinement, but is here for now.".
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8140255
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8140255/webrev/
Looks good,
Stefan

> Testing:
> hs-tier1, hs-tier2, local testing
>
> Thanks,
>    Thomas

Reply | Threaded
Open this post in threaded view
|

Re: RFR (): 8140255: Move the management of G1YoungRemSetSamplingThread from G1ConcurrentRefine

sangheon.kim@oracle.com
In reply to this post by Thomas Schatzl
Hi Thomas,

On 11/02/2017 08:45 AM, Thomas Schatzl wrote:

> Hi all,
>
>    can I have reviews for this change that moves the ownership of the
> young gen sampling thread from G1ConcurrentRefine to G1CollectedHeap,
> in the process removing a few comments like "// The RS sampling thread
> has nothing to do with refinement, but is here for now.".
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8140255
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8140255/webrev/
> Testing:
> hs-tier1, hs-tier2, local testing
Looks good.

Thanks,
Sangheon


>
> Thanks,
>    Thomas

Reply | Threaded
Open this post in threaded view
|

Re: RFR (): 8140255: Move the management of G1YoungRemSetSamplingThread from G1ConcurrentRefine

Thomas Schatzl
Hi Sangheon, Stefan,

On Fri, 2017-11-03 at 16:45 -0700, sangheon.kim wrote:

> Hi Thomas,
>
> On 11/02/2017 08:45 AM, Thomas Schatzl wrote:
> > Hi all,
> >
> >    can I have reviews for this change that moves the ownership of
> > the
> > young gen sampling thread from G1ConcurrentRefine to
> > G1CollectedHeap,
> > in the process removing a few comments like "// The RS sampling
> > thread
> > has nothing to do with refinement, but is here for now.".
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8140255
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8140255/webrev/
> > Testing:
> > hs-tier1, hs-tier2, local testing
>
> Looks good.
>
> Thanks,
> Sangheon

On Fri, 2017-11-03 at 12:35 +0100, Stefan Johansson wrote:
> Hi Thomas,

[...]

> Looks good,
> Stefan

  thanks for your reviews.

Thomas