RFR: 8161255, jdk build "all" (docs) fails on all platforms, error from DefaultLoggerFinder.java

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8161255, jdk build "all" (docs) fails on all platforms, error from DefaultLoggerFinder.java

Bhavesh Patel
Hi,
     This is the fix for the issue in which the JDK API documentation build fails due to comment in DefaultLoggerFinder.java that points to a type in an unexported (internal) API. Doclint reports this is an error during the reference check and the documentation build fails. The makefile for javadoc needs to be updated to disable the reference check in the jdk.internal.logger package.

JBS: https://bugs.openjdk.java.net/browse/JDK-8161255
Webrev: http://cr.openjdk.java.net/~bpatel/8161255/webrev/

     Please review this change.

Thanks,
Bhavesh.
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8161255, jdk build "all" (docs) fails on all platforms, error from DefaultLoggerFinder.java

joe darcy
Hi Bhavesh,

This looks fine to get the build going again; please push this right away.

As we discussed off-list, there will probably need to be some additional
javadoc mechanisms so that checking for this kind of implementation
detail doesn't run afoul of doclint unnecessarily.

Thanks,

-Joe


On 7/13/2016 2:02 PM, Bhavesh Patel wrote:

> Hi,
>      This is the fix for the issue in which the JDK API documentation
> build fails due to comment in DefaultLoggerFinder.java that points to
> a type in an unexported (internal) API. Doclint reports this is an
> error during the reference check and the documentation build fails.
> The makefile for javadoc needs to be updated to disable the reference
> check in the jdk.internal.logger package.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8161255
> Webrev: http://cr.openjdk.java.net/~bpatel/8161255/webrev/
>
>      Please review this change.
>
> Thanks,
> Bhavesh.

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8161255, jdk build "all" (docs) fails on all platforms, error from DefaultLoggerFinder.java

Kumar Srinivasan
+1, I have also tested on Windows.

Kumar

On 7/13/2016 2:05 PM, joe darcy wrote:

> Hi Bhavesh,
>
> This looks fine to get the build going again; please push this right
> away.
>
> As we discussed off-list, there will probably need to be some
> additional javadoc mechanisms so that checking for this kind of
> implementation detail doesn't run afoul of doclint unnecessarily.
>
> Thanks,
>
> -Joe
>
>
> On 7/13/2016 2:02 PM, Bhavesh Patel wrote:
>> Hi,
>>      This is the fix for the issue in which the JDK API documentation
>> build fails due to comment in DefaultLoggerFinder.java that points to
>> a type in an unexported (internal) API. Doclint reports this is an
>> error during the reference check and the documentation build fails.
>> The makefile for javadoc needs to be updated to disable the reference
>> check in the jdk.internal.logger package.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8161255
>> Webrev: http://cr.openjdk.java.net/~bpatel/8161255/webrev/
>>
>>      Please review this change.
>>
>> Thanks,
>> Bhavesh.
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8161255, jdk build "all" (docs) fails on all platforms, error from DefaultLoggerFinder.java

Tim Bell
In reply to this post by Bhavesh Patel
Hi Bhavesh:

>      This is the fix for the issue in which the JDK API documentation
> build fails due to comment in DefaultLoggerFinder.java that points to
> a type in an unexported (internal) API. Doclint reports this is an
> error during the reference check and the documentation build fails.
> The makefile for javadoc needs to be updated to disable the reference
> check in the jdk.internal.logger package.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8161255
> Webrev: http://cr.openjdk.java.net/~bpatel/8161255/webrev/
>
>      Please review this change.

Looks good.  Approved.

Tim

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8161255, jdk build "all" (docs) fails on all platforms, error from DefaultLoggerFinder.java

Jonathan Gibbons
In reply to this post by joe darcy
Joe, all,

Work for javadoc support for modules is a work in progress.  While we
should have caught yesterday's problems ahead of time, it will also be
the case that as javadoc moves along, we will refine the contents of the
module summary page, so that items which should not be documented are
correctly omitted.

-- Jon


On 07/13/2016 02:05 PM, joe darcy wrote:

> Hi Bhavesh,
>
> This looks fine to get the build going again; please push this right
> away.
>
> As we discussed off-list, there will probably need to be some
> additional javadoc mechanisms so that checking for this kind of
> implementation detail doesn't run afoul of doclint unnecessarily.
>
> Thanks,
>
> -Joe
>
>
> On 7/13/2016 2:02 PM, Bhavesh Patel wrote:
>> Hi,
>>      This is the fix for the issue in which the JDK API documentation
>> build fails due to comment in DefaultLoggerFinder.java that points to
>> a type in an unexported (internal) API. Doclint reports this is an
>> error during the reference check and the documentation build fails.
>> The makefile for javadoc needs to be updated to disable the reference
>> check in the jdk.internal.logger package.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8161255
>> Webrev: http://cr.openjdk.java.net/~bpatel/8161255/webrev/
>>
>>      Please review this change.
>>
>> Thanks,
>> Bhavesh.
>