RFR: 8167178 Exported elements referring to inaccessible types in java.naming

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: 8167178 Exported elements referring to inaccessible types in java.naming

Vyom Tewari
Hi All,

Please review  below the small fix for the issue.

BugId : https://bugs.openjdk.java.net/browse/JDK-8167178

The compatibility impact is minimum as no code in JDK is currently
depend on it.

I will file a CCC today.

Thanks,

Vyom


--- a/src/java.naming/share/classes/javax/naming/CompoundName.java Fri
Dec 23 09:31:24 2016 +0530
+++ b/src/java.naming/share/classes/javax/naming/CompoundName.java Mon
Jan 16 13:36:48 2017 +0530
@@ -153,7 +153,7 @@
        * This field is initialized by the constructors and cannot be null.
        * It should be treated as a read-only variable by subclasses.
        */
-    protected transient NameImpl impl;
+    private transient NameImpl impl;
      /**
        * Syntax properties for this compound name.
        * This field is initialized by the constructors and cannot be null.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8167178 Exported elements referring to inaccessible types in java.naming

Alan Bateman
On 16/01/2017 09:10, Vyom Tewari wrote:

> Hi All,
>
> Please review  below the small fix for the issue.
>
> BugId : https://bugs.openjdk.java.net/browse/JDK-8167178
>
> The compatibility impact is minimum as no code in JDK is currently
> depend on it.
I think this is okay, it is technically an API change but I can't think
why anyone extending CompoundName would rely on this.

-Alan
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8167178 Exported elements referring to inaccessible types in java.naming

Chris Hegarty
In reply to this post by Vyom Tewari
Looks good. Thanks Vyom.

-Chris.

> On 16 Jan 2017, at 09:10, Vyom Tewari <[hidden email]> wrote:
>
> Hi All,
>
> Please review  below the small fix for the issue.
>
> BugId : https://bugs.openjdk.java.net/browse/JDK-8167178
>
> The compatibility impact is minimum as no code in JDK is currently depend on it.
>
> I will file a CCC today.
>
> Thanks,
>
> Vyom
>
>
> --- a/src/java.naming/share/classes/javax/naming/CompoundName.java Fri Dec 23 09:31:24 2016 +0530
> +++ b/src/java.naming/share/classes/javax/naming/CompoundName.java Mon Jan 16 13:36:48 2017 +0530
> @@ -153,7 +153,7 @@
>       * This field is initialized by the constructors and cannot be null.
>       * It should be treated as a read-only variable by subclasses.
>       */
> -    protected transient NameImpl impl;
> +    private transient NameImpl impl;
>     /**
>       * Syntax properties for this compound name.
>       * This field is initialized by the constructors and cannot be null.
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8167178 Exported elements referring to inaccessible types in java.naming

roger riggs
Hi Vyom,

Please also correct or remove the comment saying it should be treated as
read-only by subclasses.

Roger


On 1/16/2017 4:56 AM, Chris Hegarty wrote:

> Looks good. Thanks Vyom.
>
> -Chris.
>
>> On 16 Jan 2017, at 09:10, Vyom Tewari <[hidden email]> wrote:
>>
>> Hi All,
>>
>> Please review  below the small fix for the issue.
>>
>> BugId : https://bugs.openjdk.java.net/browse/JDK-8167178
>>
>> The compatibility impact is minimum as no code in JDK is currently depend on it.
>>
>> I will file a CCC today.
>>
>> Thanks,
>>
>> Vyom
>>
>>
>> --- a/src/java.naming/share/classes/javax/naming/CompoundName.java Fri Dec 23 09:31:24 2016 +0530
>> +++ b/src/java.naming/share/classes/javax/naming/CompoundName.java Mon Jan 16 13:36:48 2017 +0530
>> @@ -153,7 +153,7 @@
>>        * This field is initialized by the constructors and cannot be null.
>>        * It should be treated as a read-only variable by subclasses.
>>        */
>> -    protected transient NameImpl impl;
>> +    private transient NameImpl impl;
>>      /**
>>        * Syntax properties for this compound name.
>>        * This field is initialized by the constructors and cannot be null.
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8167178 Exported elements referring to inaccessible types in java.naming

Vyom Tewari
Hi Roger,

Thanks for the review i remove the comment saying it should be treated
as read only. Please find below the latest diff.

Thanks,

Vyom

--- a/src/java.naming/share/classes/javax/naming/CompoundName.java Fri
Dec 23 09:31:24 2016 +0530
+++ b/src/java.naming/share/classes/javax/naming/CompoundName.java Wed
Jan 18 12:14:25 2017 +0530
@@ -149,11 +149,10 @@
  public class CompoundName implements Name {

      /**
-      * Implementation of this compound name.
-      * This field is initialized by the constructors and cannot be null.
-      * It should be treated as a read-only variable by subclasses.
-      */
-    protected transient NameImpl impl;
+     * Implementation of this compound name. This field is initialized
by the
+     * constructors and cannot be null.
+     */
+    private transient NameImpl impl;
      /**
        * Syntax properties for this compound name.
        * This field is initialized by the constructors and cannot be null.


On Tuesday 17 January 2017 09:20 PM, Roger Riggs wrote:

> Hi Vyom,
>
> Please also correct or remove the comment saying it should be treated
> as read-only by subclasses.
>
> Roger
>
>
> On 1/16/2017 4:56 AM, Chris Hegarty wrote:
>> Looks good. Thanks Vyom.
>>
>> -Chris.
>>
>>> On 16 Jan 2017, at 09:10, Vyom Tewari <[hidden email]> wrote:
>>>
>>> Hi All,
>>>
>>> Please review  below the small fix for the issue.
>>>
>>> BugId : https://bugs.openjdk.java.net/browse/JDK-8167178
>>>
>>> The compatibility impact is minimum as no code in JDK is currently
>>> depend on it.
>>>
>>> I will file a CCC today.
>>>
>>> Thanks,
>>>
>>> Vyom
>>>
>>>
>>> --- a/src/java.naming/share/classes/javax/naming/CompoundName.java
>>> Fri Dec 23 09:31:24 2016 +0530
>>> +++ b/src/java.naming/share/classes/javax/naming/CompoundName.java
>>> Mon Jan 16 13:36:48 2017 +0530
>>> @@ -153,7 +153,7 @@
>>>        * This field is initialized by the constructors and cannot be
>>> null.
>>>        * It should be treated as a read-only variable by subclasses.
>>>        */
>>> -    protected transient NameImpl impl;
>>> +    private transient NameImpl impl;
>>>      /**
>>>        * Syntax properties for this compound name.
>>>        * This field is initialized by the constructors and cannot be
>>> null.
>>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8167178 Exported elements referring to inaccessible types in java.naming

roger riggs
Looks good.

Thanks, Roger

On 1/18/2017 1:47 AM, Vyom Tewari wrote:

> Hi Roger,
>
> Thanks for the review i remove the comment saying it should be treated
> as read only. Please find below the latest diff.
>
> Thanks,
>
> Vyom
>
> --- a/src/java.naming/share/classes/javax/naming/CompoundName.java Fri
> Dec 23 09:31:24 2016 +0530
> +++ b/src/java.naming/share/classes/javax/naming/CompoundName.java Wed
> Jan 18 12:14:25 2017 +0530
> @@ -149,11 +149,10 @@
>  public class CompoundName implements Name {
>
>      /**
> -      * Implementation of this compound name.
> -      * This field is initialized by the constructors and cannot be
> null.
> -      * It should be treated as a read-only variable by subclasses.
> -      */
> -    protected transient NameImpl impl;
> +     * Implementation of this compound name. This field is
> initialized by the
> +     * constructors and cannot be null.
> +     */
> +    private transient NameImpl impl;
>      /**
>        * Syntax properties for this compound name.
>        * This field is initialized by the constructors and cannot be
> null.
>
>
> On Tuesday 17 January 2017 09:20 PM, Roger Riggs wrote:
>> Hi Vyom,
>>
>> Please also correct or remove the comment saying it should be treated
>> as read-only by subclasses.
>>
>> Roger
>>
>>
>> On 1/16/2017 4:56 AM, Chris Hegarty wrote:
>>> Looks good. Thanks Vyom.
>>>
>>> -Chris.
>>>
>>>> On 16 Jan 2017, at 09:10, Vyom Tewari <[hidden email]> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review  below the small fix for the issue.
>>>>
>>>> BugId : https://bugs.openjdk.java.net/browse/JDK-8167178
>>>>
>>>> The compatibility impact is minimum as no code in JDK is currently
>>>> depend on it.
>>>>
>>>> I will file a CCC today.
>>>>
>>>> Thanks,
>>>>
>>>> Vyom
>>>>
>>>>
>>>> --- a/src/java.naming/share/classes/javax/naming/CompoundName.java
>>>> Fri Dec 23 09:31:24 2016 +0530
>>>> +++ b/src/java.naming/share/classes/javax/naming/CompoundName.java
>>>> Mon Jan 16 13:36:48 2017 +0530
>>>> @@ -153,7 +153,7 @@
>>>>        * This field is initialized by the constructors and cannot
>>>> be null.
>>>>        * It should be treated as a read-only variable by subclasses.
>>>>        */
>>>> -    protected transient NameImpl impl;
>>>> +    private transient NameImpl impl;
>>>>      /**
>>>>        * Syntax properties for this compound name.
>>>>        * This field is initialized by the constructors and cannot
>>>> be null.
>>>>
>>
>

Loading...