RFR: 8171235: Move archive object code from G1MarkSweep into G1ArchiveAllocator

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: 8171235: Move archive object code from G1MarkSweep into G1ArchiveAllocator

Stefan Johansson
Hi,

Please review this re-factoring:
https://bugs.openjdk.java.net/browse/JDK-8171235

Webrev:
http://cr.openjdk.java.net/~sjohanss/8171235/hotspot.00/

Summary:
This change moves the code checking if an object or region is associated
with the archive allocator from G1MarkSweep to G1ArchiveAllocator
itself. It makes more sense to keep all code for archive handling in one
class instead of spreading out the logic in more places.

Testing:
* JPRT
* RBT tier2 + tier3

Thanks,
Stefan
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8171235: Move archive object code from G1MarkSweep into G1ArchiveAllocator

Thomas Schatzl
Hi,

On Tue, 2017-02-21 at 11:17 +0100, Stefan Johansson wrote:

> Hi,
>
> Please review this re-factoring:
> https://bugs.openjdk.java.net/browse/JDK-8171235
>
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8171235/hotspot.00/
>
> Summary:
> This change moves the code checking if an object or region is
> associated 
> with the archive allocator from G1MarkSweep to G1ArchiveAllocator 
> itself. It makes more sense to keep all code for archive handling in
> one 
> class instead of spreading out the logic in more places.
>
> Testing:
> * JPRT
> * RBT tier2 + tier3

  looks good - apart from the copyright updates ;)

Thanks,
  Thomas
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8171235: Move archive object code from G1MarkSweep into G1ArchiveAllocator

Stefan Johansson
Thanks Thomas,

On 2017-02-21 12:49, Thomas Schatzl wrote:

> Hi,
>
> On Tue, 2017-02-21 at 11:17 +0100, Stefan Johansson wrote:
>> Hi,
>>
>> Please review this re-factoring:
>> https://bugs.openjdk.java.net/browse/JDK-8171235
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sjohanss/8171235/hotspot.00/
>>
>> Summary:
>> This change moves the code checking if an object or region is
>> associated
>> with the archive allocator from G1MarkSweep to G1ArchiveAllocator
>> itself. It makes more sense to keep all code for archive handling in
>> one
>> class instead of spreading out the logic in more places.
>>
>> Testing:
>> * JPRT
>> * RBT tier2 + tier3
>    looks good - apart from the copyright updates ;)
Will fix before pushing.

Thanks,
Stefan
> Thanks,
>    Thomas

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8171235: Move archive object code from G1MarkSweep into G1ArchiveAllocator

Kim Barrett
In reply to this post by Stefan Johansson
> On Feb 21, 2017, at 5:17 AM, Stefan Johansson <[hidden email]> wrote:
>
> Hi,
>
> Please review this re-factoring:
> https://bugs.openjdk.java.net/browse/JDK-8171235
>
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8171235/hotspot.00/
>
> Summary:
> This change moves the code checking if an object or region is associated with the archive allocator from G1MarkSweep to G1ArchiveAllocator itself. It makes more sense to keep all code for archive handling in one class instead of spreading out the logic in more places.
>
> Testing:
> * JPRT
> * RBT tier2 + tier3
>
> Thanks,
> Stefan

looks good

Loading...