Quantcast

RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

harold seigel
Hi,

Please review this JDK-10 fix to removing checking for duplicate
packages in the package list passed to JVM_DefineModule().  The checking
is potentially expensive and also redundant because the JDK makes the
same check.

Open webrev:
http://javaweb.us.oracle.com/~hseigel/webrev/bug_8172514/webrev/index.html

JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514

The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
tests, the co-located and non-colocated NSK tests, and with JPRT.

Thanks, Harold

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

George Triantafillou
Hi Harold,

Your changes look good.

-George

On 3/9/2017 10:44 AM, harold seigel wrote:

> Hi,
>
> Please review this JDK-10 fix to removing checking for duplicate
> packages in the package list passed to JVM_DefineModule().  The
> checking is potentially expensive and also redundant because the JDK
> makes the same check.
>
> Open webrev:
> http://javaweb.us.oracle.com/~hseigel/webrev/bug_8172514/webrev/index.html
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>
> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
> tests, the co-located and non-colocated NSK tests, and with JPRT.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

Claes Redestad
In reply to this post by harold seigel
Looks good to me!

(You might want to host the webrev on cr.openjdk.java.net, though..)

/Claes

On 03/09/2017 04:44 PM, harold seigel wrote:

> Hi,
>
> Please review this JDK-10 fix to removing checking for duplicate
> packages in the package list passed to JVM_DefineModule().  The
> checking is potentially expensive and also redundant because the JDK
> makes the same check.
>
> Open webrev:
> http://javaweb.us.oracle.com/~hseigel/webrev/bug_8172514/webrev/index.html
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>
> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
> tests, the co-located and non-colocated NSK tests, and with JPRT.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

harold seigel
In reply to this post by George Triantafillou
Thanks George!

Harold


On 3/9/2017 11:10 AM, George Triantafillou wrote:

> Hi Harold,
>
> Your changes look good.
>
> -George
>
> On 3/9/2017 10:44 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 fix to removing checking for duplicate
>> packages in the package list passed to JVM_DefineModule().  The
>> checking is potentially expensive and also redundant because the JDK
>> makes the same check.
>>
>> Open webrev:
>> http://javaweb.us.oracle.com/~hseigel/webrev/bug_8172514/webrev/index.html
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>
>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
>> tests, the co-located and non-colocated NSK tests, and with JPRT.
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

harold seigel
In reply to this post by Claes Redestad
Thanks Claes!

Here's the correct open webrev URL:
http://cr.openjdk.java.net/~hseigel/bug_8172514/webrev/index.html

Harold


On 3/9/2017 11:15 AM, Claes Redestad wrote:

> Looks good to me!
>
> (You might want to host the webrev on cr.openjdk.java.net, though..)
>
> /Claes
>
> On 03/09/2017 04:44 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 fix to removing checking for duplicate
>> packages in the package list passed to JVM_DefineModule().  The
>> checking is potentially expensive and also redundant because the JDK
>> makes the same check.
>>
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>
>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
>> tests, the co-located and non-colocated NSK tests, and with JPRT.
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

coleen.phillimore

This looks good.
Coleen

On 3/9/17 11:21 AM, harold seigel wrote:

> Thanks Claes!
>
> Here's the correct open webrev URL:
> http://cr.openjdk.java.net/~hseigel/bug_8172514/webrev/index.html
>
> Harold
>
>
> On 3/9/2017 11:15 AM, Claes Redestad wrote:
>> Looks good to me!
>>
>> (You might want to host the webrev on cr.openjdk.java.net, though..)
>>
>> /Claes
>>
>> On 03/09/2017 04:44 PM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this JDK-10 fix to removing checking for duplicate
>>> packages in the package list passed to JVM_DefineModule().  The
>>> checking is potentially expensive and also redundant because the JDK
>>> makes the same check.
>>>
>>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>>
>>> The fix was tested with the JCK lang and vm tests, the JTreg
>>> hotspot, java/io, java/lang, java/util and other tests, the RBT
>>> tier2 -tier5 tests, the co-located and non-colocated NSK tests, and
>>> with JPRT.
>>>
>>> Thanks, Harold
>>>
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

harold seigel
Thanks Coleen!

Harold


On 3/9/2017 4:51 PM, [hidden email] wrote:

>
> This looks good.
> Coleen
>
> On 3/9/17 11:21 AM, harold seigel wrote:
>> Thanks Claes!
>>
>> Here's the correct open webrev URL:
>> http://cr.openjdk.java.net/~hseigel/bug_8172514/webrev/index.html
>>
>> Harold
>>
>>
>> On 3/9/2017 11:15 AM, Claes Redestad wrote:
>>> Looks good to me!
>>>
>>> (You might want to host the webrev on cr.openjdk.java.net, though..)
>>>
>>> /Claes
>>>
>>> On 03/09/2017 04:44 PM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this JDK-10 fix to removing checking for duplicate
>>>> packages in the package list passed to JVM_DefineModule().  The
>>>> checking is potentially expensive and also redundant because the
>>>> JDK makes the same check.
>>>>
>>>>
>>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>>>
>>>> The fix was tested with the JCK lang and vm tests, the JTreg
>>>> hotspot, java/io, java/lang, java/util and other tests, the RBT
>>>> tier2 -tier5 tests, the co-located and non-colocated NSK tests, and
>>>> with JPRT.
>>>>
>>>> Thanks, Harold
>>>>
>>>
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

David Holmes
In reply to this post by harold seigel
On 10/03/2017 2:21 AM, harold seigel wrote:
> Thanks Claes!
>
> Here's the correct open webrev URL:
> http://cr.openjdk.java.net/~hseigel/bug_8172514/webrev/index.html

Looks fine to me.

Thanks,
David

> Harold
>
>
> On 3/9/2017 11:15 AM, Claes Redestad wrote:
>> Looks good to me!
>>
>> (You might want to host the webrev on cr.openjdk.java.net, though..)
>>
>> /Claes
>>
>> On 03/09/2017 04:44 PM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this JDK-10 fix to removing checking for duplicate
>>> packages in the package list passed to JVM_DefineModule().  The
>>> checking is potentially expensive and also redundant because the JDK
>>> makes the same check.
>>>
>>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>>
>>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
>>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
>>> tests, the co-located and non-colocated NSK tests, and with JPRT.
>>>
>>> Thanks, Harold
>>>
>>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

harold seigel
Hi David,

Thanks for the review!

Harold


On 3/9/2017 8:56 PM, David Holmes wrote:

> On 10/03/2017 2:21 AM, harold seigel wrote:
>> Thanks Claes!
>>
>> Here's the correct open webrev URL:
>> http://cr.openjdk.java.net/~hseigel/bug_8172514/webrev/index.html
>
> Looks fine to me.
>
> Thanks,
> David
>
>> Harold
>>
>>
>> On 3/9/2017 11:15 AM, Claes Redestad wrote:
>>> Looks good to me!
>>>
>>> (You might want to host the webrev on cr.openjdk.java.net, though..)
>>>
>>> /Claes
>>>
>>> On 03/09/2017 04:44 PM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this JDK-10 fix to removing checking for duplicate
>>>> packages in the package list passed to JVM_DefineModule(). The
>>>> checking is potentially expensive and also redundant because the JDK
>>>> makes the same check.
>>>>
>>>>
>>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>>>
>>>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
>>>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
>>>> tests, the co-located and non-colocated NSK tests, and with JPRT.
>>>>
>>>> Thanks, Harold
>>>>
>>>
>>

Loading...