RFR: 8173801 Modify makefiles to not build demos and samples bundles.

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: 8173801 Modify makefiles to not build demos and samples bundles.

Alexandre (Shura) Iline
Hi,

Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately.

Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/

Shura
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Modify makefiles to not build demos and samples bundles.

Magnus Ihse Bursie
On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
> Hi,
>
> Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>
> Shura
Looks good to me.

Good riddance! :-)

/Magnus

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Modify makefiles to not build demos and samples bundles.

Philip Race
What is the plan for ensuring there is still a way to build the client
demos - which are not being removed
but just moved. Doesn't this makefile need to be somewhere still ?

-phil.

On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:

> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>> Hi,
>>
>> Could you be so kind to review suggested changes for the makefiles to
>> stop producing sales and demos bundle. Pls note that this request
>> only changes the makefiles, it does not remove demos and samples
>> source code, which will be done separately.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>
>> Shura
> Looks good to me.
>
> Good riddance! :-)
>
> /Magnus
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Modify makefiles to not build demos and samples bundles.

Philip Race
And to be clear, the provision for still building these client demos
needs to be made BEFORE this is pushed.
Or at least as *part* of this push.
Else we will be unable to perform our normal integration testing at this
critical juncture of JDK 9 ..

-phil.

On 03/03/2017 09:39 AM, Phil Race wrote:

> What is the plan for ensuring there is still a way to build the client
> demos - which are not being removed
> but just moved. Doesn't this makefile need to be somewhere still ?
>
> -phil.
>
> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>> Hi,
>>>
>>> Could you be so kind to review suggested changes for the makefiles
>>> to stop producing sales and demos bundle. Pls note that this request
>>> only changes the makefiles, it does not remove demos and samples
>>> source code, which will be done separately.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>
>>> Shura
>> Looks good to me.
>>
>> Good riddance! :-)
>>
>> /Magnus
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Modify makefiles to not build demos and samples bundles.

Alexandre (Shura) Iline
Creating some other makefiles was not planned as a part of this JEP, Phil.

If the demos are used for testing, do you want me do turn them into manual tests?

Shura

> On Mar 3, 2017, at 2:45 PM, Phil Race <[hidden email]> wrote:
>
> And to be clear, the provision for still building these client demos needs to be made BEFORE this is pushed.
> Or at least as *part* of this push.
> Else we will be unable to perform our normal integration testing at this critical juncture of JDK 9 ..
>
> -phil.
>
> On 03/03/2017 09:39 AM, Phil Race wrote:
>> What is the plan for ensuring there is still a way to build the client demos - which are not being removed
>> but just moved. Doesn't this makefile need to be somewhere still ?
>>
>> -phil.
>>
>> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>>> Hi,
>>>>
>>>> Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>>
>>>> Shura
>>> Looks good to me.
>>>
>>> Good riddance! :-)
>>>
>>> /Magnus
>>>
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Remove non-client demos and samples

Alexandre (Shura) Iline
In reply to this post by Philip Race
After some back and forth it was decided that the client demos should stay intact for JDK9 and be reworked into tests as a part of another JEP.

With that, could you take another look on the suggested changes?
http://cr.openjdk.java.net/~shurailine/8173801/webrev.03

Thank you.

Shura


> On Mar 3, 2017, at 9:39 AM, Phil Race <[hidden email]> wrote:
>
> What is the plan for ensuring there is still a way to build the client demos - which are not being removed
> but just moved. Doesn't this makefile need to be somewhere still ?
>
> -phil.
>
> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>> Hi,
>>>
>>> Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>
>>> Shura
>> Looks good to me.
>>
>> Good riddance! :-)
>>
>> /Magnus
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Remove non-client demos and samples

Philip Race
All the parts of that which I understand look fine to me.
The netbeans XML I know nothing about ..

-phil.

On 4/7/2017 2:05 PM, Alexandre (Shura) Iline wrote:

> After some back and forth it was decided that the client demos should stay intact for JDK9 and be reworked into tests as a part of another JEP.
>
> With that, could you take another look on the suggested changes?
> http://cr.openjdk.java.net/~shurailine/8173801/webrev.03
>
> Thank you.
>
> Shura
>
>
>> On Mar 3, 2017, at 9:39 AM, Phil Race <[hidden email]> wrote:
>>
>> What is the plan for ensuring there is still a way to build the client demos - which are not being removed
>> but just moved. Doesn't this makefile need to be somewhere still ?
>>
>> -phil.
>>
>> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>>> Hi,
>>>>
>>>> Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>>
>>>> Shura
>>> Looks good to me.
>>>
>>> Good riddance! :-)
>>>
>>> /Magnus
>>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Remove non-client demos and samples

Erik Joelsson
In reply to this post by Alexandre (Shura) Iline
Hello,

CompileDemos.gmk: 270: The $(call install-file) line shouldn't be removed

make/Bundles.gmk: 186: Since the client demos are still in there, they
still need to be filtered out of the image when creating the JDK bundle.

Otherwise this looks ok.

/Erik


On 2017-04-07 23:05, Alexandre (Shura) Iline wrote:

> After some back and forth it was decided that the client demos should stay intact for JDK9 and be reworked into tests as a part of another JEP.
>
> With that, could you take another look on the suggested changes?
> http://cr.openjdk.java.net/~shurailine/8173801/webrev.03
>
> Thank you.
>
> Shura
>
>
>> On Mar 3, 2017, at 9:39 AM, Phil Race <[hidden email]> wrote:
>>
>> What is the plan for ensuring there is still a way to build the client demos - which are not being removed
>> but just moved. Doesn't this makefile need to be somewhere still ?
>>
>> -phil.
>>
>> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>>> Hi,
>>>>
>>>> Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>>
>>>> Shura
>>> Looks good to me.
>>>
>>> Good riddance! :-)
>>>
>>> /Magnus
>>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Remove non-client demos and samples

Magnus Ihse Bursie
On 2017-04-10 09:51, Erik Joelsson wrote:
> Hello,
>
> CompileDemos.gmk: 270: The $(call install-file) line shouldn't be removed
>
> make/Bundles.gmk: 186: Since the client demos are still in there, they
> still need to be filtered out of the image when creating the JDK bundle.
>
> Otherwise this looks ok.

Agree, with these things fixed it looks good.

/Magnus

>
> /Erik
>
>
> On 2017-04-07 23:05, Alexandre (Shura) Iline wrote:
>> After some back and forth it was decided that the client demos should
>> stay intact for JDK9 and be reworked into tests as a part of another
>> JEP.
>>
>> With that, could you take another look on the suggested changes?
>> http://cr.openjdk.java.net/~shurailine/8173801/webrev.03
>>
>> Thank you.
>>
>> Shura
>>
>>
>>> On Mar 3, 2017, at 9:39 AM, Phil Race <[hidden email]> wrote:
>>>
>>> What is the plan for ensuring there is still a way to build the
>>> client demos - which are not being removed
>>> but just moved. Doesn't this makefile need to be somewhere still ?
>>>
>>> -phil.
>>>
>>> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>>>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>>>> Hi,
>>>>>
>>>>> Could you be so kind to review suggested changes for the makefiles
>>>>> to stop producing sales and demos bundle. Pls note that this
>>>>> request only changes the makefiles, it does not remove demos and
>>>>> samples source code, which will be done separately.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>>>
>>>>> Shura
>>>> Looks good to me.
>>>>
>>>> Good riddance! :-)
>>>>
>>>> /Magnus
>>>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8173801 Remove non-client demos and samples

Alexandre (Shura) Iline
Thank you for review!

I have fixed and tested - all good.

Will push tomorrow morning.

Shura

> On Apr 11, 2017, at 1:19 AM, Magnus Ihse Bursie <[hidden email]> wrote:
>
> On 2017-04-10 09:51, Erik Joelsson wrote:
>> Hello,
>>
>> CompileDemos.gmk: 270: The $(call install-file) line shouldn't be removed
>>
>> make/Bundles.gmk: 186: Since the client demos are still in there, they still need to be filtered out of the image when creating the JDK bundle.
>>
>> Otherwise this looks ok.
>
> Agree, with these things fixed it looks good.
>
> /Magnus
>
>>
>> /Erik
>>
>>
>> On 2017-04-07 23:05, Alexandre (Shura) Iline wrote:
>>> After some back and forth it was decided that the client demos should stay intact for JDK9 and be reworked into tests as a part of another JEP.
>>>
>>> With that, could you take another look on the suggested changes?
>>> http://cr.openjdk.java.net/~shurailine/8173801/webrev.03
>>>
>>> Thank you.
>>>
>>> Shura
>>>
>>>
>>>> On Mar 3, 2017, at 9:39 AM, Phil Race <[hidden email]> wrote:
>>>>
>>>> What is the plan for ensuring there is still a way to build the client demos - which are not being removed
>>>> but just moved. Doesn't this makefile need to be somewhere still ?
>>>>
>>>> -phil.
>>>>
>>>> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>>>>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Could you be so kind to review suggested changes for the makefiles to stop producing sales and demos bundle. Pls note that this request only changes the makefiles, it does not remove demos and samples source code, which will be done separately.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>>>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>>>>
>>>>>> Shura
>>>>> Looks good to me.
>>>>>
>>>>> Good riddance! :-)
>>>>>
>>>>> /Magnus
>>>>>
>>
>

Loading...