RFR 8176320: security/tools/jarsigner/TsacertOptionTest.java compilation error, all mach 5 tier 2 platforms broken.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR 8176320: security/tools/jarsigner/TsacertOptionTest.java compilation error, all mach 5 tier 2 platforms broken.

Weijun Wang
Please review this fix:

diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
--- a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
+++ b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
@@ -29,6 +29,7 @@
   * @bug 8024302 8026037
   * @summary The test signs and verifies a jar file with -tsacert option
   * @library /lib/testlibrary warnings
+ * @library /test/lib
   * @modules java.base/sun.security.pkcs
   *          java.base/sun.security.timestamp
   *          java.base/sun.security.tools.keytool

This test calls a method in TimestampToken.java which uses a lib in
/test/lib. The lib is in @library of TimestampToken.java therefore there
is no problem running TimestampToken.java. There is also no problem
running this test if TimestampToken.java is already compiled and we have
the lib classes ready. But if TimestampToken.java is not already
compiled, this test will not compile. This is just random.

Thanks
Max
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8176320: security/tools/jarsigner/TsacertOptionTest.java compilation error, all mach 5 tier 2 platforms broken.

Xuelei Fan-2
Looks fine to me.

Xuelei

On 3/7/2017 7:19 PM, Weijun Wang wrote:

> Please review this fix:
>
> diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
> b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
> --- a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
> +++ b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
> @@ -29,6 +29,7 @@
>   * @bug 8024302 8026037
>   * @summary The test signs and verifies a jar file with -tsacert option
>   * @library /lib/testlibrary warnings
> + * @library /test/lib
>   * @modules java.base/sun.security.pkcs
>   *          java.base/sun.security.timestamp
>   *          java.base/sun.security.tools.keytool
>
> This test calls a method in TimestampToken.java which uses a lib in
> /test/lib. The lib is in @library of TimestampToken.java therefore there
> is no problem running TimestampToken.java. There is also no problem
> running this test if TimestampToken.java is already compiled and we have
> the lib classes ready. But if TimestampToken.java is not already
> compiled, this test will not compile. This is just random.
>
> Thanks
> Max
Loading...